Merge lp:~ree/loggerhead/abstract-paths-fix into lp:loggerhead

Proposed by Balazs Ree
Status: Rejected
Rejected by: Max Kanat-Alexander
Proposed branch: lp:~ree/loggerhead/abstract-paths-fix
Merge into: lp:loggerhead
To merge this branch: bzr merge lp:~ree/loggerhead/abstract-paths-fix
Reviewer Review Type Date Requested Status
Loggerhead Team Pending
Review via email: mp+2587@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Balazs Ree (ree) wrote :

Hi. I had this for a while but forgot to submit it.

One part of the fix is a consequence of the changes already implemented. The other part ("raw" handler) is something that can be discussed and modified if needed.

More info is at the end of:

https://bugs.launchpad.net/launchpad-bazaar/+bug/128926

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

The problem with a raw handler is that for launchpad, we are really very keen on _not_ displaying arbitrary user content as html to avoid cross site scripting issues. It seems to be a desired feature though, so we should probably figure out some way of disabling/enabling it...

Revision history for this message
Max Kanat-Alexander (mkanat) wrote :

This appears to have been merged long ago, or at least fixed.

Revision history for this message
Max Kanat-Alexander (mkanat) wrote :

Oh, or more accurately, I believe that this was superseded by another merge. I can't quite tell, this is pretty old.

Unmerged revisions

248. By Balazs Ree

Make raw file navigable from the file view page

247. By Balazs Ree

Merge the missing import bzrlib.textfile fix from ~mnordhoff/loggerhead/fix-textfile-import

246. By Balazs Ree

Merged from trunk

245. By Balazs Ree

Attempt to fix direct file access:
- make download also use the full path access scheme
- make a "raw" controller that is the same as download,
  but links are followed instead of saved. This makes
  it possible to publish a built sphinx documentation.

Subscribers

People subscribed via source and target branches