Merge ~redriver/cloud-init:fix-ifdown-for-frbsd-on-Azure into cloud-init:master

[Hongjiang Zhang]

replace ifdown/ifup with "ifconfig down" and "ifconfig up" on FreeBSD

Fix the issue caused by different commands on Linux and FreeBSD. On Linux, we used ifdown and ifup to enable and disable a NIC, but on FreeBSD, the counterpart is "ifconfig down" and "ifconfig up"

LP: #1697815

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:945ef848ecdee7b58f57264a1baf4baaad282036
https://jenkins.ubuntu.com/server/job/cloud-init-ci/533/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/533/console
    FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-arm64/533/console
    FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-ppc64el/533/console
    FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-s390x/533/console
    FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=vm-i386/533/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/533/rebuild

review: Needs Fixing (continuous-integration)

4558e3d... by Hongjiang Zhang on 2017-06-15

make the string less in one line

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:4558e3d1448d29697a094a638b8f5b5b0c9ca8a8
https://jenkins.ubuntu.com/server/job/cloud-init-ci/534/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/534
    SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-arm64/534
    SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-ppc64el/534
    SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-s390x/534
    SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=vm-i386/534

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/534/rebuild

review: Approve (continuous-integration)

[Scott Moser (smoser)]

this seems sane just looking at the diff, i'll look further today.

i think you'd opened a bug though... need to link to it.

diff --git a/cloudinit/sources/DataSourceAzure.py b/cloudinit/sources/DataSourceAzure.py
index a0b9eae..3eda2ce 100644
--- a/cloudinit/sources/DataSourceAzure.py
+++ b/cloudinit/sources/DataSourceAzure.py
@@ -177,6 +177,11 @@ if util.is_FreeBSD():
         RESOURCE_DISK_PATH = "/dev/" + res_disk
     else:
         LOG.debug("resource disk is None")
+    BOUNCE_COMMAND = [
+        'sh', '-xc',
+        "i=$interface; x=0; ",
+        "ifconfig down $i || x=$?; ifconfig up $i || x=$?; exit $x"
+    ]
 
 BUILTIN_DS_CONFIG = {
     'agent_command': AGENT_START_BUILTIN,