On Fri, 14 Apr 2017, Hongjiang Zhang wrote:
> Hi Scott, > > I have manually merged your modifications to my branch and fixed a unit test issue. > Do you think it is ok for merging?
The only thing I had left was that I'm still confused as what why we need azure specific code in that code path.
I have to think about it some more and probably go play with it a little on freebsd.
> > Thanks > Hongjiang Zhang > > > -----Original Message----- > From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Scott Moser > Sent: Thursday, April 13, 2017 2:51 AM > To: <email address hidden> > Subject: Re: [Merge] ~redriver/cloud-init:frbsd-azure-branch into cloud-init:master > > Other than that and I think it looks really good. > thank you for adding the unit tests. > > -- > https://na01.safelinks.protection.outlook.com/?url=https:%2F%2Fcode.launchpad.net%2F~redriver%2Fcloud-init%2F%2Bgit%2Fcloud-init%2F%2Bmerge%2F314895&data=02%7C01%7Chonzhan%40microsoft.com%7Ca62135a0b9514c7e130608d481d4cf8c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636276198391371945&sdata=qGDZNXUPvGHGs3%2ByT685EVs8jwnZQ12YIWBT%2BBrMPb8%3D&reserved=0 > You are the owner of ~redriver/cloud-init:frbsd-azure-branch. >
« Back to merge proposal
On Fri, 14 Apr 2017, Hongjiang Zhang wrote:
> Hi Scott,
>
> I have manually merged your modifications to my branch and fixed a unit test issue.
> Do you think it is ok for merging?
The only thing I had left was that I'm still confused as what why we need
azure specific code in that code path.
I have to think about it some more and probably go play with it a little
on freebsd.
> cloud-init: frbsd-azure- branch into cloud-init:master /na01.safelinks .protection. outlook. com/?url= https:% 2F%2Fcode. launchpad. net%2F~ redriver% 2Fcloud- init%2F% 2Bgit%2Fcloud- init%2F% 2Bmerge% 2F314895& data=02% 7C01%7Chonzhan% 40microsoft. com%7Ca62135a0b 9514c7e130608d4 81d4cf8c% 7C72f988bf86f14 1af91ab2d7cd011 db47%7C1% 7C0%7C636276198 391371945& sdata=qGDZNXUPv GHGs3%2ByT685EV s8jwnZQ12YIWBT% 2BBrMPb8% 3D&reserved= 0 cloud-init: frbsd-azure- branch.
> Thanks
> Hongjiang Zhang
>
>
> -----Original Message-----
> From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Scott Moser
> Sent: Thursday, April 13, 2017 2:51 AM
> To: <email address hidden>
> Subject: Re: [Merge] ~redriver/
>
> Other than that and I think it looks really good.
> thank you for adding the unit tests.
>
> --
> https:/
> You are the owner of ~redriver/
>