Merge lp:~redhatter/juju-core/docs-fix-maas-hyperlink into lp:juju-core/docs

Proposed by Stuart Longland
Status: Merged
Approved by: Nick Veitch
Approved revision: no longer in the source branch.
Merge reported by: Nick Veitch
Merged at revision: not available
Proposed branch: lp:~redhatter/juju-core/docs-fix-maas-hyperlink
Merge into: lp:juju-core/docs
Diff against target: 12 lines (+1/-1)
1 file modified
htmldocs/config-maas.html (+1/-1)
To merge this branch: bzr merge lp:~redhatter/juju-core/docs-fix-maas-hyperlink
Reviewer Review Type Date Requested Status
John A Meinel (community) Approve
Review via email: mp+172253@code.launchpad.net

This proposal supersedes a proposal from 2013-06-28.

Description of the change

Fix a typo in a hyperlink: links to remote sites need to specify a protocol otherwise the browser assumes they're relative links.

To post a comment you must log in.
Revision history for this message
Stuart Longland (redhatter) wrote : Posted in a previous version of this proposal

On 28/06/13 10:35, Stuart Longland wrote:
> Stuart Longland has proposed merging lp:~redhatter/juju-core/docs-fix-maas-hyperlink into lp:juju-core.
>
> Requested reviews:
> juju hackers (juju)
>
> For more details, see:
> https://code.launchpad.net/~redhatter/juju-core/docs-fix-maas-hyperlink/+merge/171937
>
> Fix a typo in a hyperlink: links to remote sites need to specify a protocol otherwise the browser assumes they're relative links.
>

Errm... okay, that attachment looks nothing like my commit. I was
changing one line in one file:

> ------------------------------------------------------------
> revno: 11
> committer: Stuart Longland <email address hidden>
> branch nick: juju-docs
> timestamp: Fri 2013-06-28 10:29:40 +1000
> message:
> config-maas.html: Fix broken link to maas.ubuntu.com
>
> The link should have a protocol specified, as it is a link to another site, not
> a relative link to a file called 'maas.ubuntu.com'.
> diff:
> === modified file 'htmldocs/config-maas.html'
> --- htmldocs/config-maas.html 2013-06-27 17:56:54 +0000
> +++ htmldocs/config-maas.html 2013-06-28 00:29:40 +0000
> @@ -103,7 +103,7 @@
> <article>
> <section id="config_maas">
> <h1>Configuring for MAAS</h1>
> - <p>Metal As A Service is software which allows you to deal with physical hardware just as easily as virtual nodes. For more information about MAAS, see <a href="maas.ubuntu.com"> maas.ubuntu.com </a> </p>
> + <p>Metal As A Service is software which allows you to deal with physical hardware just as easily as virtual nodes. For more information about MAAS, see <a href="http://maas.ubuntu.com"> maas.ubuntu.com </a> </p>
> <h1> Get your API key</h1>
> <p>You'll need an API key from MAAS so that the Juju client can access it. Each user account in MAAS can have as many API keys as desired. One hard and fast rule is that you'll need to use a different API key for each Juju environment you set up within a single MAAS cluster.</p>
> <p>To get the API key:</p>

Hope that clears up the noise.
Regards,
--
## -,-''''-. ###### Stuart Longland, Contractor
##. : ## : ## 38b Douglas Street
 ## # ## -'` .#' Milton, QLD, 4064
 '#' *' '-. *' http://www.vrt.com.au
     S Y S T E M S T: +61 7 3535 9619 F: +61 7 3535 9699

Revision history for this message
William Reade (fwereade) wrote : Posted in a previous version of this proposal

Please target this into lp:juju-core/docs. There's talk of merging the two, but nothing conclusive at the moment.

Revision history for this message
Stuart Longland (redhatter) wrote :

Okay, that's the magic URL I was trying to guess. For whatever reason, the URL in the previous merge request was the default; and adding docs/ to it didn't fix it.

Revision history for this message
John A Meinel (jameinel) wrote :

LGTM

review: Approve
Revision history for this message
Nick Veitch (evilnick) wrote :

merged. thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'htmldocs/config-maas.html'
2--- htmldocs/config-maas.html 2013-06-27 17:56:54 +0000
3+++ htmldocs/config-maas.html 2013-06-30 22:07:28 +0000
4@@ -103,7 +103,7 @@
5 <article>
6 <section id="config_maas">
7 <h1>Configuring for MAAS</h1>
8- <p>Metal As A Service is software which allows you to deal with physical hardware just as easily as virtual nodes. For more information about MAAS, see <a href="maas.ubuntu.com"> maas.ubuntu.com </a> </p>
9+ <p>Metal As A Service is software which allows you to deal with physical hardware just as easily as virtual nodes. For more information about MAAS, see <a href="http://maas.ubuntu.com"> maas.ubuntu.com </a> </p>
10 <h1> Get your API key</h1>
11 <p>You'll need an API key from MAAS so that the Juju client can access it. Each user account in MAAS can have as many API keys as desired. One hard and fast rule is that you'll need to use a different API key for each Juju environment you set up within a single MAAS cluster.</p>
12 <p>To get the API key:</p>

Subscribers

People subscribed via source and target branches