Code review comment for lp:~rconradharris/nova/xs-snap-return-image-id-before-snapshot

Revision history for this message
Rick Harris (rconradharris) wrote :

> compute.api.snapshot sets is_public to True by default. This seems like a poor default to me.

Agreed. I'm doing it this way right now because Glance (as of yet) doesn't really support images-tied-to-servers. So, in order for an image to be visible, it has to be public.

Adding the image-instance relationships should definitely be part of Cactus (I don't think we should cram it into Bexar since there still needs to be some discussion on how best to do it).

For now, I've added a TODO so we don't forget. Soren, does that work for you for now?

« Back to merge proposal