bugfix/snap_base_regression-eoan : lp:~rcj/livecd-rootfs/+git/livecd-rootfs : Git : Code : livecd-rootfs

Get this branch:: git clone -b bugfix/snap_base_regression-eoan https://git.launchpad.net/~rcj/livecd-rootfs/+git/livecd-rootfs

Only Robert C Jennings can upload to this branch. If you are Robert C Jennings please log in for upload directions.

Branch merges

Merged into livecd-rootfs:ubuntu/eoan at revision 64b05104aa7d4f899829b8ecf39e88fca8edc1e7

Steve Langasek: Approve on 2020-02-27

Branch information

Name:: bugfix/snap_base_regression-eoan

Repository:: lp:~rcj/livecd-rootfs/+git/livecd-rootfs

Recent commits

64b0510... by Robert C Jennings on 2020-02-25

Address snap base regression after snap-tool removal

With the removal of snap-tool failures are seen in image builds that do
not have the 'core' snap included by the seed. This is the case for the
minimized subproject of the ubuntu-cpc project where lxd/core is removed.
In that subproject, any binary hook which adds a snap that is based
on 'core' will not add 'core' and fail 'snap debug validate-seed'.
snap-tool included the following logic in the 'snap-tool info' when
determining snap bases:

    # Have "base" initialized to something meaningful.
    if self.is_core_snap():
        snap_data["snap"]["base"] = ""
    elif snap_data["snap"].get("base") is None:
        snap_data["snap"]["base"] = "core"

The snap store does not return a base if the base is core which makes
this necessary. This patch looks for the base in 'snap info' output
and if none is found (and the snap is not snapd or core) it assumes the
base is 'core' and installs it. This restores the behavior lost in the
migration from snap-tool to snap cli.

2b0d201... by Robert C Jennings on 2020-02-22

Use snap cli rather than custom snap-tool (LP: #1864252)

snap-tool was added to support a deprecate cohort-key feature of the
snap store. Recent changes in snap assertions have added additional
fields which snap-tool is not retrieving. This resulted in snap install
failures on first boot.

This patch removes snap-tool and returns to using the snap cli.
This ensures snap downloads will function without odd incompatibilities.

7c85d91... by Adam Conrad on 2019-10-14