Code review comment for lp:~rcart/ubuntu/precise/mpd/fix-947551

Revision history for this message
Ronny Cardona (rcart) wrote :

1. Yes, I tested it using 'ubuntu-bug mpd' and checking the report. The 'MpdUserConf' key was attached with the user configuration file overwriting the password field, if any.

2. Right. As you can see in the file (source_mpd.py) I'm using '"' to find the password value, and then, replace it with '@@APPORTREPACLACED@@':
                if 'password' in line.split('"')[0]:
                    line = "%s \"@@APPORTREPLACED@@\" " % (line.split('"')[0])

3. There's already a copyright file in debian/copyright. What you mean by documented?

Thanks for your time.

« Back to merge proposal