Merge lp:~rcarrillocruz/nova/lp708329 into lp:~hudson-openstack/nova/trunk

Proposed by Ricardo Carrillo Cruz
Status: Merged
Approved by: Devin Carlen
Approved revision: 658
Merged at revision: 666
Proposed branch: lp:~rcarrillocruz/nova/lp708329
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 13 lines (+2/-1)
1 file modified
nova/api/ec2/cloud.py (+2/-1)
To merge this branch: bzr merge lp:~rcarrillocruz/nova/lp708329
Reviewer Review Type Date Requested Status
Devin Carlen (community) Approve
Jay Pipes (community) Approve
Review via email: mp+49557@code.launchpad.net

Description of the change

Hi guys

This branch fixes lp708329.

Have a look at cloud.py/describe_security_groups , it was just a matter of sorting by project, then by group name before returning the groups.

Regards

To post a comment you must log in.
Revision history for this message
Jay Pipes (jaypipes) wrote :

lgtm.

review: Approve
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/api/ec2/cloud.py'
2--- nova/api/ec2/cloud.py 2011-02-07 23:01:57 +0000
3+++ nova/api/ec2/cloud.py 2011-02-13 18:57:54 +0000
4@@ -327,7 +327,8 @@
5 if not group_name is None:
6 groups = [g for g in groups if g.name in group_name]
7
8- return {'securityGroupInfo': groups}
9+ return {'securityGroupInfo':
10+ sorted(groups, key=lambda k: (k['ownerId'], k['groupName']))}
11
12 def _format_security_group(self, context, group):
13 g = {}