Merge lp:~rbalint/update-manager/lp-1795898-lp-1790670-cosmic into lp:update-manager

[Balint Reczey]

[Brian Murray (brian-murray)]

I've just a couple of minor in-line comments, otherwise this looks good to me.

[Balint Reczey (rbalint)]

Now the tests are also passing.

[Julian Andres Klode (juliank)]

lgtm

review: Approve

=== modified file 'UpdateManager/backend/InstallBackendAptdaemon.py'
--- UpdateManager/backend/InstallBackendAptdaemon.py	2018-09-27 14:15:39 +0000
+++ UpdateManager/backend/InstallBackendAptdaemon.py	2018-10-03 22:47:51 +0000
@@ -49,8 +49,13 @@
         self.trans_failed_msg = None
 
     def close(self):
-        if self.button_cancel:
-            self.button_cancel.clicked()
+        if self.button_cancel and self.button_cancel.get_sensitive():
+            try:
+                self.button_cancel.clicked()
+            except Exception:
+                # there is not much left to do if the transaction can't be
+                # canceled
+                pass
             return True
         else:
             return False

=== modified file 'UpdateManager/backend/__init__.py'
--- UpdateManager/backend/__init__.py	2018-10-01 15:56:40 +0000
+++ UpdateManager/backend/__init__.py	2018-10-03 22:47:51 +0000
@@ -95,6 +95,25 @@
                 self.window_main.start_available(is_cancelled_update)
 
 
+# try aptdaemon
+if os.path.exists("/usr/sbin/aptd") \
+   and "UPDATE_MANAGER_FORCE_BACKEND_SYNAPTIC" not in os.environ:
+    # check if the gtkwidgets are installed as well
+    try:
+        from .InstallBackendAptdaemon import InstallBackendAptdaemon
+    except ImportError:
+        import logging
+        logging.exception("importing aptdaemon")
+# try synaptic
+if os.path.exists("/usr/sbin/synaptic") \
+   and "UPDATE_MANAGER_FORCE_BACKEND_APTDAEMON" not in os.environ:
+    try:
+        from .InstallBackendSynaptic import InstallBackendSynaptic
+    except ImportError:
+        import logging
+        logging.exception("importing synaptic")
+
+
 def get_backend(*args, **kwargs):
     """Select and return a package manager backend."""
     # try aptdaemon
@@ -102,16 +121,17 @@
             and "UPDATE_MANAGER_FORCE_BACKEND_SYNAPTIC" not in os.environ):
         # check if the gtkwidgets are installed as well
         try:
-            from .InstallBackendAptdaemon import InstallBackendAptdaemon
             return InstallBackendAptdaemon(*args, **kwargs)
-        except ImportError:
+        except NameError:
             import logging
-            logging.exception("importing aptdaemon")
+            logging.exception("using aptdaemon failed")
     # try synaptic
     if (os.path.exists("/usr/sbin/synaptic")
             and "UPDATE_MANAGER_FORCE_BACKEND_APTDAEMON" not in os.environ):
-        from .InstallBackendSynaptic import InstallBackendSynaptic
-        return InstallBackendSynaptic(*args, **kwargs)
+        try:
+            return InstallBackendSynaptic(*args, **kwargs)
+        except NameError:
+            pass
     # nothing found, raise
     raise Exception("No working backend found, please try installing "
-                    "synaptic or aptdaemon")
+                    "aptdaemon or synaptic")

=== modified file 'debian/changelog'
--- debian/changelog	2018-10-01 16:04:16 +0000
+++ debian/changelog	2018-10-03 22:47:51 +0000
@@ -1,3 +1,14 @@
+update-manager (1:18.10.10) cosmic; urgency=medium
+
+  * Stop lazy import of InstallBackends.
+    Lazy imports made update-manager crash when an update-manager
+    update changed the backend API and an updated incompatible backend
+    was loaded to the not updated running update-manager process. (LP: #1795898)
+  * Cancel transaction on exit only when Cancel button is active.
+    Also ignore exception when cancellation fails. (LP: #1790670)
+
+ -- Balint Reczey <[e-mail]>  Wed, 03 Oct 2018 22:46:36 +0200
+
 update-manager (1:18.10.9) cosmic; urgency=medium
 
   * Allow unselecting updates and performing only removals (LP: #1792320)

=== added file 'tests/test_backend_error.py'
--- tests/test_backend_error.py	1970-01-01 00:00:00 +0000
+++ tests/test_backend_error.py	2018-10-03 22:47:51 +0000
@@ -0,0 +1,45 @@
+#!/usr/bin/python3
+# -*- Mode: Python; indent-tabs-mode: nil; tab-width: 4; coding: utf-8 -*-
+
+import logging
+import mock
+import sys
+import unittest
+from gettext import gettext as _
+from mock import patch
+
+from UpdateManager.Dialogs import NoUpdatesDialog
+from UpdateManager.UpdateManager import UpdateManager
+from UpdateManager.UpdatesAvailable import UpdatesAvailable
+
+import os
+CURDIR = os.path.dirname(os.path.abspath(__file__))
+
+
+class TestBackendError(unittest.TestCase):
+
+    def setUp(self):
+        os.environ['UPDATE_MANAGER_FORCE_BACKEND_APTDAEMON'] = '1'
+
+        def clear_environ():
+            del os.environ['UPDATE_MANAGER_FORCE_BACKEND_APTDAEMON']
+
+        self.addCleanup(clear_environ)
+
+    @patch('UpdateManager.backend.InstallBackendAptdaemon.update')
+    def test_backend_error(self, update):
+        main = mock.MagicMock()
+        main.datadir = os.path.join(CURDIR, '..', 'data')
+
+        from UpdateManager.backend import (InstallBackend, get_backend)
+        update_backend = get_backend(main, InstallBackend.ACTION_UPDATE)
+        update.side_effect = lambda: update_backend._action_done(
+            InstallBackend.ACTION_UPDATE, True, False, "string", "desc")
+        update_backend.start()
+        main.start_error.assert_called_once_with(True, "string", "desc")
+
+
+if __name__ == '__main__':
+    if len(sys.argv) > 1 and sys.argv[1] == "-v":
+        logging.basicConfig(level=logging.DEBUG)
+    unittest.main()

=== modified file 'tests/test_update_error.py'
--- tests/test_update_error.py	2017-08-07 19:42:06 +0000
+++ tests/test_update_error.py	2018-10-03 22:47:51 +0000
@@ -44,29 +44,6 @@
                          _("Some software couldn’t be checked for updates."))
 
 
-class TestBackendError(unittest.TestCase):
-
-    def setUp(self):
-        os.environ['UPDATE_MANAGER_FORCE_BACKEND_APTDAEMON'] = '1'
-
-        def clear_environ():
-            del os.environ['UPDATE_MANAGER_FORCE_BACKEND_APTDAEMON']
-
-        self.addCleanup(clear_environ)
-
-    @patch('UpdateManager.backend.InstallBackendAptdaemon.'
-           'InstallBackendAptdaemon.update')
-    def test_backend_error(self, update):
-        main = mock.MagicMock()
-        main.datadir = os.path.join(CURDIR, '..', 'data')
-
-        update_backend = get_backend(main, InstallBackend.ACTION_UPDATE)
-        update.side_effect = lambda: update_backend._action_done(
-            InstallBackend.ACTION_UPDATE, True, False, "string", "desc")
-        update_backend.start()
-        main.start_error.assert_called_once_with(True, "string", "desc")
-
-
 if __name__ == '__main__':
     if len(sys.argv) > 1 and sys.argv[1] == "-v":
         logging.basicConfig(level=logging.DEBUG)