Unity Greeter

Merge lp:~rbalint/unity-greeter/test-with-valgrind into lp:unity-greeter

  1. test-with-valgrind
  2. Merge into trunk
Proposed by Balint Reczey
Status: Merged
Merged at revision: 2192
Proposed branch: lp:~rbalint/unity-greeter/test-with-valgrind
Merge into: lp:unity-greeter
Diff against target: 38 lines (+5/-1)
3 files modified
configure.ac (+3/-0)
debian/control (+1/-0)
tests/Makefile.am (+1/-1)
To merge this branch: bzr merge lp:~rbalint/unity-greeter/test-with-valgrind
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+321056@code.launchpad.net

Description of the change

Use valgrind to make build logs bigger help in triaging FTBFS problems.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Nice idea, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2016-12-16 01:57:19 +0000
3+++ configure.ac 2017-03-27 11:42:03 +0000
4@@ -42,6 +42,9 @@
5 fi
6 AC_DEFINE_UNQUOTED([USD_BINARY], ["$USD_BINARY"], [Path to g-s-d])
7
8+AC_CHECK_PROG(VALGRIND, valgrind, valgrind --trace-children=yes --num-callers=256)
9+AC_SUBST(VALGRIND)
10+
11 dnl ###########################################################################
12 dnl Internationalization
13 dnl ###########################################################################
14
15=== modified file 'debian/control'
16--- debian/control 2016-12-16 01:57:19 +0000
17+++ debian/control 2017-03-27 11:42:03 +0000
18@@ -20,6 +20,7 @@
19 liblightdm-gobject-1-dev (>= 1.4.0),
20 libpixman-1-dev,
21 valac (>= 0.20.0),
22+ valgrind [amd64],
23 xvfb,
24 Homepage: https://launchpad.net/unity-greeter
25 # If you aren't a member of ~unity-greeter-team but need to upload packaging
26
27=== modified file 'tests/Makefile.am'
28--- tests/Makefile.am 2016-11-09 02:08:29 +0000
29+++ tests/Makefile.am 2017-03-27 11:42:03 +0000
30@@ -3,7 +3,7 @@
31 check_PROGRAMS = unity-greeter-test
32
33 check: unity-greeter-test
34- UBUNTU_MENUPROXY=0 top_srcdir=$(top_srcdir) . xvfb-run -a ./unity-greeter-test
35+ UBUNTU_MENUPROXY=0 top_srcdir=$(top_srcdir) @VALGRIND@ xvfb-run -a ./unity-greeter-test
36
37 unity_greeter_test_SOURCES = \
38 test.vala \

Subscribers

People subscribed via source and target branches