Merge lp:~rbalint/ubuntu-motd/check-news-format into lp:ubuntu-motd

[Balint Reczey]

Add check to ensure creating nice motd news.

[Mark Shuttleworth (sabdfl)]

Thanks for digging into this! Can you also make sure it handles cases like this one?

 * Ubuntu's Kubernetes 1.14 distributions can bypass Docker and use containerd
   directly, see https://bit.ly/ubuntu-containerd or try it now with

     snap install microk8s --classic

[Balint Reczey (rbalint)]

Done!

[lp:~rbalint/ubuntu-motd/check-news-format]

64. By Balint Reczey on 2019-04-08

Allow snap/apt command as news last line

=== modified file 'README'
--- README	2018-09-16 17:48:36 +0000
+++ README	2019-04-08 10:13:48 +0000
@@ -4,7 +4,7 @@
  - The file, "index.txt" should contain no more than 10 lines.
  - No line should contain more than 80 characters
  - The first line should start with a white space, an asterisk, and a whitespace, followed by an informative header
- - The last line should be a link to more information
+ - The last line should be a HTTPS link to more information or a snap/apt command to paste
 
 Example index.txt:
 

=== added file 'check-format'
--- check-format	1970-01-01 00:00:00 +0000
+++ check-format	2019-04-08 10:13:48 +0000
@@ -0,0 +1,41 @@
+#!/bin/sh
+
+set -e
+
+dmotd="$1"
+
+ret=0
+
+if [ -z "$dmotd" ]; then
+    echo "Usage:"
+    echo " $0 <dynamic motd news file>"
+    exit 1
+fi
+
+lines=$(wc -l < "$dmotd")
+if [ "$lines" -gt 10 ]; then
+    echo "ERROR: $dmotd contains more than 10 lines ($lines)"
+    ret=1
+fi
+
+line_max_len=$(wc -L < "$dmotd")
+if [ "$line_max_len" -gt 80 ]; then
+    echo "ERROR: $dmotd contains longer than 80 character line ($line_max_len)"
+    ret=1
+fi
+
+first_line="$(head -n 1 "$dmotd")"
+if ! echo "$first_line" | grep -q '^ \* '; then
+    echo "ERROR: $dmotd first line does does not match recommended format, but is:"
+    echo "\"$first_line\""
+    ret=1
+fi
+
+last_line="$(tail -n 1 "$dmotd")"
+if ! echo "$last_line" | egrep -q '( https://| apt | snap )'; then
+    echo "ERROR: $dmotd last line does does not match recommended format, but is:"
+    echo "\"$last_line\""
+    ret=1
+fi
+
+exit $ret