Code review comment for lp:~rbalint/ubuntu-archive-tools/retry-intermittent

Revision history for this message
Iain Lane (laney) wrote :

I've just re-reviewed, sorry for the extended delay.

I have some comments below. Apart from the http->https (will fix that one before pushing) they are mostly nitpicks but it would be good if you could address them.

The --log-regex thing obviously makes the runtime way longer, so I think some progress output would be nice there. Maybe behind a --verbose flag, not sure.

I'm going to merge this though, so it'll have to be a follow up.

Thanks a lot!

review: Approve

« Back to merge proposal