livecd-rootfs

Merge lp:~rbalint/livecd-rootfs/vagrant into lp:livecd-rootfs

  1. vagrant
  2. Merge into trunk
Proposed by Balint Reczey
Status: Merged
Merged at revision: 1527
Proposed branch: lp:~rbalint/livecd-rootfs/vagrant
Merge into: lp:livecd-rootfs
Diff against target: 12 lines (+1/-1)
1 file modified
live-build/ubuntu-cpc/hooks/042-vagrant.binary (+1/-1)
To merge this branch: bzr merge lp:~rbalint/livecd-rootfs/vagrant
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
Steve Langasek Approve
Review via email: mp+331302@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

We set the password in the immediately following line; I guess this is a fix for making the build non-interactive when run with a tty? If so, it looks sane to me.

Revision history for this message
Balint Reczey (rbalint) wrote :

> We set the password in the immediately following line; I guess this is a fix
> for making the build non-interactive when run with a tty? If so, it looks
> sane to me.

Yes, this is the intention.

Revision history for this message
Steve Langasek (vorlon) :
review: Approve
Revision history for this message
Chris Glass (tribaal) wrote :

I meant to +1 this but failed to click properly, I guess.

Apologies.

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'live-build/ubuntu-cpc/hooks/042-vagrant.binary'
2--- live-build/ubuntu-cpc/hooks/042-vagrant.binary 2017-09-01 16:25:41 +0000
3+++ live-build/ubuntu-cpc/hooks/042-vagrant.binary 2017-09-25 22:06:53 +0000
4@@ -72,7 +72,7 @@
5 # Vagrant users expect a "vagrant" user with a "vagrant" username.
6 # See https://www.vagrantup.com/docs/boxes/base.html
7 # Note: We decided NOT to allow root login with a default password.
8-chroot ${mount_d} adduser vagrant
9+chroot ${mount_d} adduser vagrant --disabled-password --gecos ""
10 echo "vagrant:vagrant" | chroot ${mount_d} chpasswd
11
12 # The vagrant user should have passwordless sudo.

Subscribers

People subscribed via source and target branches