Merge lp:~rbalint/livecd-rootfs/livecd-rootfs-autopkgtest-fix-for-zesty into lp:~ubuntu-core-dev/livecd-rootfs/zesty-proposed

[Balint Reczey]

  * Resurrect Balint's fix from
    lp:~rbalint/livecd-rootfs/livecd-rootfs-autopkgtest-fix to wrap kpartx
    and trap spurious errors, since the problem is still being seen
    intermittently on i386 despite us calling sync before kpartx.
  * Mark autopkgtests isolation-machine since debootstrap won't work in a
    container.

[lp:~rbalint/livecd-rootfs/livecd-rootfs-autopkgtest-fix-for-zesty]

1472. By Steve Langasek on 2017-05-11

Resurrect Balint's fix from
lp:~rbalint/livecd-rootfs/livecd-rootfs-autopkgtest-fix to wrap kpartx
and trap spurious errors, since the problem is still being seen
intermittently on i386 despite us calling sync before kpartx. (LP: #1684090)

=== modified file 'debian/changelog'
--- debian/changelog	2017-04-28 21:44:10 +0000
+++ debian/changelog	2017-05-11 13:34:46 +0000
@@ -1,3 +1,14 @@
+livecd-rootfs (2.441.3) UNRELEASED; urgency=medium
+
+  * Resurrect Balint's fix from
+    lp:~rbalint/livecd-rootfs/livecd-rootfs-autopkgtest-fix to wrap kpartx
+    and trap spurious errors, since the problem is still being seen
+    intermittently on i386 despite us calling sync before kpartx. (LP: #1684090)
+  * Mark autopkgtests isolation-machine since debootstrap won't work in a
+    container.
+
+ -- Steve Langasek <[e-mail]>  Fri, 28 Apr 2017 17:41:05 -0700
+
 livecd-rootfs (2.441.2) zesty; urgency=medium
 
   * The ubuntu-server:live should use a casper-based initramfs to work

=== modified file 'debian/tests/control'
--- debian/tests/control	2017-04-10 17:08:27 +0000
+++ debian/tests/control	2017-05-11 13:34:46 +0000
@@ -1,3 +1,3 @@
 Tests: default-bootstraps
 Depends: @, lsb-release
-Restrictions: needs-root
+Restrictions: needs-root isolation-machine

=== modified file 'live-build/functions'
--- live-build/functions	2017-04-12 03:16:48 +0000
+++ live-build/functions	2017-05-11 13:34:46 +0000
@@ -11,9 +11,22 @@
 apt-get -qqy install dosfstools gdisk
 
 clean_loops() {
+    local kpartx_ret
+    local kpartx_stdout
 
     if [ -n "${backing_img}" ]; then
-        kpartx -v -d "${backing_img}"
+        # sync before removing loop to avoid "Device or resource busy" errors
+        sync
+        kpartx_ret=""
+        kpartx_stdout=$(kpartx -v -d "${backing_img}") || kpartx_ret=$?
+        echo "$kpartx_stdout"
+        if [ -n "$kpartx_ret" ]; then
+            if echo "$kpartx_stdout" | grep -q "loop deleted: "; then
+                echo "Suppressing kpartx returning error (#860894)"
+            else
+                exit $kpartx_ret
+            fi
+        fi
         unset backing_img
     fi