Merge lp:~raza-sayed-gmail/gwibber/lp975841 into lp:gwibber

Proposed by raza.sayed
Status: Rejected
Rejected by: Robert Bruce Park
Proposed branch: lp:~raza-sayed-gmail/gwibber/lp975841
Merge into: lp:gwibber
Diff against target: 23 lines (+10/-6)
1 file modified
bin/gwibber-service (+10/-6)
To merge this branch: bzr merge lp:~raza-sayed-gmail/gwibber/lp975841
Reviewer Review Type Date Requested Status
Robert Bruce Park Disapprove
gwibber-committers Pending
Review via email: mp+101939@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

Thanks for taking the time to submit this patch, unfortunately Gwibber has gone through extensive changes recently and your patch no longer applies to the latest codebase.

Fortunately, the bug you were attempting to fix is no longer present in the current codebase.

Please try out the latest Gwibber, I think you'll be quite pleased with what we've accomplished.

review: Disapprove

Unmerged revisions

1335. By raza.sayed

fix for lp:975841

1334. By raza.sayed

fixes lp:975437

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/gwibber-service'
2--- bin/gwibber-service 2012-02-13 20:39:02 +0000
3+++ bin/gwibber-service 2012-04-13 17:19:18 +0000
4@@ -75,9 +75,13 @@
5 """
6
7 logger.debug("Setting up monitors")
8-connection_monitor = dispatcher.ConnectionMonitor()
9-urlshortener = dispatcher.URLShorten()
10-translator = dispatcher.Translate()
11-uploader = dispatcher.Uploader()
12-dispatcher = dispatcher.Dispatcher(loop)
13-loop.run()
14+
15+try:
16+ connection_monitor = dispatcher.ConnectionMonitor()
17+ urlshortener = dispatcher.URLShorten()
18+ translator = dispatcher.Translate()
19+ uploader = dispatcher.Uploader()
20+ dispatcher = dispatcher.Dispatcher(loop)
21+ loop.run()
22+except:
23+ pass

Subscribers

People subscribed via source and target branches