Merge lp:~raymii/duplicity/fix-swiftbackend-max-10000-files-in-list into lp:~duplicity-team/duplicity/0.7-series

Proposed by Remy van Elst
Status: Merged
Merged at revision: 1098
Proposed branch: lp:~raymii/duplicity/fix-swiftbackend-max-10000-files-in-list
Merge into: lp:~duplicity-team/duplicity/0.7-series
Diff against target: 12 lines (+1/-1)
1 file modified
duplicity/backends/swiftbackend.py (+1/-1)
To merge this branch: bzr merge lp:~raymii/duplicity/fix-swiftbackend-max-10000-files-in-list
Reviewer Review Type Date Requested Status
duplicity-team Pending
Review via email: mp+260660@code.launchpad.net

Description of the change

Swiftclient by default returns at max 10000 files. By adding full_listing=True we make sure all objects are returned. Ref: https://lists.nongnu.org/archive/html/duplicity-talk/2015-05/msg00060.html and http://docs.openstack.org/developer/python-swiftclient/swiftclient.html#swiftclient.client.get_container

To post a comment you must log in.
Revision history for this message
edso (ed.so) wrote :

nice catch!.. ede

On 31.05.2015 17:46, Remy van Elst wrote:
> Remy van Elst has proposed merging lp:~raymii/duplicity/fix-swiftbackend-max-10000-files-in-list into lp:duplicity.
>
> Requested reviews:
> duplicity-team (duplicity-team)
>
> For more details, see:
> https://code.launchpad.net/~raymii/duplicity/fix-swiftbackend-max-10000-files-in-list/+merge/260660
>
> Swiftclient by default returns at max 10000 files. By adding full_listing=True we make sure all objects are returned. Ref: https://lists.nongnu.org/archive/html/duplicity-talk/2015-05/msg00060.html and http://docs.openstack.org/developer/python-swiftclient/swiftclient.html#swiftclient.client.get_container
>
>

Revision history for this message
Remy van Elst (raymii) wrote :

Such a small thing... I'm writing a post to the mailing list right now. Thanks for all the help :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'duplicity/backends/swiftbackend.py'
2--- duplicity/backends/swiftbackend.py 2015-01-31 18:09:03 +0000
3+++ duplicity/backends/swiftbackend.py 2015-05-31 15:46:09 +0000
4@@ -110,7 +110,7 @@
5 f.write(chunk)
6
7 def _list(self):
8- headers, objs = self.conn.get_container(self.container)
9+ headers, objs = self.conn.get_container(self.container, full_listing=True)
10 return [o['name'] for o in objs]
11
12 def _delete(self, filename):

Subscribers

People subscribed via source and target branches