Checkbox Provider - Base

Merge ~ray.chen/plainbox-provider-checkbox:revise-nvlink-test into plainbox-provider-checkbox:master

  1. Git
  2. lp:~ray.chen/plainbox-provider-checkbox
  3. revise-nvlink-test
  4. Merge into master
Proposed by Ray Chen
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 2c88297d152fd3463fe79f4ebc0b8053bdd9da95
Merged at revision: d0833c3f514975ee03b8a0174442813ca334d8fb
Proposed branch: ~ray.chen/plainbox-provider-checkbox:revise-nvlink-test
Merge into: plainbox-provider-checkbox:master
Diff against target: 12 lines (+0/-1)
1 file modified
units/graphics/jobs.pxu (+0/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+375540@code.launchpad.net

Commit message

graphics: removed require package in nvlink test

Description of the change

Since the nvidia-smi is virtual package[1], to prevent the test skip due to requirement unmet, I simply remove the require package in test case.

[1]https://packages.ubuntu.com/bionic/nvidia-smi

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/graphics/jobs.pxu b/units/graphics/jobs.pxu
2index 56f4158..13d9afe 100644
3--- a/units/graphics/jobs.pxu
4+++ b/units/graphics/jobs.pxu
5@@ -532,7 +532,6 @@ id: graphics/nvlink-status-check
6 requires:
7 dmi.product in ['Desktop','Low Profile Desktop','Tower','Mini Tower', 'Space-saving']
8 graphics_card.driver == 'nvidia'
9- package.name == 'nvidia-smi'
10 command: nvidia_nvlink_check
11 _summary: Check NVIDIA NVLINK status
12 _description: Check NVLINK are supported and NVLINK are connected properly on system, please make sure below items before testing:

Subscribers

People subscribed via source and target branches