Merge ~ray.chen/plainbox-provider-checkbox:add-ambient-light-sensor into plainbox-provider-checkbox:master

Proposed by Ray Chen
Status: Work in progress
Proposed branch: ~ray.chen/plainbox-provider-checkbox:add-ambient-light-sensor
Merge into: plainbox-provider-checkbox:master
Diff against target: 48 lines (+22/-0)
2 files modified
units/monitor/jobs.pxu (+20/-0)
units/monitor/test-plan.pxu (+2/-0)
Reviewer Review Type Date Requested Status
Jonathan Cave Pending
Sylvain Pineau Pending
Review via email: mp+375199@code.launchpad.net

Commit message

monitor: add ambient light sensor test

Description of the change

Since automatic brightness are support in the 20.04, QA need the test to verify this function are work.
[1]https://help.ubuntu.com/stable/ubuntu-help/power-autobrightness.html.en

To post a comment you must log in.
Revision history for this message
Rex Tsai (chihchun) wrote :

Hi, ambient-light-sensor should be fully automated, Please do not merge yet another manual tests.

Please see the suggestion of the implementation[1]

[1] [WIP] Test case for Ambient Light Sensor - Google Docs - https://docs.google.com/document/d/1oIIhZbnxBEWzu51LUVejqvNaYWZAAQCv11XsONqDJHs/edit

Revision history for this message
Ray Chen (ray.chen) wrote :

I agree with Rex comment, +1 for pending MR

Revision history for this message
Jonathan Cave (jocave) wrote :

Setting to WIP due to above request

Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[BOT]
$ cat plainbox-provider-checkbox-0.59.0-1-792ce08-in-linux-container-focal-summary.log
bootstrap-client-cert-desktop-20-04-automated FAIL stderr: unable to find nested part: com.canonical.certification::submission-cert-automated
https://oem-share.canonical.com/share/lyoncore/artifacts/plainbox-provider-checkbox-0.59.0-1-792ce08-in-linux-container-focal

Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

Execute `curl -X POST http://10.102.135.31/api/v1/teams/self-contained/pipelines/plainbox-provider-checkbox/resources/merge-proposal-375199/check/webhook?webhook_token=merge-proposal-375199` within TW VPN to restart the test.
[autopkgtest]
$ cat plainbox-provider-checkbox-0.59.0-1-792ce08-in-linux-container-focal-summary.log
bootstrap-client-cert-desktop-20-04-automated FAIL stderr: unable to find nested part: com.canonical.certification::submission-cert-automated
https://oem-share.canonical.com/partners/lyoncore/share/artifacts/plainbox-provider-checkbox-0.59.0-1-792ce08-in-linux-container-focal

Unmerged commits

792ce08... by Ray Chen

monitor: add ambient light sensor test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/monitor/jobs.pxu b/units/monitor/jobs.pxu
2index df1bb95..3851045 100644
3--- a/units/monitor/jobs.pxu
4+++ b/units/monitor/jobs.pxu
5@@ -417,3 +417,23 @@ command:
6 timeout 60 ssh $SSH_OPTS ubuntu@$MUXPI_IP "stm -hdmi off" || exit 1
7 sleep 3
8 if [ "$(cat /sys/class/drm/$HDMI_PORT/status)" != "disconnected" ] ;then exit 1; fi
9+
10+
11+id: monitor/ambient-light-sensor
12+category_id: com.canonical.plainbox::monitor
13+flags: also-after-suspend-manual
14+plugin: manual
15+estimated_duration: 120.0
16+requires: dmi.product in ['Notebook','Laptop','Portable']
17+_description:
18+ PURPOSE:
19+ This test will check your ambient light sensor.
20+ STEPS:
21+ 1. Enter Settings, click Power to open the panel.
22+ 2. In the Power Saving section, ensure that the Automatic brightness switch is set to on.
23+ 3. Adjust the Screen Brightness to maximum.
24+ 4. Locate the light sensor, cover the sensor by hand.
25+ 5. Remove your hand.
26+ VERIFICATION:
27+ 1. Does screen brightness decrease during step 4?
28+ 2. Does screen brightness increase during step 5?
29diff --git a/units/monitor/test-plan.pxu b/units/monitor/test-plan.pxu
30index 5eb1f66..c837b37 100644
31--- a/units/monitor/test-plan.pxu
32+++ b/units/monitor/test-plan.pxu
33@@ -26,6 +26,7 @@ _description:
34 include:
35 monitor/1_powersaving_.* certification-status=blocker
36 monitor/1_dim_brightness_.* certification-status=blocker
37+ monitor/ambient-light-sensor
38 monitor/1_displayport_.* certification-status=blocker
39 audio/1_playback_displayport_.* certification-status=blocker
40 monitor/1_type-c_displayport_.* certification-status=blocker
41@@ -55,6 +56,7 @@ _description:
42 include:
43 after-suspend-manual-monitor/1_powersaving_.* certification-status=blocker
44 after-suspend-manual-monitor/1_dim_brightness_.* certification-status=blocker
45+ after-suspend-manual-monitor/ambient-light-sensor
46 after-suspend-manual-monitor/1_displayport_.* certification-status=blocker
47 after-suspend-manual-audio/1_playback_displayport_.* certification-status=blocker
48 after-suspend-manual-monitor/1_type-c_displayport_.* certification-status=blocker

Subscribers

People subscribed via source and target branches