Merge lp:~raoul-snyman/openlp/new-run-script into lp:openlp/packaging

Proposed by Raoul Snyman
Status: Merged
Merged at revision: 39
Proposed branch: lp:~raoul-snyman/openlp/new-run-script
Merge into: lp:openlp/packaging
Diff against target: 36 lines (+3/-5)
1 file modified
builders/builder.py (+3/-5)
To merge this branch: bzr merge lp:~raoul-snyman/openlp/new-run-script
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Bastian Germann (community) Approve
Review via email: mp+357906@code.launchpad.net

Commit message

Fix builder script to use new OpenLP run script name.

Description of the change

Fix builder script to use new OpenLP run script name.

To post a comment you must log in.
Revision history for this message
Bastian Germann (bastian-germann-deactivatedaccount) wrote :

Great! I closed my branch in favour of this one.

review: Approve
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'builders/builder.py'
2--- builders/builder.py 2018-07-12 19:41:00 +0000
3+++ builders/builder.py 2018-10-27 06:11:26 +0000
4@@ -218,7 +218,7 @@
5 else:
6 self.version = None
7 self.work_path = self.branch_path
8- self.openlp_script = os.path.abspath(os.path.join(self.work_path, 'openlp-run.py'))
9+ self.openlp_script = os.path.abspath(os.path.join(self.work_path, 'run_openlp.py'))
10 self.source_path = os.path.join(self.work_path, 'openlp')
11 self.manual_path = os.path.join(self.documentation_path, 'manual')
12 self.manual_build_path = os.path.join(self.manual_path, 'build')
13@@ -269,7 +269,6 @@
14 Run PyInstaller on the branch to build an executable.
15 """
16 self._print('Running PyInstaller...')
17- copy(os.path.join(self.work_path, 'openlp.py'), self.openlp_script)
18 os.chdir(self.work_path)
19 cmd = [self.python,
20 self.pyinstaller_exe,
21@@ -428,7 +427,8 @@
22 rmtree(self.manual_build_path)
23 os.chdir(self.manual_path)
24 sphinx_build = self.get_sphinx_build()
25- command = [self.sphinx_exe, '-b', sphinx_build, '-d', 'build/doctrees', 'source', 'build/{}'.format(sphinx_build)]
26+ command = [self.sphinx_exe, '-b', sphinx_build, '-d', 'build/doctrees', 'source',
27+ 'build/{}'.format(sphinx_build)]
28 self._run_command(command, 'Error running Sphinx')
29 self.after_run_sphinx()
30
31@@ -477,5 +477,3 @@
32
33 self._print('Done.')
34 raise SystemExit()
35-
36-

Subscribers

People subscribed via source and target branches