OpenLP

Merge lp:~raoul-snyman/openlp/bug-1259606-2.0 into lp:openlp/2.0

  1. bug-1259606-2.0
  2. Merge into release-2.0
Proposed by Raoul Snyman
Status: Merged
Approved by: Andreas Preikschat
Approved revision: 2180
Merged at revision: 2181
Proposed branch: lp:~raoul-snyman/openlp/bug-1259606-2.0
Merge into: lp:openlp/2.0
Diff against target: 20 lines (+2/-1)
1 file modified
openlp/core/ui/slidecontroller.py (+2/-1)
To merge this branch: bzr merge lp:~raoul-snyman/openlp/bug-1259606-2.0
Reviewer Review Type Date Requested Status
Andreas Preikschat (community) Approve
Tim Bentley Approve
Review via email: mp+199873@code.launchpad.net

Description of the change

When a user clicks on the row headers (yes, in 4 years no one has done that), the row is selected but the slide doesn't change. This fixes that.

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

Looks fine but not sure which screen bit to click on.

review: Approve
Revision history for this message
Andreas Preikschat (googol-deactivatedaccount) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/core/ui/slidecontroller.py'
2--- openlp/core/ui/slidecontroller.py 2013-02-10 12:21:59 +0000
3+++ openlp/core/ui/slidecontroller.py 2013-12-20 22:15:56 +0000
4@@ -44,6 +44,7 @@
5
6 log = logging.getLogger(__name__)
7
8+
9 class SlideList(QtGui.QTableWidget):
10 """
11 Customised version of QTableWidget which can respond to keyboard
12@@ -390,7 +391,7 @@
13 self._slideShortcutActivated)
14 # Signals
15 QtCore.QObject.connect(self.previewListWidget,
16- QtCore.SIGNAL(u'clicked(QModelIndex)'), self.onSlideSelected)
17+ QtCore.SIGNAL(u'itemSelectionChanged()'), self.onSlideSelected)
18 if self.isLive:
19 QtCore.QObject.connect(Receiver.get_receiver(),
20 QtCore.SIGNAL(u'slidecontroller_live_spin_delay'),

Subscribers

People subscribed via source and target branches