Merge lp:~raoul-snyman/openlp/bug-1212801-2.0 into lp:openlp/2.0

Proposed by Raoul Snyman
Status: Merged
Approved by: Andreas Preikschat
Approved revision: 2153
Merged at revision: 2157
Proposed branch: lp:~raoul-snyman/openlp/bug-1212801-2.0
Merge into: lp:openlp/2.0
Diff against target: 29 lines (+5/-0)
1 file modified
openlp/plugins/songs/forms/editsongform.py (+5/-0)
To merge this branch: bzr merge lp:~raoul-snyman/openlp/bug-1212801-2.0
Reviewer Review Type Date Requested Status
Andreas Preikschat (community) Approve
Tim Bentley Approve
Review via email: mp+180409@code.launchpad.net

Commit message

Fix bug #1212801 where the song edit form did not clear a previously set theme.

Description of the change

Fix bug #1212801 where the song edit form did not clear a previously set theme.

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

Visual only

review: Approve
Revision history for this message
Andreas Preikschat (googol-deactivatedaccount) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/plugins/songs/forms/editsongform.py'
2--- openlp/plugins/songs/forms/editsongform.py 2013-06-16 17:19:32 +0000
3+++ openlp/plugins/songs/forms/editsongform.py 2013-08-15 19:59:33 +0000
4@@ -47,6 +47,7 @@
5
6 log = logging.getLogger(__name__)
7
8+
9 class EditSongForm(QtGui.QDialog, Ui_EditSongDialog):
10 """
11 Class to manage the editing of a song
12@@ -229,6 +230,7 @@
13 self.loadTopics()
14 self.loadBooks()
15 self.loadMediaFiles()
16+ self.themeComboBox.setEditText(u'')
17 self.themeComboBox.setCurrentIndex(0)
18 # it's a new song to preview is not possible
19 self.previewButton.setVisible(False)
20@@ -261,6 +263,9 @@
21 if self.song.theme_name:
22 find_and_set_in_combo_box(
23 self.themeComboBox, unicode(self.song.theme_name))
24+ else:
25+ self.themeComboBox.setEditText(u'')
26+ self.themeComboBox.setCurrentIndex(0)
27 self.copyrightEdit.setText(
28 self.song.copyright if self.song.copyright else u'')
29 self.commentsEdit.setPlainText(

Subscribers

People subscribed via source and target branches