lp:~raof/unity-greeter/fix-login-corruption

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity-greeter at revision 362

Robert Ancell: Approve on 2012-03-20

Diff: 100 lines (+26/-24)

1 file modified

src/unity-greeter.vala (+26/-24)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #931967: Corrupted graphics after the login until the unity launcher appears

Undecided

Fix Released

Link a bug report

Related blueprints

366. By Chris Halse Rogers on 2012-03-20

Also set root window's backing pixmap in test mode.

This makes it possible to test in an xnest server

365. By Chris Halse Rogers on 2012-03-20

Use draw_full () rather than draw () to draw the background pixmap.

draw () goes through gtk_widget_draw, which fails because we've changed the underlying
surface it's trying to draw to, and wouldn't be what we want anyway as it'd
draw all the children of the background, too, like the user list.

364. By Chris Halse Rogers on 2012-03-20

Remove inaccurate comment and superfluous Gdk.flush

363. By Chris Halse Rogers on 2012-03-20

Move SetWindowBackgroundPixmap call to refresh_background.

XSetWindowBackgroundPixmap takes a copy of the drawable set; further rendering
to that pixmap invokes undefined behaviour in the server.

Also, flush the Cairo surface before using the underlying pixmap; Cairo requires
that a flush preceed any native access to the underlying resource.

362. By Chris Halse Rogers on 2012-03-20

Don't set up a new X connection for the root pixmap.

This is unnecessary, as SetWindowBackgroundPixmap will take a copy.
Also, the existing code was racy - there's no guarantee that the XCreatePixmap
on display would complete (or even be dispatched) before trying to create
a CairoXlibSurface on xdisplay. Pixmap XID allocation is handled client-side;
there's no round-trip required for XCreatePixmap to return.

361. By Launchpad Translations on behalf of unity-greeter-team on 2012-03-18

Launchpad automatic translations update.

360. By Launchpad Translations on behalf of unity-greeter-team on 2012-03-17

Launchpad automatic translations update.

359. By Launchpad Translations on behalf of unity-greeter-team on 2012-03-16

Launchpad automatic translations update.

358. By Michael Terry on 2012-03-15

bump version to 0.2.5

357. By Michael Terry on 2012-03-15

update NEWS