Merge lp:~raof/netbook-remix-launcher/fix-bug-513083 into lp:netbook-remix-launcher

Proposed by Chris Halse Rogers
Status: Merged
Merged at revision: not available
Proposed branch: lp:~raof/netbook-remix-launcher/fix-bug-513083
Merge into: lp:netbook-remix-launcher
Diff against target: 18 lines (+8/-0)
1 file modified
src/nl-menu-items.c (+8/-0)
To merge this branch: bzr merge lp:~raof/netbook-remix-launcher/fix-bug-513083
Reviewer Review Type Date Requested Status
UNR Developers Pending
Review via email: mp+21196@code.launchpad.net

Description of the change

Add a null guard in the on_child_focus_changed signal handler. This fixes the crash when using keyboard navigation to enter the System category.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/nl-menu-items.c'
2--- src/nl-menu-items.c 2009-09-24 17:14:55 +0000
3+++ src/nl-menu-items.c 2010-03-11 23:24:18 +0000
4@@ -573,6 +573,14 @@
5 gfloat y1 = 0, y2 = 0;
6 ClutterActorBox focus_box = { 0 };
7
8+ /* For some reason somewhere between signal emission and this handler being
9+ * called, box can get NULLed (eg: LP #514083).
10+ *
11+ * I think this problem should be hunted down at some point. Until then
12+ * work around it by checking for NULL.
13+ */
14+ g_return_if_fail (box != NULL);
15+
16 parent = clutter_actor_get_parent (icon_view);
17
18 children = clutter_container_get_children (main_box);

Subscribers

People subscribed via source and target branches