Code review comment for lp:~raof/mir/waylanding-again

> I just merged to trunk and "built" and got...
>
> ../libmirsharedmesaservercommon-static.a(buffer_allocator.cpp.o): In function
> `WaylandBuffer':
> /home/alan/display_server/mir/src/platforms/mesa/server/buffer_allocator.cpp:3
> 46: undefined reference to `wl_resource_get_destroy_listener'
> /home/alan/display_server/mir/src/platforms/mesa/server/buffer_allocator.cpp:3
> 65: undefined reference to `wl_resource_add_destroy_listener'
> ../libmirsharedmesaservercommon-static.a(buffer_allocator.cpp.o): In function
> `~WaylandBuffer':
> /home/alan/display_server/mir/src/platforms/mesa/server/buffer_allocator.cpp:4
> 05: undefined reference to `wl_resource_queue_event'
> /home/alan/display_server/mir/src/platforms/mesa/server/buffer_allocator.cpp:4
> 06: undefined reference to `wl_resource_get_destroy_listener'
> clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
> src/platforms/mesa/server/x11/CMakeFiles/mirplatformservermesax11.dir/build.ma
> ke:105: recipe for target 'lib/server-modules/server-mesa-x11.so.13' failed
> make[2]: *** [lib/server-modules/server-mesa-x11.so.13] Error 1
> CMakeFiles/Makefile2:1823: recipe for target
> 'src/platforms/mesa/server/x11/CMakeFiles/mirplatformservermesax11.dir/all'
> failed
>
> Once again "make refresh-wayland-wrapper" fixes that, but something isn't
> quite right.

Loads of tests fail, and (possibly related):

$ cmake-build-debug/bin/miral-shell
...
wl_global_create: implemented version for 'wl_seat' higher than interface version (6 > 5)
ERROR: /home/alan/display_server/mir/src/server/frontend/wayland/wayland_connector.cpp(1026): Throw in function mir::frontend::WlSeat::WlSeat(wl_display *, const std::shared_ptr<mir::Executor> &)
Dynamic exception type: boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<std::runtime_error> >
std::exception::what: Failed to export wl_seat interface

Segmentation fault (core dumped)