Code review comment for lp:~raof/mir/waylanding-again

[terminal 1]
$ bin/miral-shell

[terminal 2]
$ bin/mir_demo_client_wayland
...
^C

The server crashes (this doesn't happen with using Shift-Alt-F4 to send SIGTERM).

~~~~

+ * Copyright © 2015 Canonical LTD

Really 2015? We use "Ltd." elsewhere.

~~~~

+ GNU General Public License version 3

2 or 3

~~~~

+#include "../../../../include/server/mir/executor.h"

1. Not the approved way to reach a header.
2. Platforms shouldn't be depending on mirserver (yes I realize it's an interface)

~~~~

+#include "../../scene/mediating_display_changer.h"

1. Not the approved way to reach a header.
2. The frontend shouldn't be dependent on scene internals. (It should define an abstraction that scene can implement.)

~~~~

I just merged to trunk and "built" and got...

/home/alan/display_server/mir1/src/server/frontend/wayland/wayland_connector.cpp:21:10: fatal error: 'core_generated_interfaces.h' file not found
#include "core_generated_interfaces.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

"make refresh-wayland-wrapper" fixes that, but something isn't quite right.