Mir

Merge lp:~raof/mir/valgrind-track-origins into lp:mir

Proposed by Chris Halse Rogers on 2017-08-08
Status: Merged
Approved by: Alan Griffiths on 2017-08-08
Approved revision: 4220
Merged at revision: 4220
Proposed branch: lp:~raof/mir/valgrind-track-origins
Merge into: lp:mir
Diff against target: 11 lines (+1/-0)
1 file modified
cmake/MirCommon.cmake (+1/-0)
To merge this branch: bzr merge lp:~raof/mir/valgrind-track-origins
Reviewer Review Type Date Requested Status
Alan Griffiths 2017-08-08 Approve on 2017-08-08
Mir CI Bot continuous-integration Approve on 2017-08-08
Review via email: mp+328706@code.launchpad.net

Commit message

buildsystem: Run valgrind with --track-origins=yes

Description of the change

This will slow down the tests - the manpage suggests that it's a >100MB memory penalty (which we don't care about) and will run ½ as fast (which we do).

I think there have been enough times when this has been useful that it's worth enabling all the time, though.

To post a comment you must log in.
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:4220
https://mir-jenkins.ubuntu.com/job/mir-ci/3542/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/4846
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/5047
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/5036
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/5036
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/5036
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4883
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4883/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4883
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4883/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4883
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4883/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4883
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4883/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4883
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4883/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/4883
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/4883/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4883
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4883/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4883
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4883/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3542/rebuild

review: Approve (continuous-integration)
Alan Griffiths (alan-griffiths) wrote :

If it causes problems with time-sensitive tests in practice we can review.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/MirCommon.cmake'
2--- cmake/MirCommon.cmake 2017-05-08 03:04:26 +0000
3+++ cmake/MirCommon.cmake 2017-08-08 04:38:25 +0000
4@@ -26,6 +26,7 @@
5 set(VALGRIND_CMD "${VALGRIND_EXECUTABLE}" "--error-exitcode=1" "--trace-children=yes")
6 set(VALGRIND_CMD ${VALGRIND_CMD} "--leak-check=full" "--show-leak-kinds=definite" "--errors-for-leak-kinds=definite")
7 set(VALGRIND_CMD ${VALGRIND_CMD} "--track-fds=yes")
8+ set(VALGRIND_CMD ${VALGRIND_CMD} "--track-origins=yes")
9 set(VALGRIND_CMD ${VALGRIND_CMD} "--num-callers=128")
10 set(VALGRIND_CMD ${VALGRIND_CMD} "--suppressions=${CMAKE_SOURCE_DIR}/tools/valgrind_suppressions_generic")
11 set(VALGRIND_CMD ${VALGRIND_CMD} "--suppressions=${CMAKE_SOURCE_DIR}/tools/valgrind_suppressions_glibc_2.23")

Subscribers

People subscribed via source and target branches