lp:~raof/mir/process-wrapper

Branch merges

Propose for merging

1 branch dependent on this one.

Rejected for merging into lp:mir

Daniel van Vugt: Disapprove on 2014-01-30

Alan Griffiths: Needs Information on 2014-01-29

Alexandros Frantzis (community): Needs Fixing on 2014-01-28

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2014-01-28

Diff: 994 lines (+679/-37)

19 files modified

.bzrignore (+1/-0)
include/server/mir/process/handle.h (+45/-0)
include/server/mir/process/spawner.h (+83/-0)
include/shared/mir/pipe.h (+10/-6)
src/server/CMakeLists.txt (+3/-0)
src/server/process/CMakeLists.txt (+25/-0)
src/server/process/fork_spawner.cpp (+165/-0)
src/server/process/fork_spawner.h (+44/-0)
src/shared/CMakeLists.txt (+1/-0)
src/shared/pipe/CMakeLists.txt (+19/-0)
src/shared/pipe/pipe.cpp (+40/-20)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_display_configuration.cpp (+3/-2)
tests/acceptance-tests/test_subprocess.cpp (+166/-0)
tests/integration-tests/test_display_server_main_loop_events.cpp (+3/-3)
tests/mir_test/CMakeLists.txt (+0/-1)
tests/unit-tests/CMakeLists.txt (+1/-0)
tests/unit-tests/test_asio_main_loop.cpp (+5/-5)
tests/unit-tests/test_fork_spawner.cpp (+64/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1354. By Chris Halse Rogers on 2014-01-28

Minimal doc for ForkSpawner

1353. By Chris Halse Rogers on 2014-01-28

Make process::Spawner methods return unique_ptrs

This has more obvious ownership semantics, and process::Handles are going to
grow methods which mutate process state (most obviously, shutdown())

1352. By Chris Halse Rogers on 2014-01-28

clang-format the sucker

1351. By Chris Halse Rogers on 2014-01-28

Be less strict in TestForkSpawner.

We don't sufficiently control the testing environment, so for example,
ctest can leave fds open that confuses the strict test.

1350. By Chris Halse Rogers on 2014-01-28

Add missing ForkSpawner unit-test

1349. By Chris Halse Rogers on 2014-01-24

Let's document process::Spawner

1348. By Chris Halse Rogers on 2014-01-24

Add run_from_path override that keeps an extra set of fds open

1347. By Chris Halse Rogers on 2014-01-24

Close all non-stdio fds on spawn

1346. By Chris Halse Rogers on 2014-01-23

Add missing CMakeLists.txt from the mt::Pipe move

1345. By Chris Halse Rogers on 2014-01-23

Catch errors from exec() and propagate them up to the Spawner.

Also fix the TODO about the random 10msec wait for the process to exec. Yay!