Mir

Code review comment for lp:~raof/mir/prober-drm-device-probe

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I think this is a step forward, but now I get all my tests skipped if I'm missing umockdev. I think that's extreme. We should only skip those tests (GBM?) that are not possible without umockdev.

I would like to see most of the tests still runnable without umockdev, as they are today in lp:mir.

I don't yet approve, but also understand that my vote is not a veto.

review: Needs Fixing

« Back to merge proposal