Mir

Merge lp:~raof/mir/missing-pkgconfig-requires into lp:mir

  1. missing-pkgconfig-requires
  2. Merge into development-branch
Proposed by Chris Halse Rogers
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3815
Proposed branch: lp:~raof/mir/missing-pkgconfig-requires
Merge into: lp:mir
Diff against target: 11 lines (+1/-1)
1 file modified
src/client/mirclient.pc.in (+1/-1)
To merge this branch: bzr merge lp:~raof/mir/missing-pkgconfig-requires
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve
Brandon Schaefer (community) Approve
Review via email: mp+310497@code.launchpad.net

Commit message

Add xkbcommon to mirclient.pc Requires.private.

Mir client headers #include some files from xkbcommon, so the pkg-config file should have a dependency upon it.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

lgtm

review: Approve
Revision history for this message
Mir CI Bot (mir-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/client/mirclient.pc.in'
2--- src/client/mirclient.pc.in 2016-10-12 14:23:49 +0000
3+++ src/client/mirclient.pc.in 2016-11-09 23:53:12 +0000
4@@ -7,6 +7,6 @@
5 Description: Mir client library
6 Version: @MIR_VERSION@
7 Requires: mircore
8-Requires.private: protobuf-lite >= 2.4.1, mircookie
9+Requires.private: protobuf-lite >= 2.4.1, mircookie, xkbcommon
10 Libs: -L${libdir} -lmirclient
11 Cflags: -I${includedir}

Subscribers

People subscribed via source and target branches