Mir

Merge lp:~raof/mir/mircookie-dependency into lp:mir

  1. mircookie-dependency
  2. Merge into development-branch
Proposed by Chris Halse Rogers on 2015-10-21
Status: Merged
Approved by: Daniel van Vugt on 2015-10-22
Approved revision: 3042
Merged at revision: 3044
Proposed branch: lp:~raof/mir/mircookie-dependency
Merge into: lp:mir
Diff against target: 11 lines (+1/-0)
1 file modified
debian/control (+1/-0)
To merge this branch: bzr merge lp:~raof/mir/mircookie-dependency
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-10-22
Daniel van Vugt Approve on 2015-10-22
Alan Griffiths Approve on 2015-10-21
Brandon Schaefer (community) 2015-10-21 Approve on 2015-10-21
Review via email: mp+275125@code.launchpad.net

Commit Message

Add dependency on libmircookie-dev to libmirclient-dev

We expose types from mircookie in mirclient, and we've (correctly) got a Requires.private in the pkgconfig file, so we also need a Depends:.

Description of the Change

Add dependency on libmircookie-dev to libmirclient-dev

We expose types from mircookie in mirclient, and we've (correctly) got a Requires.private in the pkgconfig file, so we also need a Depends:.

To post a comment you must log in.
Brandon Schaefer (brandontschaefer) wrote :

Opps missed that :(

review: Approve
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/2008/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4559
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3466
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4501/console
    None: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/459/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/563
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/563/artifact/work/output/*zip*/output.zip
    None: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/459/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4502/console
    None: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/460/console

review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/2011/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4564
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3471
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4506/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/464/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/566
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/566/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/464
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/464/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4507
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4507/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7139/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24416
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/465/console

review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3042
http://jenkins.qa.ubuntu.com/job/mir-ci/5355/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4569
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3476
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4511/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/469/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1509
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1509/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/469
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/469/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4512
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4512/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7143/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24422
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/470/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5355/rebuild

review: Needs Fixing (continuous-integration)
Alan Griffiths (alan-griffiths) wrote :

True

review: Approve
Alan Griffiths (alan-griffiths) wrote :

Unrelated failure:

/bin/bash: line 1: 7474 Segmentation fault (core dumped) mir_demo_server --test-client /usr/bin/mir_demo_client_fingerpaint

PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/2015/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4576
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3483
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4518/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/476/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/570
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/570/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/476
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/476/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4519
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4519/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7150/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24437
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/477/console

review: Needs Fixing (continuous-integration)
Daniel van Vugt (vanvugt) wrote :

Hmm, we seem to have too many binary packages in Mir now. That needs some revision in future...

review: Approve
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-10-05 02:18:18 +0000
3+++ debian/control 2015-10-21 04:11:58 +0000
4@@ -180,6 +180,7 @@
5 Pre-Depends: ${misc:Pre-Depends}
6 Depends: libmirclient9 (= ${binary:Version}),
7 libmircommon-dev (= ${binary:Version}),
8+ libmircookie-dev (= ${binary:Version}),
9 libprotobuf-dev (>= 2.4.1),
10 ${misc:Depends},
11 Description: Display server for Ubuntu - development headers

Subscribers

People subscribed via source and target branches