lp:~raof/mir/mir-module-throw-exception

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:mir

Mir CI Bot: Needs Fixing (continuous-integration) on 2016-04-21

Mir development team: Pending requested 2016-04-21

Diff: 364 lines (+267/-11)

7 files modified

include/test/mir/test/doubles/null_platform.h (+0/-5)
src/common/sharedlibrary/CMakeLists.txt (+4/-1)
src/common/sharedlibrary/module_throw_exception.cpp (+94/-0)
src/common/symbols.map (+1/-0)
src/include/common/mir/module_throw_exception.h (+69/-0)
tests/acceptance-tests/test_server_shutdown.cpp (+15/-1)
tests/mir_test_framework/platform_graphics_throw.cpp (+84/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1553549: Mir crashes with useless backtrace when mg::Platform methods throw

High

Fix Released

Link a bug report

Related blueprints

3470. By Chris Halse Rogers on 2016-04-21

Babysit g++5 by explicitly using std::hash<uint32_t>.

I don't really know why g++5 can't handle std::unordered_map<MyEnumClass, bool> while g++6 can,
but that's apparently the case.

Make life easier on poor little g++5

3469. By Chris Halse Rogers on 2016-04-21

Use MIR_MODULE_THROW_EXCEPTION in graphics-throw.so

3468. By Chris Halse Rogers on 2016-04-21

Add MIR_MODULE_THROW_EXCEPTION.

This is like BOOST_THROW_EXCEPTION, but it additionally ensures that the dynamic library
that contains the throwing code is not unloaded before exception processing finishes.

This prevents annoying-to-debug SIGSEGVs when throwing an exception from a platform module
and stack unwinding causes the mir::UniqueModulePtr to be destroyed (and the DSO unloaded)
before the catch {} attempts to access code (such as destructors) or data (such as
static strings) from the now-unloaded DSO with hilarious consequences!

3467. By Chris Halse Rogers on 2016-04-20

Test exception-safety of all mg::Platform methods.

Spoiler: only the constructor is exception-safe. All other methods SIGSEGV trying to run
code or load data found in the DSO that's just been unloaded...

3466. By Chris Halse Rogers on 2016-04-20

Remove vestigial mtd::NullPlatform::connection_ipc_package()

3465. By Alan Griffiths on 2016-04-18

logging: Add a bit more information (surface type) to logging::ShellReport.

Approved by Cemil Azizoglu, Kevin DuBois, mir-ci-bot.

3464. By Daniel van Vugt on 2016-04-18

Fix unresponsive cursor to slow mouse movement (LP: #1528109)

Since we started using libinput and its acceleration curve, that actually
reduces the amount of motion we receive for slow mouse movements. A device
increment of 1 actually results in us receiving a dx or dy from libinput
of less than 1.0. So this fix ensures that such small movements no longer
get truncated to zero. Fixes: https://bugs.launchpad.net/bugs/1528109.

Approved by Andreas Pokorny, Alan Griffiths, mir-ci-bot.

3463. By Daniel van Vugt on 2016-04-15

Fix spurious test failure of
   TestClientInput.receives_one_touch_event_per_frame
on slow/loaded machines (LP: #1570698). Fixes: https://bugs.launchpad.net/bugs/1570698.

Approved by Cemil Azizoglu, Alan Griffiths, mir-ci-bot.

3462. By Kevin DuBois on 2016-04-15

fix: LP #1556045 which was blocking CI. problem was in the test fixture. Fixes: https://bugs.launchpad.net/bugs/1556045.

Approved by Alan Griffiths, Chris Halse Rogers, mir-ci-bot.

3461. By Andreas Pokorny on 2016-04-15

Test the optional before accessing the device configuration

This is a workaround necessary until the client api to read input device configurations is in place.
. Fixes: https://bugs.launchpad.net/bugs/1570362.

Approved by Alan Griffiths, Cemil Azizoglu, mir-ci-bot.