Mir

Code review comment for lp:~raof/mir/input-methods-can-specify-foreign-parents

Revision history for this message
Chris Halse Rogers (raof) wrote :

> >> + // XXX: This is ugly, but there doesn't seem to be a better way
>
> Why not just let the exception propagate to the frontend to produce the error
> like we normally do? To control the error message?

It's my understanding that if the frontend catches the error then the client is killed. That doesn't want to happen here - an ID no longer referring to an active surface is not a programming error, it's an unavoidable race condition. The IM will need to catch it and respond by not popping up a surface, but it shouldn't be fatal.

« Back to merge proposal