Mir

Merge lp:~raof/mir/fix-two-clang-analyse-results into lp:~mir-team/mir/trunk

Proposed by Chris Halse Rogers on 2013-07-08
Status: Merged
Approved by: Alan Griffiths on 2013-07-08
Approved revision: 822
Merged at revision: 822
Proposed branch: lp:~raof/mir/fix-two-clang-analyse-results
Merge into: lp:~mir-team/mir/trunk
Diff against target: 31 lines (+9/-1)
2 files modified
examples/demo-inprocess-surface-client/inprocess_egl_client.cpp (+1/-1)
src/server/graphics/gbm/linux_virtual_terminal.cpp (+8/-0)
To merge this branch: bzr merge lp:~raof/mir/fix-two-clang-analyse-results
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2013-07-08
Alan Griffiths Approve on 2013-07-08
Thomas Voß (community) 2013-07-08 Approve on 2013-07-08
Review via email: mp+173462@code.launchpad.net

Commit message

Fix two issues caught by Clang's static analyser

Description of the change

Fix two issues caught by Clang's static analyser

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/demo-inprocess-surface-client/inprocess_egl_client.cpp'
2--- examples/demo-inprocess-surface-client/inprocess_egl_client.cpp 2013-06-13 22:05:06 +0000
3+++ examples/demo-inprocess-surface-client/inprocess_egl_client.cpp 2013-07-08 10:36:24 +0000
4@@ -106,7 +106,7 @@
5 {
6 gl_animation.render_gl();
7 rc = eglSwapBuffers(helper.the_display(), helper.the_surface());
8- assert(rc = EGL_TRUE);
9+ assert(rc == EGL_TRUE);
10
11 gl_animation.step();
12 }
13
14=== modified file 'src/server/graphics/gbm/linux_virtual_terminal.cpp'
15--- src/server/graphics/gbm/linux_virtual_terminal.cpp 2013-06-25 03:25:49 +0000
16+++ src/server/graphics/gbm/linux_virtual_terminal.cpp 2013-07-08 10:36:24 +0000
17@@ -209,6 +209,14 @@
18 << boost::errinfo_errno(errno));
19 }
20 status = fops->ioctl(vt_fd, VT_WAITACTIVE, vt_number);
21+ if (status < 0)
22+ {
23+ BOOST_THROW_EXCEPTION(
24+ boost::enable_error_info(
25+ std::runtime_error("Failed to wait for VT to become active"))
26+ << boost::errinfo_file_name(active_vt_path)
27+ << boost::errinfo_errno(errno));
28+ }
29 }
30
31 return vt_fd;

Subscribers

People subscribed via source and target branches