Merge lp:~raof/mir/fix-clang-detection into lp:mir
| Status: | Merged |
|---|---|
| Merged at revision: | 3672 |
| Proposed branch: | lp:~raof/mir/fix-clang-detection |
| Merge into: | lp:mir |
| Diff against target: |
27 lines (+7/-4) 1 file modified
CMakeLists.txt (+7/-4) |
| To merge this branch: | bzr merge lp:~raof/mir/fix-clang-detection |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mir CI Bot | continuous-integration | Needs Fixing on 2016-08-26 | |
| Daniel van Vugt | 2016-08-19 | Approve on 2016-08-26 | |
| Kevin DuBois (community) | Approve on 2016-08-22 | ||
| Alan Griffiths | Approve on 2016-08-22 | ||
|
Review via email:
|
|||
Commit Message
Use compiler feature detection to disable false-positive -Werrors.
clang's -Wall -Wextra includes -Wmismatched-tags, which we don't care to (or can't) fix.
Rather than trying to match against the compiler name, just check if these warnings are accepted by the compiler.
This fixes the build when using compilers that support these but don't match *clang*, such as Clang's scan-build static analyser.
Description of the Change
With this change, you can run scan-build on the Mir build again.
| Chris Halse Rogers (raof) wrote : | # |
Nested server, it has all the best flaky tests.
| Mir CI Bot (mir-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:3659
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Daniel van Vugt (vanvugt) wrote : | # |
^^^
Bug 1615470 and bug 1523621, not related to this branch.
| Mir CI Bot (mir-ci-bot) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
https:/
Executed test runs:
FAILURE: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
| Mir CI Bot (mir-ci-bot) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
https:/
Executed test runs:
FAILURE: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
| Mir CI Bot (mir-ci-bot) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
https:/
Executed test runs:
FAILURE: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
FAILURE: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
| Daniel van Vugt (vanvugt) wrote : | # |
^^^
Slightly concerning is:
03:13:48 /usr/include/
03:13:48 /usr/include/
03:13:48 ../../.
03:13:48 /usr/include/
03:13:48 collect2: error: ld returned 1 exit status
Try and get a clean review from mir-ci-bot first.
| Daniel van Vugt (vanvugt) wrote : | # |
Hmm, gcc on yakkety builds this fine for me. Trying autolanding again...
| Mir CI Bot (mir-ci-bot) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
https:/
Executed test runs:
FAILURE: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
| Daniel van Vugt (vanvugt) wrote : | # |
^^^
14:42:07 /usr/include/
14:42:07 /usr/include/
14:42:07 ../../.
14:42:07 /usr/include/
14:42:07 collect2: error: ld returned 1 exit status
| Daniel van Vugt (vanvugt) wrote : | # |
$ bzr merge lp:~raof/mir/fix-clang-detection
M CMakeLists.txt
Text conflict in CMakeLists.txt
1 conflicts encountered.
| Mir CI Bot (mir-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:3671
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Daniel van Vugt (vanvugt) wrote : | # |
Yay. What's broken now?
| Mir CI Bot (mir-ci-bot) wrote : | # |
PASSED: Continuous integration, rev:3671
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Mir CI Bot (mir-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:3672
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
FAILED: Continuous integration, rev:3659
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/