Mir

Merge lp:~raof/mir/driver-metapackages into lp:mir

Proposed by Chris Halse Rogers
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 1983
Proposed branch: lp:~raof/mir/driver-metapackages
Merge into: lp:mir
Diff against target: 164 lines (+87/-56)
1 file modified
debian/control (+87/-56)
To merge this branch: bzr merge lp:~raof/mir/driver-metapackages
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Alan Griffiths Needs Fixing
PS Jenkins bot (community) continuous-integration Approve
Kevin DuBois (community) Approve
Review via email: mp+237706@code.launchpad.net

Commit message

Add two driver metapackages - one for desktop, one for android.

The seeds can use this to get appropriate platform drivers installed and upgraded without us having to modify the seeds each time we change something in the platform packaging.

Mir-side fix for https://bugs.launchpad.net/mir/+bug/1378995

Description of the change

Add two driver metapackages - one for desktop, one for android.

The seeds can use this to get appropriate platform drivers installed and upgraded without us having to modify the seeds each time we change something in the platform packaging.

Mir-side fix for https://bugs.launchpad.net/mir/+bug/1378995

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Looks like the right idea.

Did you need to move so much text though? The diff could be smaller without the moving.

review: Approve
Revision history for this message
Chris Halse Rogers (raof) wrote :

I decided to move all the driver packages into a separate “these will
disappear in the promised future” clump. I didn't think that made the
diff particularly onerous.

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

136 +Package: mir-graphics-drivers-desktop

Perhaps mir-graphics-drivers-mesa instead? We may have other non-Mesa desktop drivers.

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> Perhaps mir-graphics-drivers-mesa instead? We may have other non-Mesa desktop drivers.

...or is the plan to actually hide that detail from other packages, too?

Revision history for this message
Chris Halse Rogers (raof) wrote :

Correct.

Hm. I was going to expound on driver package naming, but maybe I should document it in docs/ instead.

-----Original Message-----
From: "Alexandros Frantzis" <email address hidden>
Sent: ‎9/‎10/‎2014 18:32
To: "Chris Halse Rogers" <email address hidden>
Subject: Re: [Merge] lp:~raof/mir/driver-metapackages into lp:mir

> Perhaps mir-graphics-drivers-mesa instead? We may have other non-Mesa desktop drivers.

...or is the plan to actually hide that detail from other packages, too?
--
https://code.launchpad.net/~raof/mir/driver-metapackages/+merge/237706
You are the owner of lp:~raof/mir/driver-metapackages.

Revision history for this message
Kevin DuBois (kdub) wrote :

looks good

review: Approve
Revision history for this message
Chris Halse Rogers (raof) wrote :

CI scripts fixed to handle this, hitting the rebuild button...

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Chris Halse Rogers (raof) wrote :

Exhausting the address space? Really, CI?

Let's hit that button *again*.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Ugh. We actually need two different fixes. Platform ABI 4 for lp:mir (0.9) and platform ABI 3 for lp:mir/0.8.

See: https://code.launchpad.net/~vanvugt/mir/platform-ABI-4/+merge/237896

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Chris Halse Rogers (raof) wrote :

Well, "fortunately" CI is consistently running out of address space.

-----Original Message-----
From: "Daniel van Vugt" <email address hidden>
Sent: ‎10/‎10/‎2014 17:47
To: "Chris Halse Rogers" <email address hidden>
Subject: Re: [Merge] lp:~raof/mir/driver-metapackages into lp:mir

Review: Needs Fixing

Ugh. We actually need two different fixes. Platform ABI 4 for lp:mir (0.9) and platform ABI 3 for lp:mir/0.8.

See: https://code.launchpad.net/~vanvugt/mir/platform-ABI-4/+merge/237896
--
https://code.launchpad.net/~raof/mir/driver-metapackages/+merge/237706
You are the owner of lp:~raof/mir/driver-metapackages.

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

> Ugh. We actually need two different fixes. Platform ABI 4 for lp:mir (0.9) and
> platform ABI 3 for lp:mir/0.8.

Let's fix it on the tip of devel, please. We don't need a backport to RTM right now, as the landing team took care of this problem for us. We'll backport if need arises.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Chris Halse Rogers (raof) wrote :

Maybe this time, THIS TIME, gcc won't feel like exhausting 64bits of virtual address space?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Still looks OK.

Although maybe consider removing the word "desktop": mir-graphics-drivers-desktop
considering how many Intel-based tablets are around right now, it's plausible we'll be using Mesa on touch devices in the near future...

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

"desktop" vs "mesa" vs some-other-name probably needs discussing.

The word "desktop" is going to cause confusion when it becomes a require package on non-desktops.

review: Needs Information
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Maybe this time, THIS TIME, gcc won't feel like exhausting 64bits of virtual
> address space?

I got fginther onto that yesterday. His fix seems to have worked.

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> "desktop" vs "mesa" vs some-other-name probably needs discussing.
>
> The word "desktop" is going to cause confusion when it becomes a require
> package on non-desktops.

I'm in favor of "mesa" vs "android" and eliminating "desktop".

review: Needs Fixing
Revision history for this message
Robert Carr (robertcarr) wrote :

Let's eliminate desktop suffix.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Hmm, actually we're going to have to consider renaming "mesa" bits to "drm" in future. Because both Nvidia and AMD have announced they will support DRM in their proprietary drivers. However proprietary drivers provide their own libGL* -- which is not "mesa" :)

Revision history for this message
Chris Halse Rogers (raof) wrote :

On Wed, Oct 15, 2014 at 2:50 PM, Daniel van Vugt
<email address hidden> wrote:
> Hmm, actually we're going to have to consider renaming "mesa" bits to
> "drm" in future. Because both Nvidia and AMD have announced they will
> support DRM in their proprietary drivers. However proprietary drivers
> provide their own libGL* -- which is not "mesa" :)

This was indeed why I was going for -desktop; I know that there'll only
be one android platform, because... there's one android platform. There
may well be multiple desktop platforms, though :)

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yep, "desktop" will remain more true for longer than "mesa".

Even though "desktop" will also be used on tablets and phones in future :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-10-10 05:53:01 +0000
3+++ debian/control 2014-10-14 03:38:48 +0000
4@@ -73,34 +73,6 @@
5 Contains the shared libraries required for the Mir server to interact with
6 the underlying hardware platform.
7
8-Package: libmirplatform4driver-mesa
9-Section: libs
10-Architecture: i386 amd64 armhf arm64
11-Multi-Arch: same
12-Pre-Depends: ${misc:Pre-Depends}
13-Depends: ${misc:Depends},
14- ${shlibs:Depends},
15-Description: Display server for Ubuntu - platform library for Mesa
16- Mir is a display server running on linux systems, with a focus on efficiency,
17- robust operation and a well-defined driver model.
18- .
19- Contains the shared libraries required for the Mir server to interact with
20- the hardware platform using the Mesa drivers.
21-
22-Package: libmirplatform4driver-android
23-Section: libs
24-Architecture: i386 amd64 armhf
25-Multi-Arch: same
26-Pre-Depends: ${misc:Pre-Depends}
27-Depends: ${misc:Depends},
28- ${shlibs:Depends},
29-Description: Display server for Ubuntu - platform library for Android
30- Mir is a display server running on linux systems, with a focus on efficiency,
31- robust operation and a well-defined driver model.
32- .
33- Contains the shared libraries required for the Mir server to interact with
34- the hardware platform using the Android drivers.
35-
36 Package: libmircommon-dev
37 Section: libdevel
38 Architecture: i386 amd64 armhf arm64
39@@ -179,34 +151,6 @@
40 .
41 Contains header files required to develop against Mir.
42
43-Package: libmirclient8driver-mesa
44-Section: libs
45-Architecture: i386 amd64 armhf arm64
46-Multi-Arch: same
47-Pre-Depends: ${misc:Pre-Depends}
48-Depends: ${misc:Depends},
49- ${shlibs:Depends}
50-Description: Display server for Ubuntu - client platform library for Mesa
51- Mir is a display server running on linux systems, with a focus on efficiency,
52- robust operation and a well-defined driver model.
53- .
54- Contains the shared libraries required for the Mir clients to interact with
55- the underlying hardware platform using the Mesa drivers.
56-
57-Package: libmirclient8driver-android
58-Section: libs
59-Architecture: i386 amd64 armhf
60-Multi-Arch: same
61-Pre-Depends: ${misc:Pre-Depends}
62-Depends: ${misc:Depends},
63- ${shlibs:Depends}
64-Description: Display server for Ubuntu - client platform library for Android
65- Mir is a display server running on linux systems, with a focus on efficiency,
66- robust operation and a well-defined driver model.
67- .
68- Contains the shared libraries required for the Mir clients to interact with
69- the underlying hardware platform using the Android drivers.
70-
71 Package: mir-demos
72 Architecture: i386 amd64 armhf arm64
73 Depends: ${misc:Depends},
74@@ -259,3 +203,90 @@
75 robust operation and a well-defined driver model.
76 .
77 Contains the shared libraries required for the Mir server and client.
78+
79+# Longer-term these drivers should move out-of-tree
80+Package: libmirclient8driver-mesa
81+Section: libs
82+Architecture: i386 amd64 armhf arm64
83+Multi-Arch: same
84+Pre-Depends: ${misc:Pre-Depends}
85+Depends: ${misc:Depends},
86+ ${shlibs:Depends}
87+Description: Display server for Ubuntu - client platform library for Mesa
88+ Mir is a display server running on linux systems, with a focus on efficiency,
89+ robust operation and a well-defined driver model.
90+ .
91+ Contains the shared libraries required for the Mir clients to interact with
92+ the underlying hardware platform using the Mesa drivers.
93+
94+Package: libmirclient8driver-android
95+Section: libs
96+Architecture: i386 amd64 armhf
97+Multi-Arch: same
98+Pre-Depends: ${misc:Pre-Depends}
99+Depends: ${misc:Depends},
100+ ${shlibs:Depends}
101+Description: Display server for Ubuntu - client platform library for Android
102+ Mir is a display server running on linux systems, with a focus on efficiency,
103+ robust operation and a well-defined driver model.
104+ .
105+ Contains the shared libraries required for the Mir clients to interact with
106+ the underlying hardware platform using the Android drivers.
107+
108+Package: libmirplatform4driver-mesa
109+Section: libs
110+Architecture: i386 amd64 armhf arm64
111+Multi-Arch: same
112+Pre-Depends: ${misc:Pre-Depends}
113+Depends: ${misc:Depends},
114+ ${shlibs:Depends},
115+Description: Display server for Ubuntu - platform library for Mesa
116+ Mir is a display server running on linux systems, with a focus on efficiency,
117+ robust operation and a well-defined driver model.
118+ .
119+ Contains the shared libraries required for the Mir server to interact with
120+ the hardware platform using the Mesa drivers.
121+
122+Package: libmirplatform4driver-android
123+Section: libs
124+Architecture: i386 amd64 armhf
125+Multi-Arch: same
126+Pre-Depends: ${misc:Pre-Depends}
127+Depends: ${misc:Depends},
128+ ${shlibs:Depends},
129+Description: Display server for Ubuntu - platform library for Android
130+ Mir is a display server running on linux systems, with a focus on efficiency,
131+ robust operation and a well-defined driver model.
132+ .
133+ Contains the shared libraries required for the Mir server to interact with
134+ the hardware platform using the Android drivers.
135+
136+Package: mir-graphics-drivers-desktop
137+Section: libs
138+Architecture: any
139+Multi-Arch: same
140+Pre-Depends: ${misc:Pre-Depends}
141+Depends: ${misc:Depends},
142+ libmirplatform3driver-mesa,
143+ libmirclient8driver-mesa
144+Description: Display server for Ubuntu - desktop driver metapackage
145+ Mir is a display server running on linux systems, with a focus on efficiency,
146+ robust operation and a well-defined driver model.
147+ .
148+ This package depends on a full set of graphics drivers for traditional desktop
149+ systems.
150+
151+Package: mir-graphics-drivers-android
152+Section: libs
153+Architecture: any
154+Multi-Arch: same
155+Pre-Depends: ${misc:Pre-Depends}
156+Depends: ${misc:Depends},
157+ libmirplatform4driver-android,
158+ libmirclient8driver-android
159+Description: Display server for Ubuntu - android driver metapackage
160+ Mir is a display server running on linux systems, with a focus on efficiency,
161+ robust operation and a well-defined driver model.
162+ .
163+ This package depends on a full set of graphics drivers for running Mir on top
164+ of an existing Android driver stack.

Subscribers

People subscribed via source and target branches