Mir

Merge lp:~raof/mir/document-our-random-test-binary-data into lp:mir

  1. document-our-random-test-binary-data
  2. Merge into development-branch
Proposed by Chris Halse Rogers on 2015-05-21
Status: Merged
Approved by: Alan Griffiths on 2015-05-21
Approved revision: 2593
Merged at revision: 2596
Proposed branch: lp:~raof/mir/document-our-random-test-binary-data
Merge into: lp:mir
Diff against target: 16 lines (+12/-0)
1 file modified
tests/unit-tests/test_data/README (+12/-0)
To merge this branch: bzr merge lp:~raof/mir/document-our-random-test-binary-data
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-05-21
Kevin DuBois (community) Approve on 2015-05-21
Alan Griffiths 2015-05-21 Approve on 2015-05-21
Review via email: mp+259798@code.launchpad.net

Commit Message

Document how to generate the lib$ARCH.so test data files in unit-tests/test_data

Description of the Change

Document how to generate the lib$ARCH.so test data files in unit-tests/test_data.

To post a comment you must log in.
Alan Griffiths (alan-griffiths) wrote :

why not?

review: Approve
Kevin DuBois (kdub) wrote :

lgtm

review: Approve
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'tests/unit-tests/test_data/README'
2--- tests/unit-tests/test_data/README 1970-01-01 00:00:00 +0000
3+++ tests/unit-tests/test_data/README 2015-05-21 16:37:02 +0000
4@@ -0,0 +1,12 @@
5+Binary Test Data
6+================
7+
8+This directory contains files for testing our shared library loading code.
9+
10+The lib$ARCH.so files are minimal valid ELF objects of the appropriate architectures,
11+generated by running (on the relevant architecture, ARCH):
12+
13+ * touch foo.cpp
14+ * gcc -o lib$ARCH.so -shared foo.cpp
15+
16+These binary objects are then stored in bzr.

Subscribers

People subscribed via source and target branches