Merge lp:~raof/mir/cursor-suitability-is-per-buffer into lp:mir
Proposed by
Chris Halse Rogers
Status: | Merged |
---|---|
Approved by: | Alan Griffiths |
Approved revision: | no longer in the source branch. |
Merged at revision: | 4212 |
Proposed branch: | lp:~raof/mir/cursor-suitability-is-per-buffer |
Merge into: | lp:mir |
Prerequisite: | lp:~raof/mir/better-buffer-plumbing |
Diff against target: |
94 lines (+0/-18) 6 files modified
include/server/mir/frontend/buffer_stream.h (+0/-1) src/server/compositor/stream.cpp (+0/-7) src/server/compositor/stream.h (+0/-1) src/server/frontend/session_mediator.cpp (+0/-5) tests/include/mir/test/doubles/mock_buffer_stream.h (+0/-3) tests/include/mir/test/doubles/stub_buffer_stream.h (+0/-1) |
To merge this branch: | bzr merge lp:~raof/mir/cursor-suitability-is-per-buffer |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mir CI Bot | continuous-integration | Approve | |
Alan Griffiths | Approve | ||
Brandon Schaefer (community) | Approve | ||
Review via email: mp+327666@code.launchpad.net |
Commit message
Drop BufferStream:
This is a per-buffer, not per-bufferstream, property.
To post a comment you must log in.
Note that we now don't throw any errors if someone tries to submit a non-argb-8888 buffer to a cursor stream.
That said, we didn't correctly enforce that before - someone setting up a presentation chain could happily submit non-argb buffers to it.
This is something that should be fixed, but it might want to be fixed by supporting non-argb8888 buffers for cursors.