lp:~raof/mir/client-release-simplifications

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:mir

Cemil Azizoglu (community): Needs Fixing on 2016-12-13

Andreas Pokorny (community): Approve on 2016-12-13

Mir CI Bot: Needs Fixing (continuous-integration) on 2016-12-13

Diff: 352 lines (+122/-59)

8 files modified

include/test/mir/test/validity_matchers.h (+8/-0)
src/client/atomic_callback.h (+15/-10)
src/client/mir_buffer_stream_api.cpp (+8/-1)
src/client/mir_connection.cpp (+11/-46)
src/client/mir_connection.h (+0/-2)
tests/acceptance-tests/staging/test_render_surface.cpp (+45/-0)
tests/mir_test/CMakeLists.txt (+4/-0)
tests/mir_test/validity_matchers.cpp (+31/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

3881. By Chris Halse Rogers on 2016-12-13

Merge trunk

3880. By Chris Halse Rogers on 2016-12-12

Try hand-holding Yakkety compilers

3879. By Chris Halse Rogers on 2016-12-12

Remove now-vestigial MirConnection::StreamRelease and ::released

3878. By Chris Halse Rogers on 2016-12-12

Eagerly destroy MirPresentationChain resources in _release()

Just like MirBufferStream and MirRenderSurface, there's no need to wait for the
server to acknowledge.

3877. By Chris Halse Rogers on 2016-12-12

Eagerly destroy MirBufferStream resources in _release()

Like MirRenderSurface, there's nothing to do client-side after sending the
release RPC message. Simplify things by deleting up-front.

3876. By Chris Halse Rogers on 2016-12-12

Fix unsafe locking in AtomicCallback.

AtomicCallback was calling the underlying callback while holding a lock. Someone
clearly knew this was a bad idea, because they changed it to a std::recursive_mutex,
but that's not the only way this could deadlock.

Since I've just seen a deadlock caused by this, fix it :)

3875. By Chris Halse Rogers on 2016-12-12

Eagerly destroy RenderSurface resources in _release()

There's no need to wait for the server to acknowledge our RPC request.
The client-side never uses any of the RenderSurface resources after sending
the release request, and there's no meaningfull error handling possible.

3874. By Chris Halse Rogers on 2016-12-12

Add IsValid() implementations for MirBufferStream and MirRenderSurface

3873. By Daniel van Vugt on 2016-12-08

PosixTimestamp: Add missing operators >= <=.

Approved by Alan Griffiths, mir-ci-bot.

3872. By Alan Griffiths on 2016-12-08

Bump libmirserver ABI to 43.

Approved by Brandon Schaefer, mir-ci-bot.