Merge lp:~raof/mir/client-driver-probing into lp:mir

[Chris Halse Rogers]

Blank commit message; this is not expected to be landed individually.

First part of split-out privatise-all-the-things, adding the client-side bits.

Broken up to assist in review. Not expected to pass CI, because the packaging infrastructure isn't updated.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2100
http://jenkins.qa.ubuntu.com/job/mir-ci/2263/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/352
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/352
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/326/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/252/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/326/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2263/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'benchmarks/frame-uniformity/CMakeLists.txt'
--- benchmarks/frame-uniformity/CMakeLists.txt	2014-11-20 09:53:04 +0000
+++ benchmarks/frame-uniformity/CMakeLists.txt	2014-11-26 06:34:08 +0000
@@ -24,15 +24,15 @@
 target_link_libraries(frame_uniformity_test_client
   mirserver
   mirclient
+  mirplatform
   
   mir-test
-  mir-test-framework
   mir-test-doubles
   mir-test-doubles-platform
+  mir-test-framework
 
   # Why does this have to come after mir-test-framework here but not in tests/acceptance-tests/
   # /CMakeLists.txt? ~racarr
-  mirplatform
 
   3rd_party
   ${PROTOBUF_LIBRARIES}

=== modified file 'src/client/CMakeLists.txt'
--- src/client/CMakeLists.txt	2014-11-25 02:07:32 +0000
+++ src/client/CMakeLists.txt	2014-11-26 06:34:08 +0000
@@ -1,13 +1,3 @@
-set(MIRCLIENT_ABI 8)
-set(CLIENT_DRIVER client${MIRCLIENT_ABI}driver)
-set(MIR_CLIENT_DRIVER mir${CLIENT_DRIVER})
-set(MIR_CLIENT_DRIVER_BINARY lib${MIR_CLIENT_DRIVER}.so
-    CACHE STRING "File name of Mir client drivers")
-add_definitions(
-  -DMIR_CLIENT_DRIVER_BINARY="${MIR_CLIENT_DRIVER_BINARY}"
-  -DMIR_LOGGING_COMPONENT_FALLBACK="mirclient"
-)
-
 set(PREFIX "${CMAKE_INSTALL_PREFIX}")
 set(EXEC_PREFIX "${CMAKE_INSTALL_PREFIX}")
 set(LIBDIR "${CMAKE_INSTALL_FULL_LIBDIR}")
@@ -33,6 +23,19 @@
   ${DRM_INCLUDE_DIRS}
 )
 
+set(MIRCLIENT_ABI 8)
+set(CLIENT_PLATFORM_VERSION "MIR_CLIENT_PLATFORM_2")
+set(symbol_map ${CMAKE_SOURCE_DIR}/src/client/symbols.map)
+
+set(MIR_CLIENT_PLATFORM_PATH
+  ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/mir/client-platform
+)
+
+add_definitions(-DMIR_CLIENT_PLATFORM_PATH="${MIR_CLIENT_PLATFORM_PATH}/")
+add_definitions(-DCLIENT_PLATFORM_VERSION="${CLIENT_PLATFORM_VERSION}")
+add_definitions(-DMIR_LOGGING_COMPONENT_FALLBACK="mirclient")
+
+
 add_subdirectory(rpc/)
 add_subdirectory(lttng/)
 
@@ -72,6 +75,7 @@
   mir_prompt_session.cpp
   mir_prompt_session_api.cpp
   mir_event_distributor.cpp
+  probing_client_platform_factory.cpp
   periodic_perf_report.cpp
 )
 
@@ -81,8 +85,6 @@
   $<TARGET_OBJECTS:mirclientobjects>
 )
 
-set(symbol_map ${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
-
 set_target_properties(
   mirclient
 
@@ -91,7 +93,9 @@
   LINK_FLAGS "-Wl,--exclude-libs=ALL -Wl,--version-script,${symbol_map}"
 )
 
-target_link_libraries(mirclient
+target_link_libraries(
+  mirclient
+
   mirclientrpc
   mirclientlttngstatic
   mircommon

=== modified file 'src/client/android/CMakeLists.txt'
--- src/client/android/CMakeLists.txt	2014-10-29 06:21:10 +0000
+++ src/client/android/CMakeLists.txt	2014-11-26 06:34:08 +0000
@@ -14,17 +14,18 @@
 )
 
 add_library(
-  mirclientplatformandroid SHARED
-  
+  mirclientplatformandroid MODULE
+
   $<TARGET_OBJECTS:mirclientplatformandroidobjects>
   $<TARGET_OBJECTS:mirclient_platformimpl>
 )
 
 set_target_properties(
   mirclientplatformandroid PROPERTIES
-  OUTPUT_NAME ${MIR_CLIENT_DRIVER}
-  LIBRARY_OUTPUT_DIRECTORY ${LIBRARY_OUTPUT_PATH}/android
-  LINK_FLAGS "-Wl,--exclude-libs=ALL -Wl,--version-script,${symbol_map}"
+  OUTPUT_NAME android
+  LIBRARY_OUTPUT_DIRECTORY ${LIBRARY_OUTPUT_PATH}/client-modules
+  PREFIX ""
+  LINK_FLAGS "-Wl,--version-script,${symbol_map}"
 )
 
 target_link_libraries(mirclientplatformandroid
@@ -33,20 +34,4 @@
   ${LIBHARDWARE_LIBRARIES}
 )
 
-install(TARGETS mirclientplatformandroid LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}/mir/${CLIENT_DRIVER}/android)
-
-if (MIR_TEST_PLATFORM STREQUAL "android")
-  add_custom_command(TARGET mirclientplatformandroid
-    POST_BUILD
-    COMMAND ${CMAKE_COMMAND} -E remove ${MIR_CLIENT_DRIVER_BINARY}
-    COMMAND ${CMAKE_COMMAND} -E create_symlink android/$<TARGET_FILE_NAME:mirclientplatformandroid> ${MIR_CLIENT_DRIVER_BINARY}
-    WORKING_DIRECTORY ${LIBRARY_OUTPUT_PATH}
-  )
-
-  install(CODE
-    "execute_process(
-       COMMAND ln -sf mir/${CLIENT_DRIVER}/android/${MIR_CLIENT_DRIVER_BINARY}
-       WORKING_DIRECTORY \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}
-     )"
-  )
-endif()
+install(TARGETS mirclientplatformandroid LIBRARY DESTINATION ${MIR_CLIENT_PLATFORM_PATH})

=== modified file 'src/client/android/android_native_display_container.cpp'
--- src/client/android/android_native_display_container.cpp	2014-10-29 06:21:10 +0000
+++ src/client/android/android_native_display_container.cpp	2014-11-26 06:34:08 +0000
@@ -62,16 +62,28 @@
 bool
 mcla::AndroidNativeDisplayContainer::validate(MirEGLNativeDisplayType display) const
 {
-    return mir_connection_is_valid(static_cast<MirConnection*>(display));
+    std::lock_guard<std::mutex> lg(guard);
+    return (valid_displays.find(display) != valid_displays.end());
 }
 
 MirEGLNativeDisplayType
-mcla::AndroidNativeDisplayContainer::create(MirConnection* connection)
+mcla::AndroidNativeDisplayContainer::create(ClientContext* context)
 {
-    return static_cast<MirEGLNativeDisplayType>(connection);
+    std::lock_guard<std::mutex> lg(guard);
+    auto egl_display = static_cast<MirEGLNativeDisplayType>(context);
+    valid_displays.insert(egl_display);
+
+    return egl_display;
 }
 
 void
-mcla::AndroidNativeDisplayContainer::release(MirEGLNativeDisplayType /* display */)
+mcla::AndroidNativeDisplayContainer::release(MirEGLNativeDisplayType display)
 {
+    std::lock_guard<std::mutex> lg(guard);
+
+    auto it = valid_displays.find(display);
+    if (it == valid_displays.end())
+        return;
+
+    valid_displays.erase(it);
 }

=== modified file 'src/client/android/android_native_display_container.h'
--- src/client/android/android_native_display_container.h	2013-05-02 00:11:18 +0000
+++ src/client/android/android_native_display_container.h	2014-11-26 06:34:08 +0000
@@ -23,6 +23,9 @@
 
 #include "mir_toolkit/client_types.h"
 
+#include <unordered_set>
+#include <mutex>
+
 namespace mir
 {
 namespace client
@@ -36,7 +39,7 @@
     AndroidNativeDisplayContainer();
     virtual ~AndroidNativeDisplayContainer();
 
-    MirEGLNativeDisplayType create(MirConnection* connection);
+    MirEGLNativeDisplayType create(ClientContext* context) override;
     void release(MirEGLNativeDisplayType display);
 
     bool validate(MirEGLNativeDisplayType display) const;
@@ -44,6 +47,10 @@
 protected:
     AndroidNativeDisplayContainer(AndroidNativeDisplayContainer const&) = delete;
     AndroidNativeDisplayContainer& operator=(AndroidNativeDisplayContainer const&) = delete;
+
+private:
+    std::mutex mutable guard;
+    std::unordered_set<MirEGLNativeDisplayType> valid_displays;
 };
 
 }

=== modified file 'src/client/android/client_platform_factory.cpp'
--- src/client/android/client_platform_factory.cpp	2014-02-07 15:43:41 +0000
+++ src/client/android/client_platform_factory.cpp	2014-11-26 06:34:08 +0000
@@ -16,19 +16,35 @@
  * Authored by: Alexandros Frantzis <[e-mail]>
  */
 
-#include "client_platform_factory.h"
+#include "../client_platform_factory.h"
+#include "mir_toolkit/client_types.h"
+#include "../client_context.h"
 #include "android_client_platform.h"
 
+#include <stdexcept>
+
 namespace mcl = mir::client;
 namespace mcla = mcl::android;
 
-std::shared_ptr<mcl::ClientPlatform>
-mcla::ClientPlatformFactory::create_client_platform(mcl::ClientContext* /*context*/)
+extern "C" std::shared_ptr<mcl::ClientPlatform>
+mcl::create_client_platform(mcl::ClientContext* context)
 {
+    MirPlatformPackage platform;
+    context->populate(platform);
+    if (platform.data_items != 0 || platform.fd_items != 0)
+    {
+        throw new std::runtime_error{"Attempted to create Android client platform on non-Android server"};
+    }
     return std::make_shared<mcla::AndroidClientPlatform>();
 }
 
-extern "C" std::shared_ptr<mcl::ClientPlatformFactory> mcl::create_client_platform_factory()
+extern "C" bool
+mcl::is_appropriate_module(mcl::ClientContext* context)
 {
-    return std::make_shared<mcla::ClientPlatformFactory>();
+    MirPlatformPackage platform;
+    context->populate(platform);
+    // TODO: Actually check what platform we're using, rather than blindly
+    //       hope we can distinguish them from the stuff they've put in the
+    //       PlatformPackage.
+    return platform.data_items == 0 && platform.fd_items == 0;
 }

=== modified file 'src/client/android/client_platform_factory.h'
--- src/client/android/client_platform_factory.h	2014-02-07 15:43:41 +0000
+++ src/client/android/client_platform_factory.h	2014-11-26 06:34:08 +0000
@@ -28,11 +28,8 @@
 namespace android
 {
 
-class ClientPlatformFactory : public client::ClientPlatformFactory
-{
-public:
-    std::shared_ptr<ClientPlatform> create_client_platform(ClientContext* context) override;
-};
+extern "C" std::shared_ptr<ClientPlatform>
+create_client_platform(ClientContext* context);
 
 }
 }

=== modified file 'src/client/android/symbols.map'
--- src/client/android/symbols.map	2014-10-29 06:21:10 +0000
+++ src/client/android/symbols.map	2014-11-26 06:34:08 +0000
@@ -1,5 +1,6 @@
-MIR_CLIENTPLATFORM_1 {
-  global: 
-    create_client_platform_factory;
+MIR_CLIENT_PLATFORM_2 {
+  global:
+    create_client_platform;
+    is_appropriate_module;
   local: *;
-};
\ No newline at end of file
+};

=== modified file 'src/client/client_context.h'
--- src/client/client_context.h	2013-08-28 03:41:48 +0000
+++ src/client/client_context.h	2014-11-26 06:34:08 +0000
@@ -29,7 +29,6 @@
 public:
     virtual ~ClientContext() {}
 
-    virtual MirConnection* mir_connection() = 0;
     virtual void populate(MirPlatformPackage& platform_package) = 0;
 
 protected:

=== modified file 'src/client/client_platform_factory.h'
--- src/client/client_platform_factory.h	2014-03-06 06:05:17 +0000
+++ src/client/client_platform_factory.h	2014-11-26 06:34:08 +0000
@@ -41,8 +41,11 @@
     ClientPlatformFactory& operator=(ClientPlatformFactory const& p) = delete;
 };
 
-extern "C" typedef std::shared_ptr<ClientPlatformFactory>(*CreateClientPlatformFactory)();
-extern "C" std::shared_ptr<ClientPlatformFactory> create_client_platform_factory();
+extern "C" typedef std::shared_ptr<ClientPlatform>(*CreateClientPlatform)(ClientContext* context);
+extern "C" std::shared_ptr<ClientPlatform> create_client_platform(ClientContext* context);
+
+extern "C" typedef bool (*ClientPlatformProbe)(ClientContext* context);
+extern "C" bool is_appropriate_module(ClientContext* context);
 
 }
 }

=== modified file 'src/client/connection_configuration.h'
--- src/client/connection_configuration.h	2014-10-29 06:21:10 +0000
+++ src/client/connection_configuration.h	2014-11-26 06:34:08 +0000
@@ -39,8 +39,6 @@
 class Logger;
 }
 
-class SharedLibrary;
-
 namespace client
 {
 class ConnectionSurfaceMap;
@@ -65,7 +63,6 @@
     virtual std::shared_ptr<LifecycleControl> the_lifecycle_control() = 0;
     virtual std::shared_ptr<EventSink> the_event_sink() = 0;
     virtual std::shared_ptr<EventHandlerRegister> the_event_handler_register() = 0;
-    virtual std::shared_ptr<SharedLibrary> the_platform_library() = 0;
 
 protected:
     ConnectionConfiguration() = default;

=== modified file 'src/client/default_connection_configuration.cpp'
--- src/client/default_connection_configuration.cpp	2014-10-29 06:21:10 +0000
+++ src/client/default_connection_configuration.cpp	2014-11-26 06:34:08 +0000
@@ -35,6 +35,7 @@
 #include "lifecycle_control.h"
 #include "mir/shared_library.h"
 #include "client_platform_factory.h"
+#include "probing_client_platform_factory.h"
 #include "mir_event_distributor.h"
 #include "mir/shared_library_prober.h"
 
@@ -47,7 +48,10 @@
 std::string const off_opt_val{"off"};
 std::string const log_opt_val{"log"};
 std::string const lttng_opt_val{"lttng"};
-std::string const default_platform_lib{MIR_CLIENT_DRIVER_BINARY};
+
+// Shove this here until we properly manage the lifetime of our
+// loadable modules
+std::shared_ptr<mcl::ProbingClientPlatformFactory> the_platform_prober;
 
 // Hack around the way Qt loads mir:
 // qtmir and therefore Mir are loaded via dlopen(..., RTLD_LOCAL).
@@ -108,11 +112,23 @@
     return client_platform_factory(
         [this]
         {
-            auto const create_client_platform_factory =
-                the_platform_library()->load_function<mcl::CreateClientPlatformFactory>(
-                    "create_client_platform_factory");
-
-            return create_client_platform_factory();
+	    ensure_loaded_with_rtld_global();
+            auto const platform_override = getenv("MIR_CLIENT_PLATFORM_LIB");
+            std::vector<std::shared_ptr<mir::SharedLibrary>> platform_plugins;
+            if (platform_override)
+            {
+                platform_plugins.push_back(std::make_shared<mir::SharedLibrary>(platform_override));
+            }
+            else
+            {
+                auto const platform_path_override = getenv("MIR_CLIENT_PLATFORM_PATH");
+                auto const platform_path = platform_path_override ? platform_path_override : MIR_CLIENT_PLATFORM_PATH;
+                platform_plugins = mir::libraries_for_path(platform_path, *the_shared_library_prober_report());
+            }
+
+            the_platform_prober = std::make_shared<mcl::ProbingClientPlatformFactory>(platform_plugins);
+
+            return the_platform_prober;
         });
 }
 
@@ -211,6 +227,7 @@
         {
             auto val_raw = getenv("MIR_CLIENT_SHARED_LIBRARY_PROBER_REPORT");
             std::string const val{val_raw ? val_raw : off_opt_val};
+
             if (val == log_opt_val)
                 return std::make_shared<mir::logging::SharedLibraryProberReport>(the_logger());
             else if (val == lttng_opt_val)
@@ -219,15 +236,3 @@
                 return std::make_shared<mir::logging::NullSharedLibraryProberReport>();
         });
 }
-
-std::shared_ptr<mir::SharedLibrary> mcl::DefaultConnectionConfiguration::the_platform_library()
-{
-    if (!platform_library)
-    {
-        ensure_loaded_with_rtld_global();
-        auto const val_raw = getenv("MIR_CLIENT_PLATFORM_LIB");
-        std::string const libname{val_raw ? val_raw : default_platform_lib};
-        platform_library = std::make_shared<mir::SharedLibrary>(libname);
-    }
-    return platform_library;
-}

=== modified file 'src/client/default_connection_configuration.h'
--- src/client/default_connection_configuration.h	2014-11-05 03:25:04 +0000
+++ src/client/default_connection_configuration.h	2014-11-26 06:34:08 +0000
@@ -60,16 +60,12 @@
     std::shared_ptr<EventSink> the_event_sink() override;
     std::shared_ptr<EventHandlerRegister> the_event_handler_register() override;
     std::shared_ptr<mir::SharedLibraryProberReport> the_shared_library_prober_report();
-    std::shared_ptr<SharedLibrary> the_platform_library() override;
 
     virtual std::string the_socket_file();
     virtual std::shared_ptr<rpc::RpcReport> the_rpc_report();
     virtual std::shared_ptr<input::receiver::InputReceiverReport> the_input_receiver_report();
 
 protected:
-    // MUST be first data member so it is destroyed last.
-    std::shared_ptr<mir::SharedLibrary> platform_library;
-
     CachedPtr<google::protobuf::RpcChannel> rpc_channel;
     CachedPtr<mir::logging::Logger> logger;
     CachedPtr<ClientPlatformFactory> client_platform_factory;

=== modified file 'src/client/egl_native_display_container.h'
--- src/client/egl_native_display_container.h	2014-03-06 06:05:17 +0000
+++ src/client/egl_native_display_container.h	2014-11-26 06:34:08 +0000
@@ -26,12 +26,14 @@
 namespace client
 {
 
+class ClientContext;
+
 class EGLNativeDisplayContainer
 {
 public:
     virtual ~EGLNativeDisplayContainer() {}
 
-    virtual MirEGLNativeDisplayType create(MirConnection* connection) = 0;
+    virtual MirEGLNativeDisplayType create(ClientContext* context) = 0;
     virtual void release(MirEGLNativeDisplayType display) = 0;
 
     virtual bool validate(MirEGLNativeDisplayType display) const = 0;

=== modified file 'src/client/mesa/CMakeLists.txt'
--- src/client/mesa/CMakeLists.txt	2014-10-29 06:21:10 +0000
+++ src/client/mesa/CMakeLists.txt	2014-11-26 06:34:08 +0000
@@ -15,7 +15,7 @@
 )
 
 add_library(
-  mirclientplatformmesa SHARED
+  mirclientplatformmesa MODULE
 
   $<TARGET_OBJECTS:mirclientplatformmesaobjects>
   $<TARGET_OBJECTS:mirclient_platformimpl>
@@ -23,9 +23,10 @@
 
 set_target_properties(
   mirclientplatformmesa PROPERTIES
-  OUTPUT_NAME ${MIR_CLIENT_DRIVER}
-  LIBRARY_OUTPUT_DIRECTORY ${LIBRARY_OUTPUT_PATH}/mesa
-  LINK_FLAGS "-Wl,--exclude-libs=ALL -Wl,--version-script,${symbol_map}"
+  OUTPUT_NAME mesa
+  LIBRARY_OUTPUT_DIRECTORY ${LIBRARY_OUTPUT_PATH}/client-modules
+  PREFIX ""
+  LINK_FLAGS "-Wl,--version-script,${symbol_map}"
 )
 
 target_link_libraries(mirclientplatformmesa
@@ -33,21 +34,4 @@
   ${DRM_LDFLAGS} ${DRM_LIBRARIES}
 )
 
-install(TARGETS mirclientplatformmesa LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}/mir/${CLIENT_DRIVER}/mesa)
-
-if (MIR_TEST_PLATFORM STREQUAL "mesa")
-  add_custom_command(TARGET mirclientplatformmesa
-    POST_BUILD
-    COMMAND ${CMAKE_COMMAND} -E remove ${MIR_CLIENT_DRIVER_BINARY}
-    COMMAND ${CMAKE_COMMAND} -E create_symlink mesa/$<TARGET_FILE_NAME:mirclientplatformmesa> ${MIR_CLIENT_DRIVER_BINARY}
-    WORKING_DIRECTORY ${LIBRARY_OUTPUT_PATH}
-  )
-
-  install(CODE
-    "execute_process(
-       COMMAND ln -sf mir/${CLIENT_DRIVER}/mesa/${MIR_CLIENT_DRIVER_BINARY}
-       WORKING_DIRECTORY \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}
-     )"
-  )
-endif()
-
+install(TARGETS mirclientplatformmesa LIBRARY DESTINATION ${MIR_CLIENT_PLATFORM_PATH})

=== modified file 'src/client/mesa/client_platform.cpp'
--- src/client/mesa/client_platform.cpp	2014-03-06 06:05:17 +0000
+++ src/client/mesa/client_platform.cpp	2014-11-26 06:34:08 +0000
@@ -95,7 +95,7 @@
 std::shared_ptr<EGLNativeDisplayType> mclm::ClientPlatform::create_egl_native_display()
 {
     MirEGLNativeDisplayType *mir_native_display = new MirEGLNativeDisplayType;
-    *mir_native_display = display_container.create(context->mir_connection());
+    *mir_native_display = display_container.create(context);
     auto egl_native_display = reinterpret_cast<EGLNativeDisplayType*>(mir_native_display);
 
     return std::shared_ptr<EGLNativeDisplayType>(egl_native_display, NativeDisplayDeleter(display_container));

=== modified file 'src/client/mesa/client_platform_factory.cpp'
--- src/client/mesa/client_platform_factory.cpp	2014-02-07 15:43:41 +0000
+++ src/client/mesa/client_platform_factory.cpp	2014-11-26 06:34:08 +0000
@@ -16,13 +16,16 @@
  * Authored by: Alexandros Frantzis <[e-mail]>
  */
 
-#include "client_platform_factory.h"
+#include "../client_platform_factory.h"
 #include "client_platform.h"
+#include "mir_toolkit/client_types.h"
+#include "../client_context.h"
 #include "buffer_file_ops.h"
 #include "../egl_native_display_container.h"
 
 #include <sys/mman.h>
 #include <unistd.h>
+#include <stdexcept>
 
 namespace mcl = mir::client;
 namespace mclm = mcl::mesa;
@@ -57,15 +60,26 @@
 
 }
 
-std::shared_ptr<mcl::ClientPlatform>
-mclm::ClientPlatformFactory::create_client_platform(mcl::ClientContext* context)
+extern "C" std::shared_ptr<mcl::ClientPlatform> mcl::create_client_platform(mcl::ClientContext* context)
 {
+    MirPlatformPackage package;
+    context->populate(package);
+    if (package.data_items != 0 || package.fd_items != 1)
+    {
+        throw std::runtime_error{"Attempted to create Mesa client platform on non-Mesa server"};
+    }
     auto buffer_file_ops = std::make_shared<RealBufferFileOps>();
     return std::make_shared<mclm::ClientPlatform>(
         context, buffer_file_ops, mcl::EGLNativeDisplayContainer::instance());
 }
 
-extern "C" std::shared_ptr<mcl::ClientPlatformFactory> mcl::create_client_platform_factory()
+extern "C" bool
+mcl::is_appropriate_module(mcl::ClientContext* context)
 {
-    return std::make_shared<mclm::ClientPlatformFactory>();
+    MirPlatformPackage platform;
+    context->populate(platform);
+    // TODO: Actually check what platform we're using, rather than blindly
+    //       hope we can distinguish them from the stuff they've put in the
+    //       PlatformPackage.
+    return platform.data_items == 0 && platform.fd_items == 1;
 }

=== modified file 'src/client/mesa/client_platform_factory.h'
--- src/client/mesa/client_platform_factory.h	2014-02-07 15:43:41 +0000
+++ src/client/mesa/client_platform_factory.h	2014-11-26 06:34:08 +0000
@@ -28,11 +28,6 @@
 namespace mesa
 {
 
-class ClientPlatformFactory : public client::ClientPlatformFactory
-{
-public:
-    std::shared_ptr<ClientPlatform> create_client_platform(ClientContext* context) override;
-};
 
 }
 }

=== modified file 'src/client/mesa/mesa_native_display_container.cpp'
--- src/client/mesa/mesa_native_display_container.cpp	2014-10-29 06:21:10 +0000
+++ src/client/mesa/mesa_native_display_container.cpp	2014-11-26 06:34:08 +0000
@@ -18,7 +18,7 @@
 
 #include "mesa_native_display_container.h"
 
-#include "mir_toolkit/mir_client_library.h"
+#include "../client_context.h"
 
 #include <cstring>
 #include <unordered_set>
@@ -35,8 +35,8 @@
 static int egl_display_get_platform(MirMesaEGLNativeDisplay* display,
                                     MirPlatformPackage* package)
 {
-    auto connection = static_cast<MirConnection*>(display->context);
-    mir_connection_get_platform(connection, package);
+    auto context = static_cast<mcl::ClientContext*>(display->context);
+    context->populate(*package);
     return MIR_MESA_TRUE;
 }
 
@@ -93,11 +93,11 @@
 }
 
 MirEGLNativeDisplayType
-mclm::MesaNativeDisplayContainer::create(MirConnection* connection)
+mclm::MesaNativeDisplayContainer::create(ClientContext* context)
 {
     MirMesaEGLNativeDisplay* display = new MirMesaEGLNativeDisplay();
     display->display_get_platform = egl_display_get_platform;
-    display->context = connection;
+    display->context = context;
 
     std::lock_guard<std::mutex> lg(guard);
     auto egl_display = static_cast<MirEGLNativeDisplayType>(display);

=== modified file 'src/client/mesa/mesa_native_display_container.h'
--- src/client/mesa/mesa_native_display_container.h	2014-03-06 06:05:17 +0000
+++ src/client/mesa/mesa_native_display_container.h	2014-11-26 06:34:08 +0000
@@ -40,7 +40,7 @@
     MesaNativeDisplayContainer();
     virtual ~MesaNativeDisplayContainer();
 
-    MirEGLNativeDisplayType create(MirConnection* connection);
+    MirEGLNativeDisplayType create(ClientContext* context);
     void release(MirEGLNativeDisplayType display);
 
     bool validate(MirEGLNativeDisplayType display) const;

=== modified file 'src/client/mesa/native_surface.cpp'
--- src/client/mesa/native_surface.cpp	2014-10-29 06:21:10 +0000
+++ src/client/mesa/native_surface.cpp	2014-11-26 06:34:08 +0000
@@ -20,7 +20,6 @@
 #include "../client_buffer.h"
 #include "native_surface.h"
 
-#include <iostream>
 #include <boost/exception/diagnostic_information.hpp> 
 
 namespace mclm=mir::client::mesa;

=== modified file 'src/client/mesa/symbols.map'
--- src/client/mesa/symbols.map	2014-10-29 06:21:10 +0000
+++ src/client/mesa/symbols.map	2014-11-26 06:34:08 +0000
@@ -1,7 +1,9 @@
-MIR_CLIENTPLATFORM_1 {
-  global: 
-    create_client_platform_factory;
+MIR_CLIENT_PLATFORM_2 {
+  global:
+    create_client_platform;
+    is_appropriate_module;
     # Needed by our Mesa EGL platform
     mir_client_mesa_egl_native_display_is_valid;
-  local: *;
+  local:
+    *;
 };

=== modified file 'src/client/mir_connection.cpp'
--- src/client/mir_connection.cpp	2014-11-12 07:07:06 +0000
+++ src/client/mir_connection.cpp	2014-11-26 06:34:08 +0000
@@ -95,11 +95,11 @@
 MirConnection::MirConnection(
     mir::client::ConnectionConfiguration& conf) :
         deregisterer{this},
-        platform_library{conf.the_platform_library()},
         channel(conf.the_rpc_channel()),
         server(channel.get(), ::google::protobuf::Service::STUB_DOESNT_OWN_CHANNEL),
         debug(channel.get(), ::google::protobuf::Service::STUB_DOESNT_OWN_CHANNEL),
         logger(conf.the_logger()),
+        connect_done{false},
         client_platform_factory(conf.the_client_platform_factory()),
         input_platform(conf.the_input_platform()),
         display_configuration(conf.the_display_configuration()),
@@ -235,6 +235,9 @@
                 set_error_message("Connect failed");
             }
         }
+
+        connect_done = true;
+
         /*
          * We need to create the client platform after the connection has been
          * established, to ensure that the client platform has access to all
@@ -370,9 +373,9 @@
 
 void MirConnection::populate(MirPlatformPackage& platform_package)
 {
-    std::lock_guard<decltype(mutex)> lock(mutex);
-
-    if (!connect_result.has_error() && connect_result.has_platform())
+    // connect_result is write-once: once it's valid, we don't need to lock
+    // to use it.
+    if (connect_done && !connect_result.has_error() && connect_result.has_platform())
     {
         auto const& platform = connect_result.platform();
 
@@ -428,11 +431,6 @@
     return platform;
 }
 
-MirConnection* MirConnection::mir_connection()
-{
-    return this;
-}
-
 EGLNativeDisplayType MirConnection::egl_native_display()
 {
     std::lock_guard<decltype(mutex)> lock(mutex);

=== modified file 'src/client/mir_connection.h'
--- src/client/mir_connection.h	2014-10-29 06:21:10 +0000
+++ src/client/mir_connection.h	2014-11-26 06:34:08 +0000
@@ -22,6 +22,7 @@
 #include <memory>
 #include <unordered_set>
 #include <unordered_map>
+#include <atomic>
 
 #include <mutex>
 
@@ -117,8 +118,6 @@
 
     static bool is_valid(MirConnection *connection);
 
-    MirConnection* mir_connection();
-
     EGLNativeDisplayType egl_native_display();
 
     void on_surface_created(int id, MirSurface* surface);
@@ -153,6 +152,7 @@
     std::shared_ptr<mir::logging::Logger> const logger;
     mir::protobuf::Void void_response;
     mir::protobuf::Connection connect_result;
+    std::atomic<bool> connect_done;
     mir::protobuf::Void ignored;
     mir::protobuf::ConnectParameters connect_parameters;
     mir::protobuf::DRMAuthMagicStatus drm_auth_magic_status;

=== added file 'src/client/probing_client_platform_factory.cpp'
--- src/client/probing_client_platform_factory.cpp	1970-01-01 00:00:00 +0000
+++ src/client/probing_client_platform_factory.cpp	2014-11-26 06:34:08 +0000
@@ -0,0 +1,38 @@
+#include "probing_client_platform_factory.h"
+
+#include <boost/exception/all.hpp>
+#include <stdexcept>
+
+namespace mcl = mir::client;
+
+mcl::ProbingClientPlatformFactory::ProbingClientPlatformFactory(std::vector<std::shared_ptr<mir::SharedLibrary>> const& modules)
+    : platform_modules{modules}
+{
+    if (modules.empty())
+    {
+        BOOST_THROW_EXCEPTION(
+            std::runtime_error{"Attempted to create a ClientPlatformFactory with no platform modules"});
+    }
+}
+
+std::shared_ptr<mcl::ClientPlatform>
+mcl::ProbingClientPlatformFactory::create_client_platform(mcl::ClientContext* context)
+{
+    for (auto& module : platform_modules)
+    {
+        try
+        {
+            auto probe = module->load_function<mir::client::ClientPlatformProbe>("is_appropriate_module", CLIENT_PLATFORM_VERSION);
+            if (probe(context))
+            {
+                auto factory = module->load_function<mir::client::CreateClientPlatform>("create_client_platform", CLIENT_PLATFORM_VERSION);
+                return factory(context);
+            }
+        }
+        catch(std::runtime_error)
+        {
+            // We were handled a SharedLibrary that's not a client platform module?
+        }
+    }
+    BOOST_THROW_EXCEPTION(std::runtime_error{"No appropriate client platform module found"});
+}

=== added file 'src/client/probing_client_platform_factory.h'
--- src/client/probing_client_platform_factory.h	1970-01-01 00:00:00 +0000
+++ src/client/probing_client_platform_factory.h	2014-11-26 06:34:08 +0000
@@ -0,0 +1,27 @@
+#ifndef MIR_CLIENT_PROBING_CLIENT_PLATFORM_FACTORY_H_
+#define MIR_CLIENT_PROBING_CLIENT_PLATFORM_FACTORY_H_
+
+#include <vector>
+
+#include "client_platform_factory.h"
+#include "mir/shared_library.h"
+
+namespace mir
+{
+namespace client
+{
+class ProbingClientPlatformFactory : public ClientPlatformFactory
+{
+public:
+    ProbingClientPlatformFactory(std::vector<std::shared_ptr<SharedLibrary>> const& modules);
+
+    std::shared_ptr<ClientPlatform> create_client_platform(ClientContext *context) override;
+private:
+    std::vector<std::shared_ptr<SharedLibrary>> platform_modules;
+};
+
+
+}
+}
+
+#endif // MIR_CLIENT_PROBING_CLIENT_PLATFORM_FACTORY_H_

=== modified file 'src/common/symbols.map'
--- src/common/symbols.map	2014-11-21 12:16:36 +0000
+++ src/common/symbols.map	2014-11-26 06:34:08 +0000
@@ -150,6 +150,7 @@
     # but they are used by libmirplatform, libmirclient or libmirserver
     mir::default_server_socket;
     mir::input::android::Lexicon::translate*;
+    mir::libraries_for_path*;
     mir::logging::input_timestamp*;
     mir::logging::log*;
     mir::logging::set_logger*;

=== modified file 'tests/acceptance-tests/CMakeLists.txt'
--- tests/acceptance-tests/CMakeLists.txt	2014-11-21 12:16:36 +0000
+++ tests/acceptance-tests/CMakeLists.txt	2014-11-26 06:34:08 +0000
@@ -6,7 +6,6 @@
 
 add_definitions(
   -DMIR_PLATFORM_DRIVER_BINARY="${MIR_PLATFORM_DRIVER_BINARY}"
-  -DMIR_CLIENT_DRIVER_BINARY="${MIR_CLIENT_DRIVER_BINARY}"
 )
 
 set(
@@ -75,9 +74,9 @@
   mirplatform
 
   mir-test
-  mir-test-framework
   mir-test-doubles
   mir-test-doubles-platform
+  mir-test-framework
   3rd_party
 
   ${PROTOBUF_LIBRARIES}
@@ -95,8 +94,10 @@
   "MIR_BUILD_ACCEPTANCE_TESTS"
   OFF)
 
+set (MIR_CLIENT_PLATFORM client-platform-dummy.so)
+
 if (MIR_RUN_ACCEPTANCE_TESTS)
-  mir_discover_tests(mir_acceptance_tests)
+  mir_discover_tests(mir_acceptance_tests MIR_CLIENT_PLATFORM_LIB=${LIBRARY_OUTPUT_PATH}/${MIR_CLIENT_PLATFORM})
 endif (MIR_RUN_ACCEPTANCE_TESTS)
 
 install(

=== modified file 'tests/acceptance-tests/test_symbols_required_by_mesa.cpp'
--- tests/acceptance-tests/test_symbols_required_by_mesa.cpp	2014-10-29 06:21:10 +0000
+++ tests/acceptance-tests/test_symbols_required_by_mesa.cpp	2014-11-26 06:34:08 +0000
@@ -21,11 +21,14 @@
 
 #include <dlfcn.h>
 
+#include "mir_test_framework/executable_path.h"
+
 using namespace testing;
+namespace mtf = mir_test_framework;
 
-TEST(SymbolsRequiredByMesa, are_exported_by_libmirclientplatform)
+TEST(SymbolsRequiredByMesa, are_exported_by_client_platform_mesa)
 {
-    auto const handle = dlopen(MIR_CLIENT_DRIVER_BINARY, RTLD_LAZY);
+    auto const handle = dlopen((mtf::library_path() + "/client-modules/mesa.so").c_str(), RTLD_LAZY);
     ASSERT_THAT(handle, NotNull());
 
     auto const sym = dlsym(handle, "mir_client_mesa_egl_native_display_is_valid");

=== modified file 'tests/include/mir_test_doubles/mock_client_context.h'
--- tests/include/mir_test_doubles/mock_client_context.h	2013-04-24 05:22:20 +0000
+++ tests/include/mir_test_doubles/mock_client_context.h	2014-11-26 06:34:08 +0000
@@ -33,18 +33,12 @@
 struct MockClientContext : public client::ClientContext
 {
     MockClientContext()
-        : connection{reinterpret_cast<MirConnection*>(0xabcdef)}
     {
         using namespace testing;
 
-        ON_CALL(*this, mir_connection()).WillByDefault(Return(connection));
-        EXPECT_CALL(*this, mir_connection()).Times(AtLeast(0));
         EXPECT_CALL(*this, populate(_)).Times(AtLeast(0));
     }
 
-    MirConnection* connection;
-
-    MOCK_METHOD0(mir_connection, MirConnection*());
     MOCK_METHOD1(populate, void(MirPlatformPackage&));
 };
 

=== added file 'tests/include/mir_test_framework/client_platform_factory.h'
--- tests/include/mir_test_framework/client_platform_factory.h	1970-01-01 00:00:00 +0000
+++ tests/include/mir_test_framework/client_platform_factory.h	2014-11-26 06:34:08 +0000
@@ -0,0 +1,72 @@
+/*
+ * Copyright © 2014 Canonical Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Christopher James Halse Rogers <[e-mail]>
+ */
+
+#ifndef MIR_TEST_FRAMEWORK_CLIENT_PLATFORM_FACTORY_H_
+#define MIR_TEST_FRAMEWORK_CLIENT_PLATFORM_FACTORY_H_
+
+
+#include "mir/shared_library.h"
+#include "src/client/client_platform_factory.h"
+#include "executable_path.h"
+#include "mir_test_doubles/mock_client_context.h"
+
+namespace mtd = mir::test::doubles;
+
+namespace mir_test_framework
+{
+std::shared_ptr<mir::SharedLibrary> platform_library;
+
+std::shared_ptr<mir::client::ClientPlatform> create_android_client_platform()
+{
+    using namespace testing;
+    mtd::MockClientContext ctx;
+    ON_CALL(ctx, populate(_))
+        .WillByDefault(Invoke([](MirPlatformPackage& package) { ::memset(&package, 0, sizeof(package)); }));
+    platform_library = std::make_shared<mir::SharedLibrary>(library_path() + "/client-modules/android.so");
+    auto platform_factory = platform_library->load_function<mir::client::CreateClientPlatform>("create_client_platform");
+    return platform_factory(&ctx);
+}
+
+std::shared_ptr<mir::client::ClientPlatform> create_mesa_client_platform()
+{
+    using namespace testing;
+    mtd::MockClientContext ctx;
+    ON_CALL(ctx, populate(_))
+        .WillByDefault(Invoke([](MirPlatformPackage& package)
+                              {
+                                  ::memset(&package, 0, sizeof(package));
+                                  package.fd_items = 1;
+                              }));
+    platform_library = std::make_shared<mir::SharedLibrary>(library_path() + "/client-modules/mesa.so");
+    auto platform_factory = platform_library->load_function<mir::client::CreateClientPlatform>("create_client_platform");
+    return platform_factory(&ctx);
+}
+
+std::shared_ptr<mir::SharedLibrary>
+get_platform_library()
+{
+    if (!platform_library)
+    {
+        throw std::logic_error{"Must call one of create_*_client_platform() before calling get_platform_library()"};
+    }
+    return platform_library;
+}
+
+}
+
+#endif // MIR_TEST_FRAMEWORK_CLIENT_PLATFORM_FACTORY_H_

=== added file 'tests/include/mir_test_framework/stub_client_platform_factory.h'
--- tests/include/mir_test_framework/stub_client_platform_factory.h	1970-01-01 00:00:00 +0000
+++ tests/include/mir_test_framework/stub_client_platform_factory.h	2014-11-26 06:34:08 +0000
@@ -0,0 +1,33 @@
+/*
+ * Copyright © 2014 Canonical Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Christopher James Halse Rogers <[e-mail]>
+ */
+
+#ifndef MIR_TEST_FRAMEWORK_STUB_CLIENT_PLATFORM_FACTORY_
+#define MIR_TEST_FRAMEWORK_STUB_CLIENT_PLATFORM_FACTORY_
+
+#include "src/client/client_platform_factory.h"
+
+namespace mir_test_framework
+{
+
+struct StubClientPlatformFactory : public mir::client::ClientPlatformFactory
+{
+    std::shared_ptr<mir::client::ClientPlatform> create_client_platform(mir::client::ClientContext* context) override;
+};
+
+}
+#endif /* MIR_TEST_FRAMEWORK_STUB_CLIENT_PLATFORM_ */

=== modified file 'tests/mir_test_framework/CMakeLists.txt'
--- tests/mir_test_framework/CMakeLists.txt	2014-11-22 11:19:02 +0000
+++ tests/mir_test_framework/CMakeLists.txt	2014-11-26 06:34:08 +0000
@@ -4,10 +4,11 @@
   ${PROJECT_SOURCE_DIR}/src/include/common
   ${PROJECT_SOURCE_DIR}/src/include/server
   ${PROJECT_SOURCE_DIR}/src/include/client
-    ${Boost_INCLUDE_DIRS}
-    ${GLESv2_INCLUDE_DIRS}
-    ${CMAKE_SOURCE_DIR}
-    ${UMOCKDEV_INCLUDE_DIRS}
+  ${Boost_INCLUDE_DIRS}
+  ${GLESv2_INCLUDE_DIRS}
+  ${CMAKE_SOURCE_DIR}
+  ${UMOCKDEV_INCLUDE_DIRS}
+  ${ANDROID_HEADERS_INCLUDE_DIRS}
 )
 
 set(
@@ -31,6 +32,7 @@
   display_server_test_fixture.cpp
   process.cpp
   using_stub_client_platform.cpp
+  stub_client_platform_factory.cpp
   udev_environment.cpp
   declarative_placement_strategy.cpp
   fake_event_hub_server_configuration.cpp
@@ -67,6 +69,28 @@
   ${CMAKE_THREAD_LIBS_INIT} # Link in pthread.
 )
 
+set(symbol_map ${CMAKE_CURRENT_SOURCE_DIR}/symbols-client.map)
+
+add_library(
+  mirclientplatformstub MODULE
+
+  stub_client_platform_module.cpp
+)
+
+target_link_libraries(
+  mirclientplatformstub
+
+  mir-test-framework
+  ${UMOCKDEV_LDFLAGS} ${UMOCKDEV_LIBRARIES}
+)
+
+set_target_properties(
+  mirclientplatformstub PROPERTIES;
+  OUTPUT_NAME client-platform-dummy
+  PREFIX ""
+  LINK_FLAGS "-Wl,--version-script,${symbol_map}"
+)
+
 add_custom_command(TARGET mir-test-framework POST_BUILD
   COMMAND ${CMAKE_COMMAND} -E copy_directory
   ${CMAKE_CURRENT_SOURCE_DIR}/udev_recordings ${CMAKE_BINARY_DIR}/bin/udev_recordings

=== added file 'tests/mir_test_framework/stub_client_platform_factory.cpp'
--- tests/mir_test_framework/stub_client_platform_factory.cpp	1970-01-01 00:00:00 +0000
+++ tests/mir_test_framework/stub_client_platform_factory.cpp	2014-11-26 06:34:08 +0000
@@ -0,0 +1,147 @@
+/*
+ * Copyright © 2014 Canonical Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Christopher James Halse Rogers <[e-mail]>
+ */
+
+#include "mir_test_framework/stub_client_platform_factory.h"
+#include "src/client/client_buffer_factory.h"
+#include "src/client/client_buffer.h"
+#include "src/client/client_platform.h"
+
+#include <string.h>
+
+namespace mcl = mir::client;
+namespace geom = mir::geometry;
+namespace mtf = mir_test_framework;
+
+namespace
+{
+class StubClientBuffer : public mcl::ClientBuffer
+{
+public:
+    StubClientBuffer(std::shared_ptr<MirBufferPackage> const& package)
+    {
+        static_cast<void>(package);
+#ifndef ANDROID
+        native = package;
+#endif
+    }
+
+    std::shared_ptr<mcl::MemoryRegion> secure_for_cpu_write()
+    {
+        return nullptr;
+    }
+
+    geom::Size size() const
+    {
+        return geom::Size{};
+    }
+
+    geom::Stride stride() const
+    {
+        return geom::Stride{};
+    }
+
+    MirPixelFormat pixel_format() const
+    {
+        return mir_pixel_format_abgr_8888;
+    }
+
+    uint32_t age() const
+    {
+        return 0;
+    }
+    void increment_age()
+    {
+    }
+    void mark_as_submitted()
+    {
+    }
+    std::shared_ptr<mir::graphics::NativeBuffer> native_buffer_handle() const
+    {
+#ifdef ANDROID
+        return nullptr;
+#else
+        return native;
+#endif
+    }
+    void update_from(MirBufferPackage const& package) override
+    {
+        static_cast<void>(package);
+#ifndef ANDROID
+        ::memcpy(native.get(), &package, sizeof(package));
+#endif
+    }
+private:
+#ifndef ANDROID
+    std::shared_ptr<mir::graphics::NativeBuffer> native;
+#endif
+
+    virtual void fill_update_msg(MirBufferPackage& /*message*/) override
+    {
+    }
+};
+
+struct StubClientBufferFactory : public mcl::ClientBufferFactory
+{
+    std::shared_ptr<mcl::ClientBuffer> create_buffer(std::shared_ptr<MirBufferPackage> const& package,
+                                                     geom::Size, MirPixelFormat)
+    {
+        return std::make_shared<StubClientBuffer>(package);
+    }
+};
+
+struct StubClientPlatform : public mcl::ClientPlatform
+{
+    MirPlatformType platform_type() const
+    {
+        return mir_platform_type_gbm;
+    }
+
+    std::shared_ptr<mcl::ClientBufferFactory> create_buffer_factory()
+    {
+        return std::make_shared<StubClientBufferFactory>();
+    }
+
+    std::shared_ptr<EGLNativeWindowType> create_egl_native_window(mcl::ClientSurface*)
+    {
+        auto fake_window = reinterpret_cast<EGLNativeWindowType>(0x12345678lu);
+        return std::make_shared<EGLNativeWindowType>(fake_window);
+    }
+
+    std::shared_ptr<EGLNativeDisplayType> create_egl_native_display()
+    {
+        auto fake_display = reinterpret_cast<EGLNativeDisplayType>(0x12345678lu);
+        return std::make_shared<EGLNativeDisplayType>(fake_display);
+    }
+
+    MirNativeBuffer* convert_native_buffer(mir::graphics::NativeBuffer* buf) const
+    {
+        static_cast<void>(buf);
+#ifndef ANDROID
+        return buf;
+#else
+        return nullptr;
+#endif
+    }
+};
+}
+
+std::shared_ptr<mcl::ClientPlatform>
+mtf::StubClientPlatformFactory::create_client_platform(mcl::ClientContext*)
+{
+    return std::make_shared<StubClientPlatform>();
+}

=== added file 'tests/mir_test_framework/stub_client_platform_module.cpp'
--- tests/mir_test_framework/stub_client_platform_module.cpp	1970-01-01 00:00:00 +0000
+++ tests/mir_test_framework/stub_client_platform_module.cpp	2014-11-26 06:34:08 +0000
@@ -0,0 +1,35 @@
+/*
+ * Copyright © 2014 Canonical Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Christopher James Halse Rogers <[e-mail]>>
+ */
+
+#include "src/client/client_platform_factory.h"
+
+#include "mir_test_framework/stub_client_platform_factory.h"
+#include <memory>
+
+namespace mtf = mir_test_framework;
+namespace mcl = mir::client;
+
+extern "C" std::shared_ptr<mcl::ClientPlatform> create_client_platform(mcl::ClientContext* context)
+{
+    return mtf::StubClientPlatformFactory{}.create_client_platform(context);
+}
+
+extern "C" bool is_appropriate_module(mcl::ClientContext* /*context*/)
+{
+    return true;
+}

=== added file 'tests/mir_test_framework/symbols-client.map'
--- tests/mir_test_framework/symbols-client.map	1970-01-01 00:00:00 +0000
+++ tests/mir_test_framework/symbols-client.map	2014-11-26 06:34:08 +0000
@@ -0,0 +1,7 @@
+MIR_CLIENT_PLATFORM_2 {
+  global: 
+    create_client_platform;
+    is_appropriate_module;
+  local:
+    *;
+};

=== modified file 'tests/unit-tests/client/android/test_android_client_platform.cpp'
--- tests/unit-tests/client/android/test_android_client_platform.cpp	2014-03-06 06:05:17 +0000
+++ tests/unit-tests/client/android/test_android_client_platform.cpp	2014-11-26 06:34:08 +0000
@@ -17,9 +17,9 @@
  */
 
 #include "src/client/client_platform.h"
-#include "src/client/android/client_platform_factory.h"
 #include "mir_test_doubles/mock_client_context.h"
 #include "mir_test_doubles/mock_client_surface.h"
+#include "mir_test_framework/client_platform_factory.h"
 
 #include <EGL/egl.h>
 
@@ -28,13 +28,12 @@
 namespace mcl = mir::client;
 namespace mt = mir::test;
 namespace mtd = mt::doubles;
+namespace mtf = mir_test_framework;
 
 TEST(AndroidClientPlatformTest, egl_native_display_is_egl_default_display)
 {
-    mtd::MockClientContext context;
-    mcl::android::ClientPlatformFactory factory;
     mtd::MockClientSurface surface;
-    auto platform = factory.create_client_platform(&context);
+    auto platform = mtf::create_android_client_platform();
     auto mock_client_surface = std::make_shared<mtd::MockClientSurface>();
     auto native_display = platform->create_egl_native_display();
     EXPECT_EQ(EGL_DEFAULT_DISPLAY, *native_display);
@@ -42,10 +41,8 @@
 
 TEST(AndroidClientPlatformTest, egl_native_window_is_set)
 {
-    mtd::MockClientContext context;
-    mcl::android::ClientPlatformFactory factory;
     mtd::MockClientSurface surface;
-    auto platform = factory.create_client_platform(&context);
+    auto platform = mtf::create_android_client_platform();
     auto mock_client_surface = std::make_shared<mtd::MockClientSurface>();
     auto egl_native_window = platform->create_egl_native_window(&surface);
     EXPECT_NE(nullptr, egl_native_window);

=== modified file 'tests/unit-tests/client/mesa/test_client_platform.cpp'
--- tests/unit-tests/client/mesa/test_client_platform.cpp	2014-03-06 06:05:17 +0000
+++ tests/unit-tests/client/mesa/test_client_platform.cpp	2014-11-26 06:34:08 +0000
@@ -17,9 +17,9 @@
  */
 
 #include "src/client/client_platform.h"
-#include "src/client/mesa/client_platform_factory.h"
+#include "mir/shared_library.h"
 #include "src/client/mesa/mesa_native_display_container.h"
-#include "mir_test_doubles/mock_client_context.h"
+#include "mir_test_framework/client_platform_factory.h"
 #include "mir_test_doubles/mock_client_surface.h"
 
 #include "mir_toolkit/mesa/native_display.h"
@@ -30,19 +30,20 @@
 namespace mclm = mir::client::mesa;
 namespace mt = mir::test;
 namespace mtd = mir::test::doubles;
+namespace mtf = mir_test_framework;
 
 TEST(MesaClientPlatformTest, egl_native_display_is_valid_until_released)
 {
-    mtd::MockClientContext context;
-    mclm::ClientPlatformFactory factory;
-    auto platform = factory.create_client_platform(&context);
+    auto platform = mtf::create_mesa_client_platform();
+    auto platform_lib = mtf::get_platform_library();
 
     MirMesaEGLNativeDisplay* nd;
     {
         std::shared_ptr<EGLNativeDisplayType> native_display = platform->create_egl_native_display();
 
         nd = reinterpret_cast<MirMesaEGLNativeDisplay*>(*native_display);
-        EXPECT_EQ(MIR_MESA_TRUE, mclm::mir_client_mesa_egl_native_display_is_valid(nd));
+        auto validate = platform_lib->load_function<MirBool(*)(MirMesaEGLNativeDisplay*)>("mir_client_mesa_egl_native_display_is_valid");
+        EXPECT_EQ(MIR_MESA_TRUE, validate(nd));
     }
     EXPECT_EQ(MIR_MESA_FALSE, mclm::mir_client_mesa_egl_native_display_is_valid(nd));
 }

=== modified file 'tests/unit-tests/client/mesa/test_mesa_native_display_container.cpp'
--- tests/unit-tests/client/mesa/test_mesa_native_display_container.cpp	2014-03-06 06:05:17 +0000
+++ tests/unit-tests/client/mesa/test_mesa_native_display_container.cpp	2014-11-26 06:34:08 +0000
@@ -40,7 +40,7 @@
     }
 
     std::shared_ptr<mclg::MesaNativeDisplayContainer> const container;
-    MirConnection* connection;
+    mir::client::ClientContext* connection;
 };
 
 }

=== modified file 'tests/unit-tests/client/test_client_platform.cpp'
--- tests/unit-tests/client/test_client_platform.cpp	2014-03-06 06:05:17 +0000
+++ tests/unit-tests/client/test_client_platform.cpp	2014-11-26 06:34:08 +0000
@@ -20,60 +20,140 @@
 #include "src/client/mir_client_surface.h"
 #include "mir_test_doubles/mock_client_context.h"
 #include "mir_test_doubles/mock_client_surface.h"
+#include "mir_test_framework/executable_path.h"
 
-#ifdef ANDROID
+#ifdef MIR_BUILD_PLATFORM_ANDROID
 #include "mir_test_doubles/mock_android_hw.h"
-#include "src/client/android/client_platform_factory.h"
-#else
-#include "src/client/mesa/client_platform_factory.h"
 #endif
 
+#include "src/client/client_platform_factory.h"
+
+#include "mir/shared_library.h"
+
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 
 namespace mcl=mir::client;
 namespace mtd = mir::test::doubles;
-
-struct ClientPlatformTest : public ::testing::Test
-{
+namespace mtf = mir_test_framework;
+
+namespace
+{
+struct ClientPlatformTraits
+{
+    ClientPlatformTraits(std::string const& library,
+                         std::function<void(MirPlatformPackage&)> populator,
+                         MirPlatformType type)
+        : platform_library_name{library},
+          populate_package_for{populator},
+          platform_type{type}
+    {
+    }
+
+    std::string const platform_library_name;
+    std::function<void(MirPlatformPackage&)> const populate_package_for;
+    MirPlatformType const platform_type;
+};
+
+struct ClientPlatformTest : public ::testing::TestWithParam<ClientPlatformTraits const*>
+{
+    ClientPlatformTest()
+        : platform_library{mtf::library_path() + "/" + GetParam()->platform_library_name},
+          create_client_platform{platform_library.load_function<mcl::CreateClientPlatform>("create_client_platform")},
+          probe{platform_library.load_function<mcl::ClientPlatformProbe>("is_appropriate_module")}
+    {
+        using namespace testing;
+        ON_CALL(context, populate(_))
+            .WillByDefault(Invoke(GetParam()->populate_package_for));
+    }
+
     mtd::MockClientContext context;
-#ifdef ANDROID
+#ifdef MIR_BUILD_PLATFORM_ANDROID
     testing::NiceMock<mtd::HardwareAccessMock> hw_access_mock;
-    mcl::android::ClientPlatformFactory factory;
-#else
-    mcl::mesa::ClientPlatformFactory factory;
 #endif
+    mir::SharedLibrary platform_library;
+    mcl::CreateClientPlatform const create_client_platform;
+    mcl::ClientPlatformProbe const probe;
 };
 
-TEST_F(ClientPlatformTest, platform_name)
-{
-    auto platform = factory.create_client_platform(&context);
-#ifdef ANDROID
-    auto type = mir_platform_type_android;
-#else
-    auto type = mir_platform_type_gbm;
-#endif
-    EXPECT_EQ(type, platform->platform_type());
-}
-
-TEST_F(ClientPlatformTest, platform_creates)
-{
-    auto platform = factory.create_client_platform(&context);
+#ifdef MIR_BUILD_PLATFORM_ANDROID
+ClientPlatformTraits const android_platform{"/client-modules/android.so",
+                                            [](MirPlatformPackage& pkg)
+                                            {
+                                                ::memset(&pkg, 0, sizeof(pkg));
+                                            },
+                                            mir_platform_type_android
+                                           };
+
+INSTANTIATE_TEST_CASE_P(Android,
+                        ClientPlatformTest,
+                        ::testing::Values(&android_platform));
+
+#endif
+
+#ifdef MIR_BUILD_PLATFORM_MESA
+ClientPlatformTraits const mesa_platform{"/client-modules/mesa.so",
+                                         [](MirPlatformPackage& pkg)
+                                         {
+                                             ::memset(&pkg, 0, sizeof(pkg));
+                                             pkg.fd_items = 1;
+                                         },
+                                         mir_platform_type_gbm
+                                        };
+
+INSTANTIATE_TEST_CASE_P(Mesa,
+                        ClientPlatformTest,
+                        ::testing::Values(&mesa_platform));
+
+#endif
+}
+
+TEST_P(ClientPlatformTest, platform_name)
+{
+    auto platform = create_client_platform(&context);
+
+    EXPECT_EQ(GetParam()->platform_type, platform->platform_type());
+}
+
+TEST_P(ClientPlatformTest, platform_creates)
+{
+    auto platform = create_client_platform(&context);
     auto buffer_factory = platform->create_buffer_factory();
     EXPECT_NE(buffer_factory.get(), (mcl::ClientBufferFactory*) NULL);
 }
 
-TEST_F(ClientPlatformTest, platform_creates_native_window)
+TEST_P(ClientPlatformTest, platform_creates_native_window)
 {
-    auto platform = factory.create_client_platform(&context);
+    auto platform = create_client_platform(&context);
     auto mock_client_surface = std::make_shared<mtd::MockClientSurface>();
     auto native_window = platform->create_egl_native_window(mock_client_surface.get());
     EXPECT_NE(*native_window, (EGLNativeWindowType) NULL);
 }
 
-TEST_F(ClientPlatformTest, platform_creates_egl_native_display)
+TEST_P(ClientPlatformTest, platform_creates_egl_native_display)
 {
-    auto platform = factory.create_client_platform(&context);
+    auto platform = create_client_platform(&context);
     auto native_display = platform->create_egl_native_display();
     EXPECT_NE(nullptr, native_display.get());
 }
+
+TEST_P(ClientPlatformTest, platform_probe_returns_success_when_matching)
+{
+    EXPECT_TRUE(probe(&context));
+}
+
+TEST_P(ClientPlatformTest, platform_probe_returns_false_when_not_matching)
+{
+    using namespace testing;
+    ON_CALL(context, populate(_))
+        .WillByDefault(Invoke([](MirPlatformPackage& pkg)
+                              {
+                                  //Mock up something that hopefully looks nothing like
+                                  //what the platform is expecting...
+                                  ::memset(&pkg, 0, sizeof(pkg));
+                                  pkg.data_items = 0xdeadbeef;
+                                  pkg.fd_items = -23;
+                              }));
+
+    EXPECT_FALSE(probe(&context));
+}

=== modified file 'tests/unit-tests/shared_library_test.cpp'
--- tests/unit-tests/shared_library_test.cpp	2014-10-29 06:21:10 +0000
+++ tests/unit-tests/shared_library_test.cpp	2014-11-26 06:34:08 +0000
@@ -59,10 +59,10 @@
 public:
     SharedLibrary()
         : nonexistent_library{"imma_totally_not_a_library"},
-          existing_library{mtf::library_path() + "/" MIR_CLIENT_DRIVER_BINARY},
+          existing_library{mtf::library_path() + "/client-modules/mesa.so"},
           nonexistent_function{"yo_dawg"},
-          existing_function{"create_client_platform_factory"},
-          existent_version{"MIR_CLIENTPLATFORM_1"},
+          existing_function{"create_client_platform"},
+          existent_version{"MIR_CLIENT_PLATFORM_2"},
           nonexistent_version{"GOATS_ON_THE_GREEN"}
     {
     }