I'm not going to block on a couple of minor issues, but there are still more than a couple. Fix half-ish and I'm happy :)
3. Braces you missed - bzr diff | egrep '^\+.*[^ ]+ {$' +EGLint const default_attr[] = { +namespace { + if (found_surface_type) { + const EGLint attribs_with_pbuffer[] = { + const EGLint attribs_without_surface_type[] = { + const EGLint attribs_without_pbuffer[] = { + const EGLint attribs_without_surface_type[] = { + const EGLint attribs_with_surface_type[] = {
2. I would prefer they're not const.
4. Use your imagination. You know more about the context than I do.
« Back to merge proposal
I'm not going to block on a couple of minor issues, but there are still more than a couple. Fix half-ish and I'm happy :)
3. Braces you missed - bzr diff | egrep '^\+.*[^ ]+ {$' surface_ type) { with_pbuffer[ ] = { without_ surface_ type[] = { without_ pbuffer[ ] = { without_ surface_ type[] = { with_surface_ type[] = {
+EGLint const default_attr[] = {
+namespace {
+ if (found_
+ const EGLint attribs_
+ const EGLint attribs_
+ const EGLint attribs_
+ const EGLint attribs_
+ const EGLint attribs_
2. I would prefer they're not const.
4. Use your imagination. You know more about the context than I do.