Mir

Merge lp:~raof/mir/anr-timeouts into lp:mir

  1. anr-timeouts
  2. Merge into development-branch
Proposed by Chris Halse Rogers
Status: Merged
Approved by: Cemil Azizoglu
Approved revision: no longer in the source branch.
Merged at revision: 3689
Proposed branch: lp:~raof/mir/anr-timeouts
Merge into: lp:mir
Diff against target: 29 lines (+3/-3)
1 file modified
tests/acceptance-tests/test_application_not_responding_detection.cpp (+3/-3)
To merge this branch: bzr merge lp:~raof/mir/anr-timeouts
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve
Cemil Azizoglu (community) Approve
Daniel van Vugt Approve
Review via email: mp+305075@code.launchpad.net

Commit message

Bump timeout for ANR acceptance tests.

These require the server to process three separate alarm notifications across
3 seconds, process them, and wait for the client process to handle them.

Bump the timeouts to values that can't possibly be exceeded, even on our
poor oversubscribed CI hardware.

Plausibly fixes: https://bugs.launchpad.net/mir/+bug/1570327

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3688
https://mir-jenkins.ubuntu.com/job/mir-ci/1659/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2074
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2136
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2127
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2127
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2127
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2102
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2102/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2102
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2102/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2102
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2102/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2102
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2102/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2102
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2102/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1659/rebuild

review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Thanks, I was just thinking the same thing.

review: Approve
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://mir-jenkins.ubuntu.com/job/mir-autolanding/569/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/2076/console
    None: https://mir-jenkins.ubuntu.com/job/generic-land-mp/608/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2138
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2129
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2129
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2129
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2104
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2104/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2104
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2104/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2104/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2104
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2104/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2104
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2104/artifact/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

???

08:00:58 cc1plus: error: invalid argument ���/build/mir��� to -fdebug-prefix-map

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

^bug 1616312

Revision history for this message
Mir CI Bot (mir-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/acceptance-tests/test_application_not_responding_detection.cpp'
2--- tests/acceptance-tests/test_application_not_responding_detection.cpp 2016-06-10 20:39:19 +0000
3+++ tests/acceptance-tests/test_application_not_responding_detection.cpp 2016-09-07 06:57:12 +0000
4@@ -129,7 +129,7 @@
5
6 mir_connection_set_ping_event_callback(connection, &black_hole_pong, nullptr);
7
8- EXPECT_TRUE(marked_as_unresponsive.wait_for(10s));
9+ EXPECT_TRUE(marked_as_unresponsive.wait_for(1min));
10 }
11
12 TEST_F(ApplicationNotRespondingDetection, can_override_anr_detector)
13@@ -198,7 +198,7 @@
14
15 mir_connection_set_ping_event_callback(connection, &black_hole_pong, nullptr);
16
17- EXPECT_TRUE(marked_as_unresponsive.wait_for(10s));
18+ EXPECT_TRUE(marked_as_unresponsive.wait_for(1min));
19
20
21 tear_down();
22@@ -273,7 +273,7 @@
23 auto ping_context = std::make_unique<PingContext>();
24 mir_connection_set_ping_event_callback(connection, &respond_to_ping, ping_context.get());
25
26- EXPECT_TRUE(ping_context->pung_thrice.wait_for(10s));
27+ EXPECT_TRUE(ping_context->pung_thrice.wait_for(1min));
28 EXPECT_FALSE(unresponsive_called);
29 }
30

Subscribers

People subscribed via source and target branches