Gnome-GPG

Merge lp:~randomaction/gnome-gpg/lp374498 into lp:gnome-gpg

  1. lp374498
  2. Merge into devel
Proposed by Ilya Barygin
Status: Needs review
Proposed branch: lp:~randomaction/gnome-gpg/lp374498
Merge into: lp:gnome-gpg
Diff against target: None lines
To merge this branch: bzr merge lp:~randomaction/gnome-gpg/lp374498
Reviewer Review Type Date Requested Status
James Henstridge Pending
Review via email: mp+10529@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ilya Barygin (randomaction) wrote :

This patch was used to fix FTBFS (bug #374498).

Reply

Unmerged revisions

46. By Ilya Barygin

Check return value of write().

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gnome-gpg.c'
2--- gnome-gpg.c 2008-02-17 09:42:12 +0000
3+++ gnome-gpg.c 2009-07-17 13:26:03 +0000
4@@ -173,8 +173,10 @@
5 }
6 gnome_keyring_found_list_free(found_items);
7
8- write (passphrase_fd, passphrase, strlen (passphrase));
9- write (passphrase_fd, "\n", 1);
10+ if (write (passphrase_fd, passphrase, strlen (passphrase)) != strlen (passphrase) ||
11+ write (passphrase_fd, "\n", 1) != 1) {
12+ error_dialog (_("Couldn't write passphrase to file"));
13+ }
14
15 if (keyring_available && save_password) {
16 gchar *nice_name = g_strdup_printf (_("GNU Privacy Guard passphrase for key ID: %s"),

Subscribers

People subscribed via source and target branches

to all changes: