Merge lp:~rameshdharan/nuvola-player/songza into lp:nuvola-player/2.5.x
Proposed by
Ramesh Dharan
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Jiří Janoušek | ||||
Proposed branch: | lp:~rameshdharan/nuvola-player/songza | ||||
Merge into: | lp:nuvola-player/2.5.x | ||||
Diff against target: |
220 lines (+205/-0) 3 files modified
data/nuvolaplayer/services/songza/description.html (+10/-0) data/nuvolaplayer/services/songza/integration.js (+185/-0) data/nuvolaplayer/services/songza/metadata.conf (+10/-0) |
||||
To merge this branch: | bzr merge lp:~rameshdharan/nuvola-player/songza | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jiří Janoušek | Disapprove | ||
Review via email: mp+230330@code.launchpad.net |
Description of the change
Songza service integration
This change implements a Songza service integration.
To post a comment you must log in.
Unmerged revisions
- 846. By Ramesh Dharan
-
Songza service integration
This change implements a service integration for Songza.
Thanks for your work. There is one major issue: Songza.com redirects to daily.songza.com, probably everywhere except for US and Canada. Since daily.songza.com doesn't match the sandbox pattern, the Songza Daily website is opened in an user's default web browsers, which is very confusing. It's better to allow navigation to the Songza Daily website and to inform the user what's going on. See inline comments with proposed modifications.
Please attach a screenshot of Nuvola Player with a visible developer's bar with loaded Songza home page as it would be loaded for the first time.
https:/ /bugs.launchpad .net/nuvola- player/ +bug/1048347