Merge lp:~ramana/gcc-linaro/fix-lp-942307 into lp:gcc-linaro/4.6

Proposed by Ramana Radhakrishnan
Status: Merged
Approved by: Ulrich Weigand
Approved revision: not available
Merge reported by: Ramana Radhakrishnan
Merged at revision: not available
Proposed branch: lp:~ramana/gcc-linaro/fix-lp-942307
Merge into: lp:gcc-linaro/4.6
To merge this branch: bzr merge lp:~ramana/gcc-linaro/fix-lp-942307
Reviewer Review Type Date Requested Status
Ulrich Weigand (community) Approve
Linaro Toolchain Builder Pending
Review via email: mp+95352@code.launchpad.net

Description of the change

Currently proposed a backport for testing purposes. Upstream gcc-4_6-branch is locked down so we can't backport this anyway there right now. I'd like this reviewed upstream for a backport into FSF 4.6 branch as I think it's valid to do so there but in any case here's a local patch that should hopefully fix our current problem.

Uli: could you take a look as this is essentially your original patch and while debugging it I realized this appeared to be the same issue as what you found on trunk a few months back.

cheers
Ramana

To post a comment you must log in.
Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild has taken a snapshot of this branch at r106875 and queued it for build.

The diff against the ancestor r106874 is available at:
 http://builds.linaro.org/toolchain/snapshots/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307.diff

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307
cbuild-ancestor: lp:gcc-linaro+bzr106874
cbuild-state: check

Revision history for this message
Ulrich Weigand (uweigand) wrote :

Yes, this looks exactly like the PR 50305 problem I've been debugging last year ...

The backport looks good to me. OK if regression tests pass.

review: Approve
Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on i686-natty-cbuild259-oort2-i686r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/i686-natty-cbuild259-oort2-i686r1

The testsuite results are the same as the branch point lp:gcc-linaro+bzr106874

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/i686-natty-cbuild259-oort2-i686r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/i686-natty-cbuild259-oort2-i686r1/gcc-testsuite.txt

cbuild-checked: i686-natty-cbuild259-oort2-i686r1

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on x86_64-natty-cbuild259-oort1-x86_64r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/x86_64-natty-cbuild259-oort1-x86_64r1

The testsuite results are the same as the branch point lp:gcc-linaro+bzr106874

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/x86_64-natty-cbuild259-oort1-x86_64r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/x86_64-natty-cbuild259-oort1-x86_64r1/gcc-testsuite.txt

cbuild-checked: x86_64-natty-cbuild259-oort1-x86_64r1

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild259-tcpanda04-armv5r2.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda04-armv5r2

+PASS: gcc.target/arm/pr50305.c (test for excess errors)

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda04-armv5r2/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda04-armv5r2/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild259-tcpanda04-armv5r2

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild259-tcpanda02-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda02-cortexa9r1

-PASS: g++.dg/cdce3.C execution test
+FAIL: g++.dg/cdce3.C execution test
+PASS: gcc.target/arm/pr50305.c (test for excess errors)

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda02-cortexa9r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda02-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild259-tcpanda02-cortexa9r1

Revision history for this message
Michael Hope (michaelh1) wrote :

Note that the cdce3.C failure has been seen before and is probably unrelated to this patch.

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild259-tcpanda02-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda02-cortexa9r1

-PASS: g++.dg/cdce3.C execution test
+FAIL: g++.dg/cdce3.C execution test
+PASS: gcc.target/arm/pr50305.c (test for excess errors)

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda02-cortexa9r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda02-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild259-tcpanda02-cortexa9r1

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild259-tcpanda04-armv5r2.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda04-armv5r2

+PASS: gcc.target/arm/pr50305.c (test for excess errors)

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda04-armv5r2/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106875~ramana~fix-lp-942307/logs/armv7l-natty-cbuild259-tcpanda04-armv5r2/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild259-tcpanda04-armv5r2

Subscribers

People subscribed via source and target branches