Ubuntu One Windows Installer

Merge lp:~ralsina/ubuntuone-windows-installer/uninstall_better into lp:ubuntuone-windows-installer

  1. uninstall_better
  2. Merge into trunk
Proposed by Roberto Alsina
Status: Merged
Approved by: Natalia Bidart
Approved revision: 60
Merged at revision: 60
Proposed branch: lp:~ralsina/ubuntuone-windows-installer/uninstall_better
Merge into: lp:ubuntuone-windows-installer
Diff against target: 12 lines (+1/-1)
1 file modified
ubuntuone_installer/gui/qt/utils/windows.py (+1/-1)
To merge this branch: bzr merge lp:~ralsina/ubuntuone-windows-installer/uninstall_better
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Manuel de la Peña (community) Approve
Review via email: mp+75102@code.launchpad.net

Commit message

Because we are using InstallBuilder Professional, we don't have a "qt" mode, but a "win32" mode.

Description of the change

Because we are using InstallBuilder Professional, we don't have a "qt" mode, but a "win32" mode.

To post a comment you must log in.
Revision history for this message
Manuel de la Peña (mandel) :
review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Is there any way to support both? or we never will need to change back to --mode qt?

review: Needs Information
Revision history for this message
Roberto Alsina (ralsina) wrote :

> Is there any way to support both? or we never will need to change back to
> --mode qt?

I don't expect we will need to change back.

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Approved then!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone_installer/gui/qt/utils/windows.py'
2--- ubuntuone_installer/gui/qt/utils/windows.py 2011-09-12 18:48:09 +0000
3+++ ubuntuone_installer/gui/qt/utils/windows.py 2011-09-13 02:13:23 +0000
4@@ -44,7 +44,7 @@
5 if os.path.exists(uninstall_path):
6 win32api.ShellExecute(None, 'runas',
7 uninstall_path,
8- '--mode qt', '', 0)
9+ '--mode win32', '', 0)
10
11
12 def start_control_panel():

Subscribers

People subscribed via source and target branches