Merge lp:~ralsina/ubuntuone-windows-installer/fix_805290 into lp:ubuntuone-windows-installer

[Roberto Alsina]

Add the "Are you sure" dialog to be displayed on cancellation, as requested by design.

Add the "Are you sure" dialog to be displayed on cancellation, as requested by design.

To test IRL (Windows only):

set PYTHONPATH=..\ubuntuone-control-panel;..\ubuntuone-client;..\ubuntu-sso-client;.
python bin\ubuntuone-installer-qt

And click the "cancel" button.

-----------------

This is the requested wireframe: https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/805290/+attachment/2189876/+files/are_you_sure.png

This is the implemented dialog: https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/805290/+attachment/2189924/+files/are_you_sure_implementation.png

------------------

To test IRL (Windows):

On one terminal start SSO:

set PYTHONPATH=.
python bin\ubuntu-sso-login

On another terminal, start the installer:

set PYTHONPATH=..\ubuntuone-client;..\ubuntuone-control-panel;..\ubuntu-sso-client;.
python bin\ubuntuone-installer-qt

If you cancel in any way (cancel button, closing the window), you should get a "Are you sure" dialog with the usual behaviour.

[lp:~ralsina/ubuntuone-windows-installer/fix_805290]

20. By Roberto Alsina on 2011-07-07

fix test name

21. By Roberto Alsina on 2011-07-07

missing docstring

[Natalia Bidart (nataliabidart)]

* Can you please add tests for the are_you_sure new widget?
Something simple like ensuring that instantiating the class works and the title is correct.

* Can you think of any way of setting the text from the outside (ie programmatically) so it does not have all the html stuff? I'm not sure translators will translate the current message as is, is very difficult to read (and to re-type),

review: Needs Fixing

[lp:~ralsina/ubuntuone-windows-installer/fix_805290]

22. By Roberto Alsina on 2011-07-07

Make it more translator-friendly

23. By Roberto Alsina on 2011-07-07

strings in another file

[Natalia Bidart (nataliabidart)]

Hi!

* Could you please re-use the APP_NAME definition from ubuntuone.clientdefs? SO we don't duplicate that value.

* Could you change the name of the variable 'r' to something more self-explained such as 'response'?

* Could you please fix teh docstring for test_start_control_panel_on_finishing and test_sync_later_hides_message (since you already fixed the one from test_not_start_control_panel_on_cancel)?

* Could you please add ending dots to those docstrings that don't have it (in ubuntuone_installer/gui/qt/tests/test_gui.py)?

* Could you please remove the gettext import in ubuntuone_installer/gui/qt/are_you_sure.py since is not needed?

Thanks!

review: Needs Fixing

[lp:~ralsina/ubuntuone-windows-installer/fix_805290]

24. By Roberto Alsina on 2011-07-07

missing file

25. By Roberto Alsina on 2011-07-07

forgt def

26. By Roberto Alsina on 2011-07-07

style fixes

27. By Roberto Alsina on 2011-07-07

added missing docstring

28. By Roberto Alsina on 2011-07-07

style fixes

29. By Roberto Alsina on 2011-07-07

remove gettext

[Natalia Bidart (nataliabidart)]

Looks great, thanks!

review: Approve

[Natalia Bidart (nataliabidart)]

I approved this branch by mistake :-).

review: Needs Fixing

[lp:~ralsina/ubuntuone-windows-installer/fix_805290]

30. By Roberto Alsina on 2011-07-08

merged r13 from trunk

31. By Roberto Alsina on 2011-07-08

merged r14 from trunk

32. By Roberto Alsina on 2011-07-08

merged r15 from trunk

33. By Roberto Alsina on 2011-07-08

merged r16 from trunk

[Natalia Bidart (nataliabidart)]

Missing docstring:

65:86:87:C0111: 33:MainWindowTestCase.test_title: Missing docstring

Pep8 issues:

./ubuntuone_installer/gui/qt/gui.py:70:21: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/tests/test_gui.py:43:21: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/tests/test_gui.py:426:57: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/tests/test_gui.py:442:57: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/tests/test_gui.py:469:60: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/tests/test_gui.py:510:58: E202 whitespace before ')'

The test case for ubuntuone_installer/gui/qt/tests/test_are_you_sure.py should not be called MainWindowTestCase, shouldn't it?
Also, you need to assert over the dialog message_label content.

review: Needs Fixing

[lp:~ralsina/ubuntuone-windows-installer/fix_805290]

34. By Roberto Alsina on 2011-07-08

Style fixes, extra test

35. By Roberto Alsina on 2011-07-08

strip trailing spaces

[Natalia Bidart (nataliabidart)]

Finally! :-)

review: Approve