Merge lp:~ralsina/ubuntuone-windows-installer/fix_800383 into lp:ubuntuone-windows-installer

[Roberto Alsina]

Beginning of the implementation of the congratulations page.

Beginning of the implementation of this page.

Even after this branch lands:

* Need correct artwork from design
* The optional "syncing" message depends on a previous page

To test (on Linux):

PYTHONPATH=. python bin/ubuntuone-installer-qt

You should have two pages on the wizard.
The "Open Ubuntu One Dashboard" button on the final page should open the control panel.

[dobey (dobey)]

+ subprocess.Popen(["ubuntuone-control-panel-gtk",])

Should this not be ubuntuone-control-panel-qt, given that we're running it from a qt gui? Also, should we not rely on IPC activation to just start the correct one for the user's environment, instead of running it directly?

review: Needs Information

[Natalia Bidart (nataliabidart)]

I'm marking this as needs fixing so we have can have at least a minimal test suite for this widgets that are now starting to have some logic.

Thanks!

review: Needs Fixing

[lp:~ralsina/ubuntuone-windows-installer/fix_800383]

12. By Roberto Alsina on 2011-06-21

style fixes

13. By Roberto Alsina on 2011-06-22

Basic testing stuff copied from control panel, with 4 tests which fail

14. By Roberto Alsina on 2011-06-22

The main UI is not loaded using loadUI

15. By Roberto Alsina on 2011-06-22

Re-add some things that should not have been removed

16. By Roberto Alsina on 2011-06-22

closer to making testing itself work

17. By Roberto Alsina on 2011-06-22

use done() instead of closeEvent()

18. By Roberto Alsina on 2011-06-22

This is as far as I managed to monkeypatch, and I have a problem. I will ask for help now.

19. By Roberto Alsina on 2011-06-22

Make tests work using the reactor as mandel said

20. By Roberto Alsina on 2011-06-22

style fixes

21. By Roberto Alsina on 2011-06-22

Don't start the control panel on the tests

22. By Roberto Alsina on 2011-06-22

whitespace fixes, pylintrc

23. By Roberto Alsina on 2011-06-22

added tests for the 'start control panel' logic

24. By Roberto Alsina on 2011-06-22

add build step to run-tests

25. By Roberto Alsina on 2011-06-22

Style fix

26. By Roberto Alsina on 2011-06-22

use .ui instead of .page_ui for consistency

27. By Roberto Alsina on 2011-06-22

changed method name to be PEP8-alike

28. By Roberto Alsina on 2011-06-22

style issues

29. By Roberto Alsina on 2011-06-22

Make it more like control panel's

[Natalia Bidart (nataliabidart)]

review: Approve

[lp:~ralsina/ubuntuone-windows-installer/fix_800383]

30. By Roberto Alsina on 2011-06-22

switch t the -qt version of control panel

[dobey (dobey)]

review: Approve

=== added file 'data/qt/congratulations.ui'
--- data/qt/congratulations.ui	1970-01-01 00:00:00 +0000
+++ data/qt/congratulations.ui	2011-06-22 14:18:49 +0000
@@ -0,0 +1,103 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ui version="4.0">
+ <class>Form</class>
+ <widget class="QWidget" name="Form">
+  <property name="geometry">
+   <rect>
+    <x>0</x>
+    <y>0</y>
+    <width>426</width>
+    <height>387</height>
+   </rect>
+  </property>
+  <property name="windowTitle">
+   <string>Form</string>
+  </property>
+  <layout class="QVBoxLayout" name="verticalLayout_2">
+   <property name="spacing">
+    <number>24</number>
+   </property>
+   <item>
+    <widget class="QLabel" name="label">
+     <property name="font">
+      <font>
+       <pointsize>14</pointsize>
+       <weight>75</weight>
+       <bold>true</bold>
+      </font>
+     </property>
+     <property name="text">
+      <string>Congratulation!</string>
+     </property>
+    </widget>
+   </item>
+   <item>
+    <widget class="QLabel" name="label_2">
+     <property name="text">
+      <string>Nice picture goes here</string>
+     </property>
+    </widget>
+   </item>
+   <item>
+    <widget class="QLabel" name="label_3">
+     <property name="text">
+      <string>Ubuntu One is installed, set up and is ready to go!</string>
+     </property>
+    </widget>
+   </item>
+   <item>
+    <layout class="QHBoxLayout" name="horizontalLayout">
+     <item>
+      <widget class="QLabel" name="label_4">
+       <property name="text">
+        <string>IMAGE GOES HERE?</string>
+       </property>
+      </widget>
+     </item>
+     <item>
+      <layout class="QVBoxLayout" name="verticalLayout">
+       <item>
+        <widget class="QLabel" name="label_5">
+         <property name="font">
+          <font>
+           <weight>75</weight>
+           <bold>true</bold>
+          </font>
+         </property>
+         <property name="text">
+          <string>Sync in progress...</string>
+         </property>
+        </widget>
+       </item>
+       <item>
+        <widget class="QLabel" name="label_6">
+         <property name="text">
+          <string>Your folders have started to sync in the background, launch the dahboard to get more information about the sync in progress</string>
+         </property>
+         <property name="wordWrap">
+          <bool>true</bool>
+         </property>
+        </widget>
+       </item>
+      </layout>
+     </item>
+    </layout>
+   </item>
+   <item>
+    <spacer name="verticalSpacer">
+     <property name="orientation">
+      <enum>Qt::Vertical</enum>
+     </property>
+     <property name="sizeHint" stdset="0">
+      <size>
+       <width>20</width>
+       <height>40</height>
+      </size>
+     </property>
+    </spacer>
+   </item>
+  </layout>
+ </widget>
+ <resources/>
+ <connections/>
+</ui>

=== added file 'pylintrc'
--- pylintrc	1970-01-01 00:00:00 +0000
+++ pylintrc	2011-06-22 14:18:49 +0000
@@ -0,0 +1,305 @@
+# lint Python modules using external checkers.
+#
+# This is the main checker controlling the other ones and the reports
+# generation. It is itself both a raw checker and an astng checker in order
+# to:
+# * handle message activation / deactivation at the module level
+# * handle some basic but necessary stats'data (number of classes, methods...)
+#
+[MASTER]
+
+# Specify a configuration file.
+#rcfile=
+
+# Python code to execute, usually for sys.path manipulation such as
+# pygtk.require().
+#init-hook=
+
+# Profiled execution.
+profile=no
+
+# Add <file or directory> to the black list. It should be a base name, not a
+# path. You may set this option multiple times.
+ignore=ui,qtreactor
+
+# Pickle collected data for later comparisons.
+persistent=no
+
+# List of plugins (as comma separated values of python modules names) to load,
+# usually to register additional checkers.
+load-plugins=
+
+
+[MESSAGES CONTROL]
+
+# Enable only checker(s) with the given id(s). This option conflicts with the
+# disable-checker option
+#enable-checker=
+
+# Enable all checker(s) except those with the given id(s). This option
+# conflicts with the enable-checker option
+#disable-checker=
+
+# Enable all messages in the listed categories.
+#enable-cat=
+
+# Disable all messages in the listed categories.
+#disable-cat=
+
+# Disable the message(s) with the given id(s) or categories
+# W0142: Used * or ** magic
+# W0613: Unused argument 'yyy'
+disable=R,I,W0142,W0613,W0511
+
+
+[REPORTS]
+
+# Set the output format. Available formats are text, parseable, colorized, msvs
+# (visual studio) and html
+output-format=colorized
+
+# Include message's id in output
+include-ids=yes
+
+# Put messages in a separate file for each module / package specified on the
+# command line instead of printing them on stdout. Reports (if any) will be
+# written in a file name "pylint_global.[txt|html]".
+files-output=no
+
+# Tells whether to display a full report or only the messages
+reports=no
+
+# Python expression which should return a note less than 10 (10 is the highest
+# note). You have access to the variables errors warning, statement which
+# respectively contain the number of errors / warnings messages and the total
+# number of statements analyzed. This is used by the global evaluation report
+# (R0004).
+evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
+
+# Add a comment according to your evaluation note. This is used by the global
+# evaluation report (R0004).
+comment=no
+
+# Enable the report(s) with the given id(s).
+#enable-report=
+
+# Disable the report(s) with the given id(s).
+#disable-report=
+
+
+# try to find bugs in the code using type inference
+#
+[TYPECHECK]
+
+# Tells whether missing members accessed in mixin class should be ignored. A
+# mixin class is detected if its name ends with "mixin" (case insensitive).
+ignore-mixin-members=yes
+
+# List of classes names for which member attributes should not be checked
+# (useful for classes with attributes dynamically set).
+ignored-classes=
+
+# When zope mode is activated, add a predefined set of Zope acquired attributes
+# to generated-members.
+zope=no
+
+# List of members which are set dynamically and missed by pylint inference
+# system, and so shouldn't trigger E0201 when accessed.
+generated-members=REQUEST,acl_users,aq_parent
+
+
+# checks for
+# * unused variables / imports
+# * undefined variables
+# * redefinition of variable from builtins or from an outer scope
+# * use of variable before assignment
+#
+[VARIABLES]
+
+# Tells whether we should check for unused import in __init__ files.
+init-import=yes
+
+# A regular expression matching names used for dummy variables (i.e. not used).
+dummy-variables-rgx=_|dummy
+
+# List of additional names supposed to be defined in builtins. Remember that
+# you should avoid to define new builtins when possible.
+additional-builtins=
+
+
+# checks for :
+# * doc strings
+# * modules / classes / functions / methods / arguments / variables name
+# * number of arguments, local variables, branches, returns and statements in
+# functions, methods
+# * required module attributes
+# * dangerous default values as arguments
+# * redefinition of function / method / class
+# * uses of the global statement
+#
+[BASIC]
+
+# Required attributes for module, separated by a comma
+required-attributes=
+
+# Regular expression which should only match functions or classes name which do
+# not require a docstring
+no-docstring-rgx=(__.*__|setUp|tearDown)
+
+# Regular expression which should only match correct module names
+module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Regular expression which should only match correct module level names
+const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Regular expression which should only match correct class names
+class-rgx=[A-Z_][a-zA-Z0-9]+$
+
+# Regular expression which should only match correct function names
+function-rgx=[a-z_][a-z0-9_]{2,79}$
+
+# Regular expression which should only match correct method names
+method-rgx=([a-z_][a-z0-9_]{2,79}$|setUp|tearDown)
+
+# Regular expression which should only match correct instance attribute names
+attr-rgx=[a-z_][a-z0-9_]{1,30}$
+
+# Regular expression which should only match correct argument names
+argument-rgx=[a-z_][a-z0-9_]{1,30}$
+
+# Regular expression which should only match correct variable names
+variable-rgx=[a-z_][a-z0-9_]{1,30}$
+
+# Regular expression which should only match correct list comprehension /
+# generator expression variable names
+inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
+
+# Good variable names which should always be accepted, separated by a comma
+good-names=d,e,f,g,i,j,k,ex,logger,Run,_
+
+# Bad variable names which should always be refused, separated by a comma
+bad-names=foo,bar,baz,toto,tutu,tata
+
+# List of builtins function names that should not be used, separated by a comma
+bad-functions=apply,input,reduce
+
+
+# checks for sign of poor/misdesign:
+# * number of methods, attributes, local variables...
+# * size, complexity of functions, methods
+#
+[DESIGN]
+
+# Maximum number of arguments for function / method
+max-args=5
+
+# Maximum number of locals for function / method body
+max-locals=15
+
+# Maximum number of return / yield for function / method body
+max-returns=6
+
+# Maximum number of branch for function / method body
+max-branchs=12
+
+# Maximum number of statements in function / method body
+max-statements=50
+
+# Maximum number of parents for a class (see R0901).
+max-parents=7
+
+# Maximum number of attributes for a class (see R0902).
+max-attributes=7
+
+# Minimum number of public methods for a class (see R0903).
+min-public-methods=2
+
+# Maximum number of public methods for a class (see R0904).
+max-public-methods=20
+
+
+# checks for :
+# * methods without self as first argument
+# * overridden methods signature
+# * access only to existent members via self
+# * attributes not defined in the __init__ method
+# * supported interfaces implementation
+# * unreachable code
+#
+[CLASSES]
+
+# List of interface methods to ignore, separated by a comma. This is used for
+# instance to not check methods defines in Zopes Interface base class.
+#ignore-iface-methods=isImplementedBy,deferred,extends,names,namesAndDescriptions,queryDescriptionFor,getBases,getDescriptionFor,getDoc,getName,getTaggedValue,getTaggedValueTags,isEqualOrExtendedBy,setTaggedValue,isImplementedByInstancesOf,adaptWith,is_implemented_by,providedBy
+
+# List of method names used to declare (i.e. assign) instance attributes.
+defining-attr-methods=__init__,__new__,setUp
+
+
+# checks for
+# * external modules dependencies
+# * relative / wildcard imports
+# * cyclic imports
+# * uses of deprecated modules
+#
+[IMPORTS]
+
+# Deprecated modules which should not be used, separated by a comma
+deprecated-modules=regsub,string,TERMIOS,Bastion,rexec
+
+# Create a graph of every (i.e. internal and external) dependencies in the
+# given file (report RP0402 must not be disabled)
+import-graph=
+
+# Create a graph of external dependencies in the given file (report RP0402 must
+# not be disabled)
+ext-import-graph=
+
+# Create a graph of internal dependencies in the given file (report RP0402 must
+# not be disabled)
+int-import-graph=
+
+
+# checks for :
+# * unauthorized constructions
+# * strict indentation
+# * line length
+# * use of <> instead of !=
+#
+[FORMAT]
+
+# Maximum number of characters on a single line.
+max-line-length=79
+
+# Maximum number of lines in a module
+max-module-lines=2500
+
+# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1
+# tab).
+indent-string='    '
+
+
+# checks for similarities and duplicated code. This computation may be
+# memory / CPU intensive, so you should disable it if you experiments some
+# problems.
+#
+[SIMILARITIES]
+
+# Minimum lines number of a similarity.
+min-similarity-lines=4
+
+# Ignore comments when computing similarities.
+ignore-comments=yes
+
+# Ignore docstrings when computing similarities.
+ignore-docstrings=yes
+
+
+# checks for:
+# * warning notes in the code like FIXME, XXX
+# * PEP 263: source code with non ascii character but no encoding declaration
+#
+[MISCELLANEOUS]
+
+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,XXX,TODO,fixme,xxx,todo

=== modified file 'run-tests'
--- run-tests	2011-06-21 20:01:26 +0000
+++ run-tests	2011-06-22 14:18:49 +0000
@@ -37,7 +37,7 @@
 
 ./setup.py build
 echo "Running test suite for ""$MODULE"
-`which xvfb-run` u1trial "$MODULE"
+`which xvfb-run` u1trial --reactor=qt4 --gui "$MODULE"
 style_check
 rm -rf _trial_temp
 rm -rf build

=== modified file 'ubuntuone_installer/__init__.py'
--- ubuntuone_installer/__init__.py	2011-06-21 15:41:55 +0000
+++ ubuntuone_installer/__init__.py	2011-06-22 14:18:49 +0000
@@ -19,7 +19,7 @@
 
 """The windows installer for Ubuntu One.
 
-The installer is a wizard that sets up the basic account and configuration for 
+The installer is a wizard that sets up the basic account and configuration for
 a Ubuntu One user on windows.
 """
 

=== modified file 'ubuntuone_installer/gui/qt/__init__.py'
--- ubuntuone_installer/gui/qt/__init__.py	2011-06-21 18:18:33 +0000
+++ ubuntuone_installer/gui/qt/__init__.py	2011-06-22 14:18:49 +0000
@@ -17,4 +17,3 @@
 # with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 """The Qt graphical interface for the Ubuntu One Installer."""
-

=== modified file 'ubuntuone_installer/gui/qt/gui.py'
--- ubuntuone_installer/gui/qt/gui.py	2011-06-21 19:46:39 +0000
+++ ubuntuone_installer/gui/qt/gui.py	2011-06-22 14:18:49 +0000
@@ -19,32 +19,37 @@
 
 """The user interface for the Ubuntu One Installer."""
 
+import subprocess
 
 from PyQt4 import QtGui
 
 from ubuntuone_installer.logger import setup_logging
-from ubuntuone_installer.gui.qt.ui import license_ui
+from ubuntuone_installer.gui.qt.ui import (
+    license_ui,
+    congratulations_ui,
+)
 
 import gettext
 
 _ = gettext.gettext
 
+# Invalid name logger
+# pylint: disable=C0103
 logger = setup_logging('qt.gui')
+# pylint: enable=C0103
 
 
 class LicensePage(QtGui.QWizardPage):
     """Wizard Page that displays the license info and links to the GPL"""
 
-    # Invalid constant names and Qt-inherited methods
-    # pylint: disable=C0103
-    
-    LICENSE_PAGE = 0
-    
     def __init__(self, parent=None):
         QtGui.QWizardPage.__init__(self, parent)
         self.ui = license_ui.Ui_Form()
         self.ui.setupUi(self)
 
+    # Invalid names of Qt-inherited methods
+    # pylint: disable=C0103
+
     def initializePage(self):
         """Setup UI details"""
 
@@ -55,50 +60,79 @@
         # Set the right texts and connections for buttons
         self.setButtonText(QtGui.QWizard.NextButton, _("Agree && Install"))
         self.setButtonText(QtGui.QWizard.CancelButton,
-            _("Disagree && Cancel"))        
-        self.setButtonText(QtGui.QWizard.CustomButton1, _("&Print"))        
-        self.wizard().customButtonClicked.connect(self.printDocument)
-        
-    def printDocument(self, button_id):
+            _("Disagree && Cancel"))
+        self.setButtonText(QtGui.QWizard.CustomButton1, _("&Print"))
+        self.wizard().customButtonClicked.connect(self.print_document)
+
+    def print_document(self, button_id):
         """Print the document displayed in textBrowser"""
-        
+
         if button_id == QtGui.QWizard.CustomButton1:
             document = self.ui.textBrowser.document()
             printer = QtGui.QPrinter(QtGui.QPrinter.HighResolution)
 
             dialog = QtGui.QPrintDialog(printer, self)
-            
+
             dialog.setWindowTitle(_("Send to printer"))
             if dialog.exec_() != QtGui.QDialog.Accepted:
                 return
             printer.setFullPage(True)
             printer.setPageSize(QtGui.QPrinter.A4)
             document.print_(printer)
-        
+
+
+class CongratulationsPage(QtGui.QWizardPage):
+    """Final page of the wizard"""
+
+    def __init__(self, parent=None):
+        QtGui.QWizardPage.__init__(self, parent)
+        self.ui = congratulations_ui.Ui_Form()
+        self.ui.setupUi(self)
+
+    # Invalid names of Qt-inherited methods
+    # pylint: disable=C0103
+
+    def initializePage(self):
+        """Setup UI details"""
+
+        # We need custom buttons
+        self.wizard().setButtonText(QtGui.QWizard.FinishButton,
+            _("Go to my Ubuntu One dashboard"))
+        self.wizard().setOption(QtGui.QWizard.HaveCustomButton1, False)
+        self.wizard().setOption(QtGui.QWizard.NoCancelButton, True)
+
 
 class MainWindow(QtGui.QWizard):
     """The Main Window of the Installer wizard."""
 
+    # Invalid constant names and Qt-inherited methods
+    # pylint: disable=C0103
+
+    LICENSE_PAGE = 0
+    CONGRATULATIONS_PAGE = 1
+
     def __init__(self, close_callback=None):
         """Initialize this instance with the UI layout."""
+
         QtGui.QWizard.__init__(self)
         self.close_callback = close_callback
 
         self.setOption(self.NoBackButtonOnStartPage, True)
-
+        self.setOption(self.DisabledBackButtonOnLastPage, True)
         # PyQt doesn't support the (int, page) version of addPage
         # Add the pages in the right order
-        
+
         # pylint: disable=C0103
         self.LICENSE_PAGE = self.addPage(LicensePage())
-        # Dummy page to have a "Next"
-        self.addPage(QtGui.QWizardPage())
+        self.CONGRATULATIONS_PAGE = self.addPage(CongratulationsPage())
 
     # Invalid name "closeEvent"
     # pylint: disable=C0103
 
     def done(self, result):
         """The main window is being closed, call any custom callback."""
+        if result == 1:  # Finished, not cancelled
+            subprocess.Popen(["ubuntuone-control-panel-qt", ])
         if self.close_callback is not None:
             self.close_callback()
         QtGui.QWizard.done(self, result)

=== added directory 'ubuntuone_installer/gui/qt/tests'
=== added file 'ubuntuone_installer/gui/qt/tests/__init__.py'
--- ubuntuone_installer/gui/qt/tests/__init__.py	1970-01-01 00:00:00 +0000
+++ ubuntuone_installer/gui/qt/tests/__init__.py	2011-06-22 14:18:49 +0000
@@ -0,0 +1,68 @@
+# -*- coding: utf-8 -*-
+
+# Authors: Alejandro J. Cura <[e-mail]>
+#
+# Copyright 2011 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""The test suite for the Qt UI of the Ubuntu One Installer."""
+
+from ubuntuone_installer.tests import TestCase
+from ubuntuone_installer.gui.tests import FakedObject
+
+# Attribute 'yyy' defined outside __init__, access to a protected member
+# pylint: disable=W0201, W0212
+
+
+NO_OP = lambda *args: None
+
+
+def skip_if_abstract_class(test):
+    """Decorator to skip a test if is an abstract class."""
+
+    def inner(instance):
+        """Skip a test if is an abstract class."""
+        abstract = instance.class_ui is None
+        result = None
+        if not abstract:
+            result = test(instance)
+
+        return result
+
+    return inner
+
+
+class FakeUi(FakedObject):
+    """A fake Ui object."""
+
+    exposed_methods = ['setupUi']
+
+
+class BaseTestCase(TestCase):
+    """Base Test Case."""
+
+    class_ui = None
+    kwargs = {}
+
+    @skip_if_abstract_class
+    def setUp(self):
+        super(BaseTestCase, self).setUp()
+        # self.class_ui is not callable
+        # pylint: disable=E1102
+        # pylint: disable=C0103
+        self.ui = self.class_ui(**self.kwargs)
+
+        if hasattr(self.ui, 'backend'):
+            # clean backend calls
+            self.ui.backend._called.clear()

=== added file 'ubuntuone_installer/gui/qt/tests/test_gui.py'
--- ubuntuone_installer/gui/qt/tests/test_gui.py	1970-01-01 00:00:00 +0000
+++ ubuntuone_installer/gui/qt/tests/test_gui.py	2011-06-22 14:18:49 +0000
@@ -0,0 +1,61 @@
+# -*- coding: utf-8 -*-
+
+# Authors: Alejandro J. Cura <[e-mail]>
+#          Roberto Alsina <[e-mail]>
+#
+# Copyright 2011 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""Tests for the Qt UI."""
+
+from ubuntuone_installer.gui.qt import gui
+from ubuntuone_installer.gui.qt.tests import BaseTestCase
+
+
+class MainWindowTestCase(BaseTestCase):
+    """Test the qt main window."""
+
+    class_ui = gui.MainWindow
+
+    def setUp(self):
+        """Initialize this test instance."""
+        super(MainWindowTestCase, self).setUp()
+
+    def test_done_calls_custom_close_callback(self):
+        """When closing the window, close_callback is called."""
+        self.ui.close_callback = self._set_called
+        self.ui.done(result=0)
+        self.assertEqual(self._called,
+                         ((), {}), 'close_callback called.')
+
+    def test_close_callback_can_be_none(self):
+        """The close_callback can be None."""
+        self.ui.close_callback = None
+        self.ui.done(result=0)
+        # world did not explode
+
+    def test_start_control_panel_on_finishing(self):
+        """If done is called with result=1, the control panel
+        should be called"""
+        self.patch(gui.subprocess, "Popen", self._set_called)
+        self.ui.done(result=1)
+        self.assertEqual(self._called,
+            ((['ubuntuone-control-panel-qt'],), {}))
+
+    def test_not_start_control_panel_on_cancel(self):
+        """If done is called with result=0, the control panel
+        should NOT be called"""
+        self.patch(gui.subprocess, "Popen", self._set_called)
+        self.ui.done(result=0)
+        self.assertEqual(self._called, False)

=== added directory 'ubuntuone_installer/gui/tests'
=== added file 'ubuntuone_installer/gui/tests/__init__.py'
--- ubuntuone_installer/gui/tests/__init__.py	1970-01-01 00:00:00 +0000
+++ ubuntuone_installer/gui/tests/__init__.py	2011-06-22 14:18:49 +0000
@@ -0,0 +1,45 @@
+# -*- coding: utf-8 -*-
+
+# Authors: Natalia B Bidart <[e-mail]>
+#          Roberto Alsina <[e-mail]>
+#
+# Copyright 2011 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""The test suite for the Ubuntu One Installer."""
+
+# Attribute 'yyy' defined outside __init__, access to a protected member
+# pylint: disable=W0201, W0212
+
+
+class FakedObject(object):
+    """Fake an object, record every call."""
+
+    exposed_methods = []
+
+    def __init__(self, *args, **kwargs):
+        self._args = args
+        self._kwargs = kwargs
+        self._called = {}
+        for i in self.exposed_methods:
+            setattr(self, i, self._record_call(i))
+
+    def _record_call(self, func_name):
+        """Store values when calling 'func_name'."""
+
+        def inner(*args, **kwargs):
+            """Fake 'func_name'."""
+            self._called[func_name] = (args, kwargs)
+
+        return inner

=== added directory 'ubuntuone_installer/tests'
=== added file 'ubuntuone_installer/tests/__init__.py'
--- ubuntuone_installer/tests/__init__.py	1970-01-01 00:00:00 +0000
+++ ubuntuone_installer/tests/__init__.py	2011-06-22 14:18:49 +0000
@@ -0,0 +1,38 @@
+# -*- coding: utf-8 -*-
+
+# Authors: Natalia B Bidart <[e-mail]>
+#          Roberto Alsina <[e-mail]>
+#
+# Copyright 2010-2011 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""The test suite for the Ubuntu One Installer"""
+
+from ubuntuone.devtools.testcase import TestCase as BaseTestCase
+
+
+class TestCase(BaseTestCase):
+    """Basics for testing."""
+
+    assertIs = BaseTestCase.assertIdentical
+
+    def setUp(self):
+        self._called = False
+
+    def tearDown(self):
+        self._called = False
+
+    def _set_called(self, *args, **kwargs):
+        """Store 'args' and 'kwargs' for test assertions."""
+        self._called = (args, kwargs)