Merge lp:~ralsina/ubuntuone-windows-installer/doing-windows into lp:ubuntuone-windows-installer

Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 119
Merged at revision: 107
Proposed branch: lp:~ralsina/ubuntuone-windows-installer/doing-windows
Merge into: lp:ubuntuone-windows-installer
Diff against target: 248 lines (+51/-38)
5 files modified
scripts/README (+3/-2)
scripts/conf.py (+11/-8)
scripts/setup.py (+30/-21)
scripts/ubuntuone.xml (+6/-6)
scripts/ubuntuone_autoupdate.xml (+1/-1)
To merge this branch: bzr merge lp:~ralsina/ubuntuone-windows-installer/doing-windows
Reviewer Review Type Date Requested Status
Diego Sarmentero (community) Approve
Brian Curtin (community) Approve
Review via email: mp+97972@code.launchpad.net

Commit message

Cleanup windows build, get rid of windows-installer, build all required binaries.

Description of the change

Cleanup windows build, get rid of windows-installer, build all required binaries.

To post a comment you must log in.
116. By Roberto Alsina

no manual branches, fixed version number

117. By Roberto Alsina

missing ampersand

118. By Roberto Alsina

missing argument

119. By Roberto Alsina

abandon the idea of release number and version being similar

Revision history for this message
Brian Curtin (brian.curtin) wrote :

+1 - looks fine, worked well IRL when I used it a few minutes ago

review: Approve
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/README'
2--- scripts/README 2012-01-04 12:43:39 +0000
3+++ scripts/README 2012-03-23 18:38:19 +0000
4@@ -35,8 +35,9 @@
5 -------------------------
6
7 Update the release numbers in setup.py ubuntuone_autoupdate.xml and
8-ubuntuone.xml. Remember that you have both a build (ex: 203)
9-and a release (ex: 2.0.3)
10+ubuntuone.xml. Remember that you have both a build (ex: 1000)
11+and a release (ex: 2.0.3). The build number in ubuntuone_autoupdate.xml should
12+be increased on all releases and is not related to the version number.
13
14 Get the VS2008 runtime "vcredist_x86.exe" and put it in the
15 scripts folder.
16
17=== modified file 'scripts/conf.py'
18--- scripts/conf.py 2012-03-16 14:19:31 +0000
19+++ scripts/conf.py 2012-03-23 18:38:19 +0000
20@@ -13,28 +13,31 @@
21 #
22 # You should have received a copy of the GNU General Public License along
23 # with this program. If not, see <http://www.gnu.org/licenses/>.
24+
25 """Configure what branches make the release."""
26
27+# This is appended to the branches. So, if you set it to
28+# "/stable-3-0" you will get lp:ubuntuone-client/stable-3-0
29+BRANCH_POSTFIX = ""
30+
31 # You can add branches that are to be merged into the release by
32 # adding them to the adequate list.
33
34+
35 U1_CLIENT_BRANCHES = (
36- "lp:ubuntuone-client",
37+ "lp:ubuntuone-client" + BRANCH_POSTFIX,
38 )
39 U1_CONTROL_PANEL_BRANCHES = (
40- "lp:ubuntuone-control-panel",
41+ "lp:ubuntuone-control-panel" + BRANCH_POSTFIX,
42 )
43 UBUNTU_SSO_BRANCHES = (
44- "lp:ubuntu-sso-client",
45-)
46-U1_WINDOWS_INSTALLER_BRANCHES = (
47- "lp:ubuntuone-windows-installer",
48+ "lp:ubuntu-sso-client" + BRANCH_POSTFIX,
49 )
50 U1_STORAGE_PROTOCOL_BRANCHES = (
51- "lp:ubuntuone-storage-protocol",
52+ "lp:ubuntuone-storage-protocol" + BRANCH_POSTFIX,
53 )
54
55 # If show_cmd is set to True, then the binaries will have cmd windows where
56 # you can see stderr.
57
58-SHOW_CMD = False
59+SHOW_CMD = True
60
61=== modified file 'scripts/setup.py'
62--- scripts/setup.py 2012-03-16 14:39:17 +0000
63+++ scripts/setup.py 2012-03-23 18:38:19 +0000
64@@ -160,7 +160,6 @@
65 branch_and_merge(conf.U1_CLIENT_BRANCHES)
66 branch_and_merge(conf.U1_CONTROL_PANEL_BRANCHES)
67 branch_and_merge(conf.UBUNTU_SSO_BRANCHES)
68- branch_and_merge(conf.U1_WINDOWS_INSTALLER_BRANCHES)
69 branch_and_merge(conf.U1_STORAGE_PROTOCOL_BRANCHES)
70 # pylint: enable=R0904
71
72@@ -188,16 +187,25 @@
73 shutil.copyfile(os.path.join(
74 "sources", "ubuntuone-client", "bin", "u1sdtool"),
75 os.path.join("bin", "u1sdtool"))
76+ shutil.copyfile(os.path.join(
77+ "sources", "ubuntuone-client", "bin", "ubuntuone-proxy-tunnel"),
78+ os.path.join("bin", "ubuntuone-proxy-tunnel"))
79 shutil.copyfile(os.path.join("sources", "ubuntu-sso-client",
80 "bin", "ubuntu-sso-login"),
81 os.path.join("bin", "ubuntu-sso-login"))
82+ shutil.copyfile(os.path.join("sources", "ubuntu-sso-client",
83+ "bin", "ubuntu-sso-login-qt"),
84+ os.path.join("bin", "ubuntu-sso-login-qt"))
85+ shutil.copyfile(os.path.join("sources", "ubuntu-sso-client",
86+ "bin", "ubuntu-sso-proxy-creds-qt"),
87+ os.path.join("bin", "ubuntu-sso-proxy-creds-qt"))
88+ shutil.copyfile(os.path.join("sources", "ubuntu-sso-client",
89+ "bin", "ubuntu-sso-ssl-certificate-qt"),
90+ os.path.join("bin", "ubuntu-sso-ssl-certificate-qt"))
91 shutil.copyfile(os.path.join("sources",
92 "ubuntuone-control-panel", "bin",
93 "ubuntuone-control-panel-qt"),
94 os.path.join("bin", "ubuntuone-control-panel-qt"))
95- shutil.copyfile(os.path.join("sources", "ubuntuone-windows-installer",
96- "bin", "ubuntuone-installer-qt"),
97- os.path.join("bin", "ubuntuone-installer-qt"))
98
99 # Remove "installed" copy
100 try:
101@@ -241,23 +249,12 @@
102 stdout=subprocess.PIPE).communicate()[0]
103 os.chdir(start_dir)
104
105- os.chdir(os.path.join("sources", "ubuntuone-windows-installer"))
106- os.system("python setup.py build")
107- # Copying by hand because the install is borked
108- dest_installer = os.path.join(dest_dir, "ubuntuone_installer")
109- shutil.copytree("ubuntuone_installer", dest_installer)
110- u1inst_revno = subprocess.Popen(
111- ["bzr", "revno", "."],
112- stdout=subprocess.PIPE).communicate()[0]
113- os.chdir(start_dir)
114-
115 # Create revno file
116 with open(os.path.join("data", "revnos.txt"), "w+") as revnos:
117 revnos.write("ubuntu-sso-client: %s"
118 "ubuntuone-client: %s"
119- "ubuntuone-control-panel: %s"
120- "ubuntuonw-windows-installer: %s" %
121- (sso_revno, u1client_revno, u1cp_revno, u1inst_revno))
122+ "ubuntuone-control-panel: %s" %
123+ (sso_revno, u1client_revno, u1cp_revno))
124
125 # Copy storage-protocol's pem files
126 shutil.copyfile(os.path.join("sources",
127@@ -304,6 +301,10 @@
128 'icon_resources': [(0, 'ubuntu_one.ico')]
129 },
130 {
131+ 'script': 'bin/ubuntuone-proxy-tunnel',
132+ 'icon_resources': [(0, 'ubuntu_one.ico')]
133+ },
134+ {
135 'script': 'bin/ubuntuone-control-panel-qt',
136 'icon_resources': [(0, 'ubuntu_one.ico')]
137 },
138@@ -312,7 +313,15 @@
139 'icon_resources': [(0, 'ubuntu_one.ico')]
140 },
141 {
142- 'script': 'bin/ubuntuone-installer-qt',
143+ 'script': 'bin/ubuntu-sso-login-qt',
144+ 'icon_resources': [(0, 'ubuntu_one.ico')]
145+ },
146+ {
147+ 'script': 'bin/ubuntu-sso-proxy-creds-qt',
148+ 'icon_resources': [(0, 'ubuntu_one.ico')]
149+ },
150+ {
151+ 'script': 'bin/ubuntu-sso-ssl-certificate-qt',
152 'icon_resources': [(0, 'ubuntu_one.ico')]
153 },
154 ]
155@@ -324,7 +333,7 @@
156 # Build bundles
157 setup(
158 name='ubuntuone',
159- version='2.0.3',
160+ version='2.99.91',
161 license='GPL v3',
162 author='',
163 author_email='',
164@@ -342,11 +351,11 @@
165 'includes': ['google.protobuf.descriptor',
166 'sip',
167 'twisted.web.resource',
168+ 'twisted.web.client',
169 'ubuntu_sso.qt',
170- 'ubuntu_sso.qt.gui',
171+ 'ubuntu_sso.qt.ui',
172 'PyQt4.QtNetwork',
173 'oauth',
174- 'ubuntuone_installer',
175 'configglue',
176 'configglue.app',
177 'configglue.inischema',
178
179=== modified file 'scripts/ubuntuone.xml'
180--- scripts/ubuntuone.xml 2011-12-28 19:15:16 +0000
181+++ scripts/ubuntuone.xml 2012-03-23 18:38:19 +0000
182@@ -1,7 +1,7 @@
183 <project>
184 <shortName>ubuntuone</shortName>
185 <fullName>Ubuntu One</fullName>
186- <version>2.0.3</version>
187+ <version>2.99.91</version>
188 <componentList>
189 <component>
190 <name>autoupdater</name>
191@@ -46,8 +46,7 @@
192 <platforms>windows</platforms>
193 <runAsAdmin>0</runAsAdmin>
194 <runInTerminal>0</runInTerminal>
195- <windowsExec>${installdir}\dist\ubuntuone-installer-qt.exe</windowsExec>
196- <windowsExecArgs></windowsExecArgs>
197+ <windowsExec>${installdir}\dist\ubuntuone-control-panel-qt.exe</windowsExec>
198 <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon>
199 <windowsPath>${windows_folder_desktopdirectory}</windowsPath>
200 </shortcut>
201@@ -136,7 +135,7 @@
202 <name>Ubuntu One</name>
203 <runAsAdmin>0</runAsAdmin>
204 <runInTerminal>0</runInTerminal>
205- <windowsExec>${installdir}\dist\ubuntuone-installer-qt.exe</windowsExec>
206+ <windowsExec>${installdir}\dist\ubuntuone-control-panel-qt.exe</windowsExec>
207 <windowsExecArgs></windowsExecArgs>
208 <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon>
209 <windowsPath>${windows_folder_desktopdirectory}</windowsPath>
210@@ -228,7 +227,7 @@
211 </registrySet>
212 <runProgram>
213 <program>${windows_folder_system}\RunDll32.exe</program>
214- <programArguments>"${installdir}\dist\VistaLib32.dll" RunNonElevated "${installdir}\dist\ubuntuone-installer-qt.exe" --installer &amp;</programArguments>
215+ <programArguments>"${installdir}\dist\VistaLib32.dll" RunNonElevated "${installdir}\dist\ubuntuone-control-panel-qt.exe --installer &amp;"</programArguments>
216 <useMSDOSPath>0</useMSDOSPath>
217 <ruleList>
218 <compareText>
219@@ -243,7 +242,7 @@
220 </runProgram>
221 <runProgram>
222 <program>${windows_folder_system}\RunDll32.exe</program>
223- <programArguments>"${installdir}\dist\VistaLib64.dll" RunNonElevated "${installdir}\dist\ubuntuone-installer-qt.exe" --installer &amp;</programArguments>
224+ <programArguments>"${installdir}\dist\VistaLib64.dll" RunNonElevated "${installdir}\dist\ubuntuone-control-panel-qt.exe" --installer &amp;</programArguments>
225 <useMSDOSPath>0</useMSDOSPath>
226 <ruleList>
227 <compareText>
228@@ -256,6 +255,7 @@
229 </platformTest>
230 </ruleList>
231 </runProgram>
232+ <!-- TODO: remove this showInfo? -->
233 <showInfo>
234 <text>Please reboot to finish upgrade.</text>
235 <ruleList>
236
237=== modified file 'scripts/ubuntuone_autoupdate.xml'
238--- scripts/ubuntuone_autoupdate.xml 2011-12-14 20:42:38 +0000
239+++ scripts/ubuntuone_autoupdate.xml 2012-03-23 18:38:19 +0000
240@@ -2,7 +2,7 @@
241 <fullName>Ubuntu One</fullName>
242 <shortName>ubuntuone</shortName>
243 <vendor>Canonical</vendor>
244- <version>203</version>
245+ <version>1000</version>
246 <singleInstanceCheck>1</singleInstanceCheck>
247 <requireInstallationByRootUser>0</requireInstallationByRootUser>
248 <requestedExecutionLevel>asInvoker</requestedExecutionLevel>

Subscribers

People subscribed via source and target branches