Merge lp:~ralsina/ubuntuone-control-panel/tweaks into lp:ubuntuone-control-panel
Status: | Merged |
---|---|
Approved by: | Natalia Bidart |
Approved revision: | 296 |
Merged at revision: | 291 |
Proposed branch: | lp:~ralsina/ubuntuone-control-panel/tweaks |
Merge into: | lp:ubuntuone-control-panel |
Diff against target: |
250 lines (+89/-24) 6 files modified
data/qt/controlpanel.ui (+9/-0) data/qt/folders.ui (+4/-1) data/qt/ubuntuone.qss (+75/-15) ubuntuone/controlpanel/gui/qt/folders.py (+1/-2) ubuntuone/controlpanel/gui/qt/gotoweb.py (+0/-2) ubuntuone/controlpanel/gui/qt/tests/test_gotoweb.py (+0/-4) |
To merge this branch: | bzr merge lp:~ralsina/ubuntuone-control-panel/tweaks |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Natalia Bidart (community) | Approve | ||
dobey (community) | Approve | ||
Eric Casteleijn (community) | Approve | ||
Review via email: mp+97244@code.launchpad.net |
Commit message
- Added several tweaks to the UI stylesheet to avoid 'movements' when focusing a button, and to remove the ugly border from the twitter and facebook buttons.
Description of the change
Here are the changes with before/after images
* Remove borders from non-focused twitter/facebook buttons
Before: http://
After: http://
* Change in the no-orange-overlay hack from 20px to 100%
No visible change except on rare occasions where 20px made pieces of text hide
* Do the GotoWebButtons arrows using qss and not setIcon
* Make the GotoWebButtons not shift when focused
Before, the text and icon shifted when you focused the button.
Now, they don't. The padding is different, and is not consistent
between buttons so it needs tweaking, if we go this way.
Before/after: http://
* Changed background color on folder list activated item
Before, you could not see focus halos on buttons and checkboxes because of color clash:
http://
After:
http://
* Focus halo on QCheckboxes
Before: the checkbox contents shifted when focused
http://
Now: no shifting
http://
* Style fix for focused Checkbox in folder list
Before:
http://
After: Not terribly happy about it, really.
http://
* Focus halo on QSpinBox
Before: http://
After: http://
======= ======= ======= ======= ======= ======= ======= ======= ======= ======= ======= == nessita/ canonical/ controlpanel/ review_ tweaks/ ubuntuone/ controlpanel/ gui/qt/ tests/test_ gotoweb. py", line 47, in test_layout_ direction assertEqual( self.ui. layoutDirection (), gui.QtCore. Qt.RightToLeft) python2. 7/dist- packages/ twisted/ trial/unittest. py", line 270, in assertEqual trial.unittest. FailTest: not equal:
[FAIL]
Traceback (most recent call last):
File "/home/
self.
File "/usr/lib/
% (msg, pformat(first), pformat(second)))
twisted.
a = 0
b = 1
ubuntuone. controlpanel. gui.qt. tests.test_ gotoweb. GoToWebButtonTe stCase. test_layout_ direction ------- ------- ------- ------- ------- ------- ------- ------- ------- ------- --
-------
Ran 861 tests in 7.354s
FAILED (skips=2, failures=1, successes=858)