Merge lp:~ralsina/ubuntuone-control-panel/fix-983665 into lp:ubuntuone-control-panel

[Roberto Alsina]

- Reverse styling for web buttons in RTL locales (Fixes LP:983665)

Fix button styling for LTR locales.

To test:

PYTHONPATH=. bin/ubuntuone-control-panel-qt -reversed

Compare to nightlies:

ubuntuone-control-panel-qt -reversed

Will attach before-after in comment

[Roberto Alsina (ralsina)]

Before: http://www.flickr.com/photos/ralsina/7199814010/in/photostream
After: http://www.flickr.com/photos/ralsina/7199814162/in/photostream

[Diego Sarmentero (diegosarmentero)]

+1

review: Approve

[Alejandro J. Cura (alecu)]

+1

review: Approve

[Alejandro J. Cura (alecu)]

btw: Great work fixing every RTL detail!

[Ubuntu One Auto Pilot (otto-pilot)]

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

=== added file 'data/external_icon_dark_grey-rtl.png'
Binary files data/external_icon_dark_grey-rtl.png	1970-01-01 00:00:00 +0000 and data/external_icon_dark_grey-rtl.png	2012-05-15 15:01:18 +0000 differ
=== added file 'data/external_icon_orange-rtl.png'
Binary files data/external_icon_orange-rtl.png	1970-01-01 00:00:00 +0000 and data/external_icon_orange-rtl.png	2012-05-15 15:01:18 +0000 differ
=== added file 'data/external_icon_white-rtl.png'
Binary files data/external_icon_white-rtl.png	1970-01-01 00:00:00 +0000 and data/external_icon_white-rtl.png	2012-05-15 15:01:18 +0000 differ
=== modified file 'data/qt/images.qrc'
--- data/qt/images.qrc	2012-03-22 16:44:35 +0000
+++ data/qt/images.qrc	2012-05-15 15:01:18 +0000
@@ -5,6 +5,9 @@
     <file>../external_icon_dark_grey.png</file>
     <file>../external_icon_orange.png</file>
     <file>../external_icon_white.png</file>
+    <file>../external_icon_dark_grey-rtl.png</file>
+    <file>../external_icon_orange-rtl.png</file>
+    <file>../external_icon_white-rtl.png</file>
     <file>../icon.png</file>
     <file>../folder.png</file>
     <file>../logo.png</file>
@@ -24,6 +27,7 @@
     <file>../Ubuntu-R.ttf</file>
     <file>../Ubuntu-B.ttf</file>
     <file>ubuntuone.qss</file>
+    <file>ubuntuone-rtl.qss</file>
     <file>linux.qss</file>
     <file>windows.qss</file>
   </qresource>

=== added file 'data/qt/ubuntuone-rtl.qss'
--- data/qt/ubuntuone-rtl.qss	1970-01-01 00:00:00 +0000
+++ data/qt/ubuntuone-rtl.qss	2012-05-15 15:01:18 +0000
@@ -0,0 +1,27 @@
+GoToWebButton#help_button {
+    background-image: url(:/external_icon_dark_grey-rtl.png);
+    background-position: left;
+}
+
+GoToWebButton#share_publish_button {
+    background-image: url(:/external_icon_orange-rtl.png);
+    background-position: left;
+}
+
+GoToWebButton#edit_profile_button,
+GoToWebButton#edit_services_button,
+GoToWebButton#get_more_space_button {
+    background-image: url(:/external_icon_white-rtl.png);
+    background-position: left;
+}
+
+QTabWidget::pane {
+    border-top-left-radius: 5px;
+    border-top-right-radius: 0px;
+}
+
+QFrame#frame_status,
+QFrame#frame_storage {
+    border-right-width: 1px;
+    border-left-width: 0px;
+}

=== modified file 'ubuntuone/controlpanel/gui/qt/main/__init__.py'
--- ubuntuone/controlpanel/gui/qt/main/__init__.py	2012-04-24 17:59:49 +0000
+++ ubuntuone/controlpanel/gui/qt/main/__init__.py	2012-05-15 15:01:18 +0000
@@ -89,7 +89,10 @@
     source.main(app)
 
     data = []
-    for qss_name in (":/ubuntuone.qss", source.PLATFORM_QSS):
+    qss_files = [":/ubuntuone.qss", source.PLATFORM_QSS]
+    if app.isRightToLeft():
+        qss_files.append(":/ubuntuone-rtl.qss")
+    for qss_name in qss_files:
         qss = QtCore.QResource(qss_name)
         data.append(unicode(qss.data()))
     app.setStyleSheet('\n'.join(data))

=== modified file 'ubuntuone/controlpanel/gui/qt/main/tests/test_main.py'
--- ubuntuone/controlpanel/gui/qt/main/tests/test_main.py	2012-04-24 17:59:49 +0000
+++ ubuntuone/controlpanel/gui/qt/main/tests/test_main.py	2012-05-15 15:01:18 +0000
@@ -62,6 +62,10 @@
     def installTranslator(self, translator):
         """Fake installTranslator."""
         self.translator = translator
+
+    def isRightToLeft(self):
+        """Fake isRightToLeft."""
+        return False
     # pylint: enable=C0103
 
     def arguments(self):